[Libreoffice-commits] core.git: fpicker/source

[Caolán McNamara (via logerrit)]

 fpicker/source/office/fileview.cxx |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

New commits:
commit 3c168b1dc876e4fca97f73683572462a29227523
Author:     Caolán McNamara <caol...@redhat.com>
AuthorDate: Mon Oct 18 16:28:03 2021 +0100
Commit:     Caolán McNamara <caol...@redhat.com>
CommitDate: Mon Oct 18 20:29:15 2021 +0200

    Resolves: tdf#145169 only position treeview cursor at the first entry
    
    when the view is filled, don't actually select the entry.
    
    With these single selection trees the default is to select when the
    cursor is positioned, so move the unselect to after the cursor
    positioning to achieve this.
    
    Now nothing is considered "selected" in the view unless the user
    explicitly does that so the contents of the entry are used by default
    on save/load because nothing is selected in the treeview unless the
    user does that.
    
    Change-Id: I2a740616205bab35614f85f62e8240cd11df90ad
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123754
    Tested-by: Caolán McNamara <caol...@redhat.com>
    Reviewed-by: Caolán McNamara <caol...@redhat.com>

diff --git a/fpicker/source/office/fileview.cxx 
b/fpicker/source/office/fileview.cxx
index 788c001a5574..203f1d1d27b3 100644
--- a/fpicker/source/office/fileview.cxx
+++ b/fpicker/source/office/fileview.cxx
@@ -1386,25 +1386,25 @@ void SvtFileView_Impl::ResetCursor()
 {
     if (mxView->get_visible())
     {
-        // deselect
-        mxView->unselect_all();
         std::unique_ptr<weld::TreeIter> xFirst = mxView->make_iterator();
         if (mxView->get_iter_first(*xFirst))
         {
             // set cursor to the first entry
             mxView->set_cursor(*xFirst);
         }
+        // deselect
+        mxView->unselect_all();
     }
     else
     {
-        // deselect
-        mxIconView->unselect_all();
         std::unique_ptr<weld::TreeIter> xFirst = mxIconView->make_iterator();
         if (mxIconView->get_iter_first(*xFirst))
         {
             // set cursor to the first entry
             mxIconView->set_cursor(*xFirst);
         }
+        // deselect
+        mxIconView->unselect_all();
     }
 }