compilerplugins/clang/redundantfcast.cxx                  |    3 +++
 connectivity/source/drivers/firebird/DatabaseMetaData.cxx |    2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)

New commits:
commit 5b20bb65363812388123d36f741e47b6195dde6b
Author:     Julien Nabet <[email protected]>
AuthorDate: Mon Oct 18 22:13:17 2021 +0200
Commit:     Julien Nabet <[email protected]>
CommitDate: Tue Oct 19 23:38:23 2021 +0200

    tdf#145203: FIREBIRD cannot create a table
    
    Regression from:
    
https://cgit.freedesktop.org/libreoffice/core/commit/?id=1cf57765dd9a66982ecf9cd33687005a70c70c3f
    2021-10-08
    loplugin:moveparam in connectivity
    
    Change-Id: Iec0fa1597e63d42ee3a905bf55eff798b3f46177
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123787
    Tested-by: Jenkins
    Reviewed-by: Julien Nabet <[email protected]>

diff --git a/compilerplugins/clang/redundantfcast.cxx 
b/compilerplugins/clang/redundantfcast.cxx
index 4952d37caf79..67ff2c56edef 100644
--- a/compilerplugins/clang/redundantfcast.cxx
+++ b/compilerplugins/clang/redundantfcast.cxx
@@ -331,6 +331,9 @@ public:
         // TODO constructing a temporary to pass to a && param
         if (fn == SRCDIR "/sc/source/ui/view/viewfunc.cxx")
             return false;
+        // tdf#145203: FIREBIRD cannot create a table
+        if (fn == SRCDIR 
"/connectivity/source/drivers/firebird/DatabaseMetaData.cxx")
+            return false;
         return true;
     }
 
diff --git a/connectivity/source/drivers/firebird/DatabaseMetaData.cxx 
b/connectivity/source/drivers/firebird/DatabaseMetaData.cxx
index 8f581dd2505c..f63468f0813f 100644
--- a/connectivity/source/drivers/firebird/DatabaseMetaData.cxx
+++ b/connectivity/source/drivers/firebird/DatabaseMetaData.cxx
@@ -1026,7 +1026,7 @@ uno::Reference< XResultSet > SAL_CALL 
ODatabaseMetaData::getTypeInfo()
         tmp.push_back(aRow);
         return tmp;
     }();
-    pResultSet->setRows(std::move(aResults));
+    pResultSet->setRows(ODatabaseMetaDataResultSet::ORows(aResults));
     return pResultSet;
 }
 

Reply via email to