ucb/source/ucp/webdav-curl/webdavcontent.cxx | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
New commits:
commit df2a39fc61ad33d1c5cd81141c4c4f76a493dc9d
Author: Michael Stahl <michael.st...@allotropia.de>
AuthorDate: Mon Oct 11 20:04:44 2021 +0200
Commit: Michael Stahl <michael.st...@allotropia.de>
CommitDate: Mon Nov 1 18:47:12 2021 +0100
ucb: webdav-curl: add additional comments from commit...
... 827cc09948c09d934dd32ca1867252618f761eab - the code was already
there.
Change-Id: I90b0c617bf060adffd6912529b8fff7897069162
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123487
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.st...@allotropia.de>
diff --git a/ucb/source/ucp/webdav-curl/webdavcontent.cxx
b/ucb/source/ucp/webdav-curl/webdavcontent.cxx
index 6f24f1269e89..f0a0f9baeb0c 100644
--- a/ucb/source/ucp/webdav-curl/webdavcontent.cxx
+++ b/ucb/source/ucp/webdav-curl/webdavcontent.cxx
@@ -100,7 +100,7 @@ void lcl_sendPartialGETRequest( bool &bError,
DAVRequestHeaders aPartialGet;
aPartialGet.push_back(
DAVRequestHeader(
- OUString( "Range" ),
+ OUString( "Range" ), // see
<https://tools.ietf.org/html/rfc7233#section-3.1>
OUString( "bytes=0-0" )));
bool bIsRequestSize = std::any_of(aHeaderNames.begin(), aHeaderNames.end(),
@@ -110,8 +110,8 @@ void lcl_sendPartialGETRequest( bool &bError,
{
// we need to know if the server accepts range requests for a resource
// and the range unit it uses
- aHeaderNames.push_back( OUString( "Accept-Ranges" ) );
- aHeaderNames.push_back( OUString( "Content-Range" ) );
+ aHeaderNames.push_back( OUString( "Accept-Ranges" ) ); // see
<https://tools.ietf.org/html/rfc7233#section-2.3>
+ aHeaderNames.push_back( OUString( "Content-Range" ) ); // see
<https://tools.ietf.org/html/rfc7233#section-4.2>
}
try
{
@@ -1498,6 +1498,7 @@ uno::Reference< sdbc::XRow > Content::getPropertyValues(
aLastException.getStatus() ==
SC_METHOD_NOT_ALLOWED ||
aLastException.getStatus() == SC_NOT_FOUND )
{
+ SAL_WARN( "ucb.ucp.webdav", "HEAD not implemented:
fall back to a partial GET" );
lcl_sendPartialGETRequest( bError,
aLastException,
aMissingProps,
