compilerplugins/clang/unusedenumconstants.readonly.results | 2 -- include/vcl/menu.hxx | 8 +------- vcl/source/window/menu.cxx | 3 --- 3 files changed, 1 insertion(+), 12 deletions(-)
New commits: commit 9f68cc110c16cc096f5549a4a0812cee56cb09db Author: Caolán McNamara <[email protected]> AuthorDate: Wed Nov 17 16:31:07 2021 +0000 Commit: Caolán McNamara <[email protected]> CommitDate: Wed Nov 17 20:49:02 2021 +0100 drop unused PopupMenuFlags::NoHorzPlacement Change-Id: Ic279160f96e5aa2a37690f987c2323b91b2ec49c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125415 Tested-by: Caolán McNamara <[email protected]> Reviewed-by: Caolán McNamara <[email protected]> diff --git a/compilerplugins/clang/unusedenumconstants.readonly.results b/compilerplugins/clang/unusedenumconstants.readonly.results index 935e74505021..02ec1e8a728f 100644 --- a/compilerplugins/clang/unusedenumconstants.readonly.results +++ b/compilerplugins/clang/unusedenumconstants.readonly.results @@ -512,8 +512,6 @@ include/vcl/keycodes.hxx:175 enum ModKeyFlags Mod2Msk include/vcl/menu.hxx:78 enum PopupMenuFlags ExecuteUp -include/vcl/menu.hxx:86 - enum PopupMenuFlags NoHorzPlacement include/vcl/pdf/PDFAnnotationSubType.hxx:17 enum vcl::pdf::PDFAnnotationSubType Unknown include/vcl/pdf/PDFAnnotationSubType.hxx:26 diff --git a/include/vcl/menu.hxx b/include/vcl/menu.hxx index c0a627a30f88..f96c775fa64d 100644 --- a/include/vcl/menu.hxx +++ b/include/vcl/menu.hxx @@ -77,17 +77,11 @@ enum class PopupMenuFlags ExecuteUp = 0x0002, ExecuteRight = 0x0008, NoMouseUpClose = 0x0010, -//If there isn't enough space to put the menu where it wants -//to go, then they will be autoplaced. Toggle this bit -//on to force menus to be placed either above or below -//the starting rectangle and shrunk to fit and then scroll rather than place -//the menu beside that rectangle - NoHorzPlacement = 0x0020, }; namespace o3tl { - template<> struct typed_flags<PopupMenuFlags> : is_typed_flags<PopupMenuFlags, 0x003b> {}; + template<> struct typed_flags<PopupMenuFlags> : is_typed_flags<PopupMenuFlags, 0x001b> {}; } enum class MenuFlags diff --git a/vcl/source/window/menu.cxx b/vcl/source/window/menu.cxx index 797740d127b8..53f5e28e6f53 100644 --- a/vcl/source/window/menu.cxx +++ b/vcl/source/window/menu.cxx @@ -2798,9 +2798,6 @@ sal_uInt16 PopupMenu::Execute( vcl::Window* pExecWindow, const tools::Rectangle& if (nFlags & PopupMenuFlags::NoMouseUpClose ) // allow popup menus to stay open on mouse button up nPopupModeFlags |= FloatWinPopupFlags::NoMouseUpClose; // useful if the menu was opened on mousebutton down (eg toolbox configuration) - if (nFlags & PopupMenuFlags::NoHorzPlacement) - nPopupModeFlags |= FloatWinPopupFlags::NoHorzPlacement; - return ImplExecute( pExecWindow, rRect, nPopupModeFlags, nullptr, false ); }
