[Libreoffice-commits] core.git: sc/source

[Caolán McNamara (via logerrit)]

 sc/source/filter/xcl97/xcl97esc.cxx |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

New commits:
commit e48ebfd576ab9547c89d23d647a14b43a85d70ea
Author:     Caolán McNamara <caol...@redhat.com>
AuthorDate: Mon Feb 21 12:19:43 2022 +0000
Commit:     Caolán McNamara <caol...@redhat.com>
CommitDate: Mon Feb 21 15:44:45 2022 +0100

    cid#1500559 silence Dereference before null check
    
    Change-Id: I515c2ba2b1a258dd897f28b12a08f1d1f48106d6
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130274
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caol...@redhat.com>

diff --git a/sc/source/filter/xcl97/xcl97esc.cxx 
b/sc/source/filter/xcl97/xcl97esc.cxx
index d1bb478429c8..1ecb0891dc20 100644
--- a/sc/source/filter/xcl97/xcl97esc.cxx
+++ b/sc/source/filter/xcl97/xcl97esc.cxx
@@ -433,8 +433,7 @@ std::unique_ptr<XclExpTbxControlObj> 
XclEscherEx::CreateTBXCtrlObj( Reference< X
     ::std::unique_ptr< XclExpTbxControlObj > xTbxCtrl( new 
XclExpTbxControlObj( mrObjMgr, xShape, pChildAnchor ) );
     if( xTbxCtrl->GetObjType() == EXC_OBJTYPE_UNKNOWN )
         xTbxCtrl.reset();
-
-    if (xTbxCtrl)
+    else
     {
         // find attached macro
         Reference< XControlModel > xCtrlModel = 
XclControlHelper::GetControlModel( xShape );