drawinglayer/source/primitive2d/mediaprimitive2d.cxx |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 4946efd9b9ea532bc3b54f45f412424d1bbe70b0
Author:     Caolán McNamara <[email protected]>
AuthorDate: Fri Feb 25 21:06:51 2022 +0000
Commit:     Caolán McNamara <[email protected]>
CommitDate: Sat Feb 26 11:34:32 2022 +0100

    Video preview doesn't redraw if the preview image changes
    
    because there is no check to see if the preview changed here.
    
    But because (bizarely?) Graphic::operator== returns true when the lhs is
    an empty graphic regardless of the rhs due to:
    
    bool ImpGraphic::operator==(const ImpGraphic& rImpGraphic) const
    {
        ///
        switch( meType )
        {
            case GRAPHIC_NONE:
                bRet = true;
            break;
        ...
        }
    
        return bRet;
    }
    
    don't use that and instead just compare if the graphics contain
    something or not which is sufficient for my needs
    
    Change-Id: Ia3266e289b3a42ee30bdb9523bac29fb73f5e341
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130545
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <[email protected]>

diff --git a/drawinglayer/source/primitive2d/mediaprimitive2d.cxx 
b/drawinglayer/source/primitive2d/mediaprimitive2d.cxx
index 108f53bf1431..cd36291428ea 100644
--- a/drawinglayer/source/primitive2d/mediaprimitive2d.cxx
+++ b/drawinglayer/source/primitive2d/mediaprimitive2d.cxx
@@ -113,7 +113,8 @@ namespace drawinglayer::primitive2d
                 return (getTransform() == rCompare.getTransform()
                     && maURL == rCompare.maURL
                     && getBackgroundColor() == rCompare.getBackgroundColor()
-                    && getDiscreteBorder() == rCompare.getDiscreteBorder());
+                    && getDiscreteBorder() == rCompare.getDiscreteBorder()
+                    && maSnapshot.IsNone() == rCompare.maSnapshot.IsNone());
             }
 
             return false;

Reply via email to