On Fri, May 25, 2012 at 05:36:34PM +0200, Michael Stahl wrote: > On 25/05/12 17:16, Stephan Bergmann wrote: > > On 05/25/2012 01:28 PM, David Tardon wrote: > >> At the end, an anecdotical evidence about how far we progressed into > >> gbuild land: the move of gtk/kde file pickers from fpicker to vcl > >> introduced a dependency loop, because the pickers in vcl depend on > >> headers from fpicker, but fpicker already (indirectly) depends on vcl. > > > > What is our attitude towards circular module dependencies in an > > all-gbuild scenario? My understanding is that technically they do not > > pose a problem. But how about them from a hygiene point of view? (And > > if we want to avoid them, would there be technical measures to do so?) > > i believe cyclical dependencies indicate bad architecture. if 2 modules > depend on each other, then either they should be changed not to depend > on each other, or merged into one module.
Actually this was only because of one .hrc file, so I moved it from fpicker to vcl and everything is all right again. D. _______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
