Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
3 new defect(s) introduced to LibreOffice found with Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 3 of 3 defect(s)
** CID 1503836: Null pointer dereferences (NULL_RETURNS)
________________________________________________________________________________________________________
*** CID 1503836: Null pointer dereferences (NULL_RETURNS)
/sd/source/ui/view/drviews2.cxx: 601 in
sd::<unnamed>::lcl_convertStringArguments(unsigned short, const
std::unique_ptr<SfxItemSet, std::default_delete<SfxItemSet>> &)()
595 }
596 }
597
598 if (nSlot == SID_ATTR_FILL_COLOR)
599 {
600 // Merge the color parameters to the color itself.
>>> CID 1503836: Null pointer dereferences (NULL_RETURNS)
>>> Dereferencing a pointer that might be "nullptr"
>>> "static_cast<XFillColorItem const *>(pArgs->GetItem(10165, true))" when
>>> calling "XFillColorItem".
601 XFillColorItem aColorItem(
602 *static_cast<const
XFillColorItem*>(pArgs->GetItem(SID_ATTR_FILL_COLOR)));
603 if (pArgs->GetItemState(SID_ATTR_COLOR_THEME_INDEX, false,
&pItem) == SfxItemState::SET)
604 {
605 auto pIntItem = static_cast<const SfxInt16Item*>(pItem);
606
aColorItem.GetThemeColor().SetThemeIndex(pIntItem->GetValue());
** CID 1503835: Incorrect expression (UNINTENDED_INTEGER_DIVISION)
/sc/source/core/data/column2.cxx: 828 in
ScColumn::GetOptimalColWidth(OutputDevice *, double, double, const Fraction &,
const Fraction &, bool, unsigned short, const ScMarkData *, const
ScColWidthParam *) const()
________________________________________________________________________________________________________
*** CID 1503835: Incorrect expression (UNINTENDED_INTEGER_DIVISION)
/sc/source/core/data/column2.cxx: 828 in
ScColumn::GetOptimalColWidth(OutputDevice *, double, double, const Fraction &,
const Fraction &, bool, unsigned short, const ScMarkData *, const
ScColWidthParam *) const()
822 }
823
824 if (bFound)
825 {
826 nWidth += 2;
827 sal_uInt16 nTwips = static_cast<sal_uInt16>(
>>> CID 1503835: Incorrect expression (UNINTENDED_INTEGER_DIVISION)
>>> Dividing integer expressions "65535" and "2", and then converting the
>>> integer quotient to type "double". Any remainder, or fractional part of the
>>> quotient, is ignored.
828 std::min(nWidth / nPPTX,
double(std::numeric_limits<sal_uInt16>::max() / 2)));
829 return nTwips;
830 }
831 else
832 return nOldWidth;
833 }
** CID 1503834: Incorrect expression (COPY_PASTE_ERROR)
/sc/source/ui/dialogs/SparklineDialog.cxx: 256 in
sc::SparklineDialog::setupValues()()
________________________________________________________________________________________________________
*** CID 1503834: Incorrect expression (COPY_PASTE_ERROR)
/sc/source/ui/dialogs/SparklineDialog.cxx: 256 in
sc::SparklineDialog::setupValues()()
250 case sc::AxisType::Group:
251 mxComboMaxAxisType->set_active(1);
252 mxSpinCustomMax->GetFormatter().SetValue(0.0);
253 break;
254 case sc::AxisType::Custom:
255 mxComboMaxAxisType->set_active(2);
>>> CID 1503834: Incorrect expression (COPY_PASTE_ERROR)
>>> "getManualMin" in "this->maAttributes.getManualMin()" looks like a
>>> copy-paste error.
256 if (maAttributes.getManualMin())
257
mxSpinCustomMax->GetFormatter().SetValue(*maAttributes.getManualMax());
258 break;
259 }
260 ComboValueChanged(*mxComboMaxAxisType);
261 }
________________________________________________________________________________________________________
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3D3T6Q_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJi-2BeWjReMKf6MH-2FhLFbl6KbdigEbX8Hq2fMnF0HZqCec-2BRwd3uFlObVrx9ZE2lCsKqJBi8pKL1y-2B2m-2BYrxapR-2B1-2FHdZduOdpEqLRkKDE283Tbc02gXnACfSnrDbKZ6HgWpTLpi4FkSHerHz-2FM9gCK5k3wGBxMo64kdplXd8Up-2BYvw-3D
