offapi/com/sun/star/frame/status/ItemState.idl | 12 ++++++------ vcl/unx/gtk3/gtkinst.cxx | 2 +- 2 files changed, 7 insertions(+), 7 deletions(-)
New commits: commit dfafd186f5884bfb7a19582b36677a051bde8101 Author: Caolán McNamara <[email protected]> AuthorDate: Thu Apr 14 09:30:00 2022 +0100 Commit: Caolán McNamara <[email protected]> CommitDate: Thu Apr 14 12:16:44 2022 +0200 warning: explicit link request to 'ItemState' could not be resolved Change-Id: Ied2c063d532a5da01d5b542e6f44ab49d198a942 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132998 Tested-by: Jenkins Reviewed-by: Caolán McNamara <[email protected]> diff --git a/offapi/com/sun/star/frame/status/ItemState.idl b/offapi/com/sun/star/frame/status/ItemState.idl index 011f5ba2b6fd..c4c02d56c821 100644 --- a/offapi/com/sun/star/frame/status/ItemState.idl +++ b/offapi/com/sun/star/frame/status/ItemState.idl @@ -46,12 +46,12 @@ constants ItemState * anymore due to not being used, so remove for simplification * reasons and to prepare rework of Item/ItemSet/ItemPool stuff. * - * There are only three usages of ::ItemState in the code which - * all set the internal SfxItem to SfxVoidItem when triggered, - * which is equivalent to state SfxItemState::DISABLED (see - * e.g. SfxItemSet::GetItemState), so READ_ONLY gets not used - * in internal handling, even when eventually existing UNO API - * usages hand it over the office. + * There are only three usages of com::sun::star::frame::status::ItemState + * in the code which all set the internal SfxItem to SfxVoidItem when + * triggered, which is equivalent to state SfxItemState::DISABLED (see e.g. + * SfxItemSet::GetItemState), so READ_ONLY gets not used in internal + * handling, even when eventually existing UNO API usages hand it over the + * office. */ const short READ_ONLY = 2; commit a8f89d5a6240b5e374e19c0c4df377f8b1f80e2f Author: Caolán McNamara <[email protected]> AuthorDate: Thu Apr 14 09:13:35 2022 +0100 Commit: Caolán McNamara <[email protected]> CommitDate: Thu Apr 14 12:16:30 2022 +0200 tdf#148197 gtk_tree_row_reference_new_proxy warning on docking navigator Gtk-CRITICAL **: 09:05:11.124: gtk_tree_row_reference_new_proxy: assertion 'path->depth > 0' failed from TreeView::set_cursor(-1) gtk_tree_view_set_cursor is ok (and documented as such) with an "invalid" path to unset the cursor, but there isn't the same for gtk_tree_view_scroll_to_cell, though there null is docs as acceptable. Change-Id: I11b94ba997fbbd2f31031d9e73765ea1882ad9ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132996 Tested-by: Jenkins Reviewed-by: Caolán McNamara <[email protected]> diff --git a/vcl/unx/gtk3/gtkinst.cxx b/vcl/unx/gtk3/gtkinst.cxx index 4d6679a31ef7..42e5b6971b8c 100644 --- a/vcl/unx/gtk3/gtkinst.cxx +++ b/vcl/unx/gtk3/gtkinst.cxx @@ -14682,7 +14682,7 @@ public: virtual void set_cursor(int pos) override { disable_notify_events(); - GtkTreePath* path = gtk_tree_path_new_from_indices(pos, -1); + GtkTreePath* path = pos != -1 ? gtk_tree_path_new_from_indices(pos, -1) : nullptr; gtk_tree_view_scroll_to_cell(m_pTreeView, path, nullptr, false, 0, 0); gtk_tree_view_set_cursor(m_pTreeView, path, nullptr, false); gtk_tree_path_free(path);
