[Libreoffice-commits] core.git: uui/source

[Noel Grandin (via logerrit)]

 uui/source/iahndl.cxx   |    9 +++++----
 uui/source/iahndl.hxx   |    2 +-
 uui/source/logindlg.cxx |    5 +++--
 uui/source/logindlg.hxx |    2 +-
 4 files changed, 10 insertions(+), 8 deletions(-)

New commits:
commit fea45cc200f2e30c0af7f1a81a2a6bfa38f6293c
Author:     Noel Grandin <noel.gran...@collabora.co.uk>
AuthorDate: Wed Jun 1 08:59:07 2022 +0200
Commit:     Noel Grandin <noel.gran...@collabora.co.uk>
CommitDate: Wed Jun 1 14:18:05 2022 +0200

    clang-tidy modernize-pass-by-value in uui
    
    Change-Id: I55f55554e325ae67a7b9fa36ee12b14804fe446b
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135217
    Tested-by: Jenkins
    Reviewed-by: Noel Grandin <noel.gran...@collabora.co.uk>

diff --git a/uui/source/iahndl.cxx b/uui/source/iahndl.cxx
index 9f6a3d34b9d6..a704baf135f6 100644
--- a/uui/source/iahndl.cxx
+++ b/uui/source/iahndl.cxx
@@ -62,6 +62,7 @@
 #include <rtl/ustrbuf.hxx>
 #include <osl/conditn.hxx>
 #include <unotools/resmgr.hxx>
+#include <utility>
 #include <vcl/errinf.hxx>
 #include <vcl/svapp.hxx>
 #include <vcl/weld.hxx>
@@ -108,8 +109,8 @@ class HandleData : public osl::Condition
 {
 public:
     explicit HandleData(
-        uno::Reference< task::XInteractionRequest > const & rRequest)
-        : m_rRequest(rRequest),
+        uno::Reference< task::XInteractionRequest > xRequest)
+        : m_rRequest(std::move(xRequest)),
           bHandled( false )
     {
     }
@@ -121,8 +122,8 @@ public:
 } /* namespace */
 
 UUIInteractionHelper::UUIInteractionHelper(
-    uno::Reference< uno::XComponentContext > const & rxContext)
-    :  m_xContext(rxContext)
+    uno::Reference< uno::XComponentContext > xContext)
+    :  m_xContext(std::move(xContext))
 {
 }
 
diff --git a/uui/source/iahndl.hxx b/uui/source/iahndl.hxx
index a43122b7adb4..7ca8b8437891 100644
--- a/uui/source/iahndl.hxx
+++ b/uui/source/iahndl.hxx
@@ -80,7 +80,7 @@ private:
 
 public:
     explicit UUIInteractionHelper(
-        css::uno::Reference< css::uno::XComponentContext > const & rxContext);
+        css::uno::Reference< css::uno::XComponentContext > xContext);
 
     const css::uno::Reference<css::awt::XWindow> & GetParentWindow() const { 
return m_xWindowParam; }
     void SetParentWindow(const css::uno::Reference<css::awt::XWindow>& 
rWindow) { m_xWindowParam = rWindow; }
diff --git a/uui/source/logindlg.cxx b/uui/source/logindlg.cxx
index 11c6b20394bd..3df8ed8caf4c 100644
--- a/uui/source/logindlg.cxx
+++ b/uui/source/logindlg.cxx
@@ -18,6 +18,7 @@
  */
 
 #include <comphelper/string.hxx>
+#include <utility>
 #include "logindlg.hxx"
 
 #ifdef UNX
@@ -111,7 +112,7 @@ IMPL_LINK_NOARG(LoginDialog, UseSysCredsHdl_Impl, 
weld::Toggleable&, void)
 }
 
 LoginDialog::LoginDialog(weld::Window* pParent, LoginFlags nFlags,
-    const OUString& rServer, const OUString& rRealm)
+    OUString aServer, OUString aRealm)
     : GenericDialogController(pParent, "uui/ui/logindialog.ui", "LoginDialog")
     , m_xErrorFT(m_xBuilder->weld_label("errorft"))
     , m_xErrorInfo(m_xBuilder->weld_label("errorinfo"))
@@ -125,7 +126,7 @@ LoginDialog::LoginDialog(weld::Window* pParent, LoginFlags 
nFlags,
     , m_xSavePasswdBtn(m_xBuilder->weld_check_button("remember"))
     , m_xUseSysCredsCB(m_xBuilder->weld_check_button("syscreds"))
     , m_xOKBtn(m_xBuilder->weld_button("ok"))
-    , m_server(rServer), m_realm(rRealm)
+    , m_server(std::move(aServer)), m_realm(std::move(aRealm))
 {
     if ( !( nFlags & LoginFlags::NoUseSysCreds ) )
       EnableUseSysCredsControls_Impl( m_xUseSysCredsCB->get_active() );
diff --git a/uui/source/logindlg.hxx b/uui/source/logindlg.hxx
index 82bc18544842..4dfe8fc962b8 100644
--- a/uui/source/logindlg.hxx
+++ b/uui/source/logindlg.hxx
@@ -62,7 +62,7 @@ class LoginDialog : public weld::GenericDialogController
 
 public:
     LoginDialog(weld::Window* pParent, LoginFlags nFlags,
-        const OUString& rServer, const OUString &rRealm);
+        OUString aServer, OUString aRealm);
     virtual ~LoginDialog() override;
 
     OUString        GetName() const                             { return 
m_xNameED->get_text(); }