chart2/source/view/axes/VAxisBase.cxx | 9 ++++----- chart2/source/view/axes/VAxisBase.hxx | 4 ++-- drawinglayer/source/primitive2d/discreteshadowprimitive2d.cxx | 9 ++++----- include/drawinglayer/primitive2d/discreteshadowprimitive2d.hxx | 4 ++-- 4 files changed, 12 insertions(+), 14 deletions(-)
New commits: commit 53786f02fde9fa544a8d385d1f651b871030c220 Author: Caolán McNamara <[email protected]> AuthorDate: Sat Jun 18 12:44:44 2022 +0100 Commit: Caolán McNamara <[email protected]> CommitDate: Sat Jun 18 15:23:53 2022 +0200 cid#1506305 Big parameter passed by value and cid#1506307 Big parameter passed by value Change-Id: I7386eeea04f73a4ec9fe0fe09ff2981b2022be89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136079 Tested-by: Jenkins Reviewed-by: Caolán McNamara <[email protected]> diff --git a/chart2/source/view/axes/VAxisBase.cxx b/chart2/source/view/axes/VAxisBase.cxx index f99b88236019..ace362a9b964 100644 --- a/chart2/source/view/axes/VAxisBase.cxx +++ b/chart2/source/view/axes/VAxisBase.cxx @@ -28,7 +28,6 @@ #include <osl/diagnose.h> #include <memory> -#include <utility> namespace chart { @@ -37,11 +36,11 @@ using namespace ::com::sun::star::chart2; using ::com::sun::star::uno::Reference; VAxisBase::VAxisBase( sal_Int32 nDimensionIndex, sal_Int32 nDimensionCount - , AxisProperties aAxisProperties - , uno::Reference< util::XNumberFormatsSupplier > xNumberFormatsSupplier ) + , const AxisProperties& rAxisProperties + , const uno::Reference< util::XNumberFormatsSupplier >& xNumberFormatsSupplier ) : VAxisOrGridBase( nDimensionIndex, nDimensionCount ) - , m_xNumberFormatsSupplier(std::move( xNumberFormatsSupplier )) - , m_aAxisProperties(std::move( aAxisProperties )) + , m_xNumberFormatsSupplier( xNumberFormatsSupplier ) + , m_aAxisProperties( rAxisProperties ) , m_bUseTextLabels( false ) , m_bReCreateAllTickInfos( true ) , m_bRecordMaximumTextSize(false) diff --git a/chart2/source/view/axes/VAxisBase.hxx b/chart2/source/view/axes/VAxisBase.hxx index 205b5c20b987..31badb749c9d 100644 --- a/chart2/source/view/axes/VAxisBase.hxx +++ b/chart2/source/view/axes/VAxisBase.hxx @@ -31,8 +31,8 @@ class VAxisBase : public VAxisOrGridBase { public: VAxisBase( sal_Int32 nDimensionIndex, sal_Int32 nDimensionCount - , AxisProperties aAxisProperties - , css::uno::Reference< css::util::XNumberFormatsSupplier > xNumberFormatsSupplier ); + , const AxisProperties& rAxisProperties + , const css::uno::Reference< css::util::XNumberFormatsSupplier >& xNumberFormatsSupplier ); virtual ~VAxisBase() override; /** diff --git a/drawinglayer/source/primitive2d/discreteshadowprimitive2d.cxx b/drawinglayer/source/primitive2d/discreteshadowprimitive2d.cxx index e7e1279b5fce..290d9d2d7ffd 100644 --- a/drawinglayer/source/primitive2d/discreteshadowprimitive2d.cxx +++ b/drawinglayer/source/primitive2d/discreteshadowprimitive2d.cxx @@ -25,7 +25,6 @@ #include <drawinglayer/geometry/viewinformation2d.hxx> #include <osl/diagnose.h> #include <toolkit/helper/vclunohelper.hxx> -#include <utility> namespace drawinglayer::primitive2d @@ -257,10 +256,10 @@ namespace drawinglayer::primitive2d } DiscreteShadowPrimitive2D::DiscreteShadowPrimitive2D( - basegfx::B2DHomMatrix aTransform, - DiscreteShadow aDiscreteShadow) - : maTransform(std::move(aTransform)), - maDiscreteShadow(std::move(aDiscreteShadow)) + const basegfx::B2DHomMatrix& rTransform, + const DiscreteShadow& rDiscreteShadow) + : maTransform(rTransform), + maDiscreteShadow(rDiscreteShadow) { } diff --git a/include/drawinglayer/primitive2d/discreteshadowprimitive2d.hxx b/include/drawinglayer/primitive2d/discreteshadowprimitive2d.hxx index 81e6bb689389..435ab98253bd 100644 --- a/include/drawinglayer/primitive2d/discreteshadowprimitive2d.hxx +++ b/include/drawinglayer/primitive2d/discreteshadowprimitive2d.hxx @@ -91,8 +91,8 @@ namespace drawinglayer::primitive2d public: /// constructor DiscreteShadowPrimitive2D( - basegfx::B2DHomMatrix aTransform, - DiscreteShadow aDiscreteShadow); + const basegfx::B2DHomMatrix& rTransform, + const DiscreteShadow& rDiscreteShadow); /// data read access const basegfx::B2DHomMatrix& getTransform() const { return maTransform; }
