sal/osl/w32/tempfile.cxx | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 2d074a0b98c9150d2f15056ea86dcc9305f43ab3
Author: Caolán McNamara <caol...@redhat.com>
AuthorDate: Tue Aug 9 11:38:47 2022 +0100
Commit: Caolán McNamara <caol...@redhat.com>
CommitDate: Tue Aug 9 16:49:54 2022 +0200
crashreporting: frequent crash seen in PackedFile::flush
at:
if (osl::File::E_None == osl::FileBase::createTempFile(nullptr, &aHandle,
&aTempURL))
{
....
if (osl_File_E_None == osl_writeFile(aHandle, ...
createTempFile is returning osl::File::E_None but presumably we are
missing setting a possible error state here
https:
//crashreport.libreoffice.org/stats/crash_details/ea4b4050-dd0f-42b1-b30f-b67612806371
Change-Id: Ib2d0c3c91e40fe985571e79822b91f2faf401471
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138013
Reviewed-by: Stephan Bergmann <sberg...@redhat.com>
Tested-by: Jenkins
diff --git a/sal/osl/w32/tempfile.cxx b/sal/osl/w32/tempfile.cxx
index a4c272e57768..5d5d758ce244 100644
--- a/sal/osl/w32/tempfile.cxx
+++ b/sal/osl/w32/tempfile.cxx
@@ -192,7 +192,7 @@ oslFileError SAL_CALL osl_createTempFile(
if (tmp_name)
{
- osl_createTempFile_impl_(
+ osl_error = osl_createTempFile_impl_(
base_directory,
tmp_name,
b_delete_on_close,
