vcl/source/gdi/impglyphitem.cxx | 4 ---- 1 file changed, 4 deletions(-)
New commits: commit 7e428644ff93ecccda9196ebff8883f6f077c7b8 Author: Luboš Luňák <[email protected]> AuthorDate: Thu Aug 11 15:02:02 2022 +0200 Commit: Caolán McNamara <[email protected]> CommitDate: Sat Aug 13 16:43:30 2022 +0200 fix checking glyph break position (tdf#150138) Glyphs in RTL mode are in reverse, which includes the fast that a cluster start is last, not first. So going back requires means going back just one glyph, not a whole cluster. I'm not sure why I originally did it this way, tdf#148954 works fine even this way, so presumably I got confused. Change-Id: I6ed0caf4e64e93e0643f7b88099bc7c992ea3329 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138144 Tested-by: Jenkins Reviewed-by: Luboš Luňák <[email protected]> (cherry picked from commit fd82419a27014f7b53138332b252f0ea7f17000a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138125 Reviewed-by: Caolán McNamara <[email protected]> diff --git a/vcl/source/gdi/impglyphitem.cxx b/vcl/source/gdi/impglyphitem.cxx index 124ae16f2e20..7dd090929907 100644 --- a/vcl/source/gdi/impglyphitem.cxx +++ b/vcl/source/gdi/impglyphitem.cxx @@ -190,10 +190,6 @@ bool SalLayoutGlyphsImpl::isSafeToBreak(const_iterator pos, bool rtl) const if (pos == begin()) return true; --pos; - while (pos >= begin() && (pos->IsInCluster() && !pos->IsClusterStart())) - --pos; - if (pos < begin()) - return true; } // Don't create a subset if it's not safe to break at the beginning or end of the sequence // (https://harfbuzz.github.io/harfbuzz-hb-buffer.html#hb-glyph-flags-t).
