[Libreoffice-commits] core.git: linguistic/source

[Caolán McNamara (via logerrit)]

 linguistic/source/convdic.cxx |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 3968bd07f3052c5ff90ed173c851e62d551e4012
Author:     Caolán McNamara <caol...@redhat.com>
AuthorDate: Fri Aug 26 08:58:18 2022 +0100
Commit:     Caolán McNamara <caol...@redhat.com>
CommitDate: Fri Aug 26 11:35:50 2022 +0200

    cid#1500669 silence Dereference after null check
    
    and
    
    cid#1500619 Dereference after null check
    
    help coverity out that there is only ConversionDirection_FROM_LEFT
    and ConversionDirection_FROM_RIGHT
    
    Change-Id: I47c4c2d1a0627a303b2f82c2905e6f67d0602b63
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138862
    Tested-by: Caolán McNamara <caol...@redhat.com>
    Reviewed-by: Caolán McNamara <caol...@redhat.com>

diff --git a/linguistic/source/convdic.cxx b/linguistic/source/convdic.cxx
index 057dfc41edbe..f204cfad0f45 100644
--- a/linguistic/source/convdic.cxx
+++ b/linguistic/source/convdic.cxx
@@ -370,7 +370,7 @@ uno::Sequence< OUString > SAL_CALL ConvDic::getConversions(
 {
     MutexGuard  aGuard( GetLinguMutex() );
 
-    if (!pFromRight && eDirection == ConversionDirection_FROM_RIGHT)
+    if (!pFromRight && eDirection != ConversionDirection_FROM_LEFT)
         return uno::Sequence< OUString >();
 
     if (bNeedEntries)
@@ -398,7 +398,7 @@ uno::Sequence< OUString > SAL_CALL 
ConvDic::getConversionEntries(
 {
     MutexGuard  aGuard( GetLinguMutex() );
 
-    if (!pFromRight && eDirection == ConversionDirection_FROM_RIGHT)
+    if (!pFromRight && eDirection != ConversionDirection_FROM_LEFT)
         return uno::Sequence< OUString >();
 
     if (bNeedEntries)