[Libreoffice-commits] core.git: include/xmloff sc/source xmloff/source

[Noel Grandin (via logerrit)]

 include/xmloff/xmlaustp.hxx       |    2 +-
 sc/source/filter/xml/xmlexprt.cxx |    2 +-
 xmloff/source/style/xmlaustp.cxx  |    2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

New commits:
commit c9c68f0ddb6625fd86a6e172e15d1c943bb81911
Author:     Noel Grandin <noel.gran...@collabora.co.uk>
AuthorDate: Wed Aug 31 11:31:25 2022 +0200
Commit:     Noel Grandin <noel.gran...@collabora.co.uk>
CommitDate: Thu Sep 1 10:35:19 2022 +0200

    cid#1500508 Using a moved object
    
    regression from
        commit f67392948d625db9ce115092e4c9bfd301268a25
        Author: Noel Grandin <noel.gran...@collabora.co.uk>
        Date:   Sun Oct 10 19:59:23 2021 +0200
        loplugin:moveparam in xmloff
    
    And change the AddNamed method otherwise the unnecessarycast
    loplugin will trigger.
    
    Change-Id: I58ded1379a6e5179f1065d68d7c2e9b812aa91ae
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139091
    Tested-by: Jenkins
    Reviewed-by: Noel Grandin <noel.gran...@collabora.co.uk>

diff --git a/include/xmloff/xmlaustp.hxx b/include/xmloff/xmlaustp.hxx
index 1adc3b786a91..11f6cfc46923 100644
--- a/include/xmloff/xmlaustp.hxx
+++ b/include/xmloff/xmlaustp.hxx
@@ -117,7 +117,7 @@ public:
 
     /// Add an item set with a pre-defined name (needed for saving sheets 
separately in Calc).
     bool        AddNamed( const OUString& rName, XmlStyleFamily nFamily, const 
OUString& rParent,
-                              std::vector< XMLPropertyState >&& rProperties );
+                              std::vector< XMLPropertyState > aProperties );
 
     /// Find an item set's name.
     OUString Find( XmlStyleFamily nFamily, const OUString& rParent, const 
::std::vector< XMLPropertyState >& rProperties ) const;
diff --git a/sc/source/filter/xml/xmlexprt.cxx 
b/sc/source/filter/xml/xmlexprt.cxx
index 475dfa6f6c94..ca7ff1cca804 100644
--- a/sc/source/filter/xml/xmlexprt.cxx
+++ b/sc/source/filter/xml/xmlexprt.cxx
@@ -2090,7 +2090,7 @@ void ScXMLExport::AddStyleFromCells(const 
uno::Reference<beans::XPropertySet>& x
                 if (itr != pFormatData->maIDToName.end())
                 {
                     sName = itr->second;
-                    bAdded = GetAutoStylePool()->AddNamed(sName, 
XmlStyleFamily::TABLE_CELL, sStyleName, std::move(aPropStates));
+                    bAdded = GetAutoStylePool()->AddNamed(sName, 
XmlStyleFamily::TABLE_CELL, sStyleName, aPropStates);
                     if (bAdded)
                         
GetAutoStylePool()->RegisterName(XmlStyleFamily::TABLE_CELL, sName);
                 }
diff --git a/xmloff/source/style/xmlaustp.cxx b/xmloff/source/style/xmlaustp.cxx
index 859477250ece..47a36932f028 100644
--- a/xmloff/source/style/xmlaustp.cxx
+++ b/xmloff/source/style/xmlaustp.cxx
@@ -353,7 +353,7 @@ bool SvXMLAutoStylePoolP::Add(OUString& rName, 
XmlStyleFamily nFamily, const OUS
 }
 
 bool SvXMLAutoStylePoolP::AddNamed( const OUString& rName, XmlStyleFamily 
nFamily, const OUString& rParent,
-                                    std::vector< XMLPropertyState >&& 
rProperties )
+                                    std::vector< XMLPropertyState > 
rProperties )
 
 {
     return pImpl->AddNamed(rName, nFamily, rParent, std::move(rProperties));