vcl/source/gdi/impglyphitem.cxx | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit ecb6ba6fb677a711afd515139cc7cf9cce771003
Author: Stephan Bergmann <sberg...@redhat.com>
AuthorDate: Thu Nov 10 19:06:01 2022 +0100
Commit: Stephan Bergmann <sberg...@redhat.com>
CommitDate: Fri Nov 11 12:34:34 2022 +0100
Drop useless std::move of const object
...introduced with 6c8dffc19e2a570d5665344dcba6afedd3dc2e15 "compute subset
of glyphs in SalLayoutGlyphsCache (tdf#139604)".
(I came across this code with an upcoming loplugin:constmove that flags
suspicious uses of std::move involving const-qualified types.)
Change-Id: Iaa356eb090cebabbed140906f0e0cee9a8039f42
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142567
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sberg...@redhat.com>
diff --git a/vcl/source/gdi/impglyphitem.cxx b/vcl/source/gdi/impglyphitem.cxx
index 526df693bf3c..4ca745f6063c 100644
--- a/vcl/source/gdi/impglyphitem.cxx
+++ b/vcl/source/gdi/impglyphitem.cxx
@@ -407,7 +407,7 @@ SalLayoutGlyphsCache::GetLayoutGlyphs(VclPtr<const
OutputDevice> outputDevice, c
= makeGlyphsSubset(itWhole->second, outputDevice, text,
nIndex, nLen);
if (mLastTemporaryGlyphs.IsValid())
{
- mLastTemporaryKey = std::move(key);
+ mLastTemporaryKey = key;
#ifdef DBG_UTIL
std::shared_ptr<const vcl::text::TextLayoutCache>
tmpLayoutCache;
if (layoutCache == nullptr)
