Hi Caolán,

thanks for pointing this out :)

Pushed it to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=da38cd454a7d32b92dbdd1dd0abdce27c4ee2327

I have some questions:

- what's the matter about sfx2/inc/sfx2/sfxcommands.h? A quick check did offer me that many of those defines are never used. Is it right to remove the unused ones?

- hrc files: There were some comments that number XY was removed, should I do this as well? I did this only at sw/source/ui/docvw/docvw.hrc because the numbers before and after were set.

- STR_DOC_LOADING and STR_CHAIN_OK were unused. They are represented in many po files. Is there an easier way to remove them or only per regex/sed?

Thomas

On 06/11/2012 05:26 PM, Caolán McNamara wrote:
On Sat, 2012-06-09 at 06:36 +0200, Thomas Arnhold wrote:
Hi,

these two methods don't do anything. So remove them and the calls
(core+binfilter).

Yeah, that seems to be the case alright.

This also suggests that you can remove SID_STATUSBARTEXT as well from
the appbas.cxx, sfxsids.hrc and sfx.sdi

C.



_______________________________________________
LibreOffice mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Reply via email to