[Libreoffice-commits] core.git: forms/source

[Caolán McNamara (via logerrit)]

 forms/source/xforms/model.cxx        |    2 +-
 forms/source/xforms/model_helper.hxx |    4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

New commits:
commit c6668bf7f87bb50ee5d795f17a67666018931b9a
Author:     Caolán McNamara <caol...@redhat.com>
AuthorDate: Thu Jan 19 09:03:01 2023 +0000
Commit:     Caolán McNamara <caol...@redhat.com>
CommitDate: Thu Jan 19 10:33:16 2023 +0000

    cid#1520418 Unchecked dynamic_cast
    
    and
    
    cid#1520419 Unchecked dynamic_cast
    cid#1520420 Unchecked dynamic_cast
    
    Change-Id: Ia5ef238677bd5eadcdb7fc3fcf982d8a1507133c
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145768
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caol...@redhat.com>

diff --git a/forms/source/xforms/model.cxx b/forms/source/xforms/model.cxx
index 0bab14a61cc8..0cab2350385e 100644
--- a/forms/source/xforms/model.cxx
+++ b/forms/source/xforms/model.cxx
@@ -428,7 +428,7 @@ void SAL_CALL Model::submitWithInteraction(
     {
         Submission* pSubmission =
             dynamic_cast<Submission*>( mxSubmissions->getItem( sID ).get() );
-        OSL_ENSURE( pSubmission != nullptr, "no submission?" );
+        assert(pSubmission && "no submission?");
         OSL_ENSURE( pSubmission->getModelImpl() == this,
                     "wrong model" );
 
diff --git a/forms/source/xforms/model_helper.hxx 
b/forms/source/xforms/model_helper.hxx
index 0ec03591bc0a..ae8d78da7c0d 100644
--- a/forms/source/xforms/model_helper.hxx
+++ b/forms/source/xforms/model_helper.hxx
@@ -91,14 +91,14 @@ protected:
     virtual void _insert( const T& t ) override
     {
         auto pSubmission = dynamic_cast<Submission*>( t.get() );
-        OSL_ENSURE( pSubmission != nullptr, "invalid item?" );
+        assert(pSubmission && "invalid item?");
         pSubmission->setModel( mpModel );
     }
 
     virtual void _remove( const T& t ) override
     {
         auto pSubmission = dynamic_cast<Submission*>( t.get() );
-        OSL_ENSURE( pSubmission != nullptr, "invalid item?" );
+        assert(pSubmission && "invalid item?");
         pSubmission->setModel( nullptr );
     }
 };