compilerplugins/clang/virtualdead.results | 22 +++++++--
compilerplugins/clang/virtualdead.unusedparams.results | 41 ++++++++++++-----
include/svx/svdobj.hxx | 2
svx/source/sdr/contact/viewobjectcontact.cxx | 3 -
svx/source/svdraw/svdobj.cxx | 2
sw/inc/dcontact.hxx | 2
sw/source/core/text/EnhancedPDFExportHelper.cxx | 2
7 files changed, 53 insertions(+), 21 deletions(-)
New commits:
commit 7ba513361df3cdde639f80757a299721023d46a1
Author: Noel Grandin <noel.gran...@collabora.co.uk>
AuthorDate: Mon Jan 30 14:48:38 2023 +0200
Commit: Noel Grandin <noel.gran...@collabora.co.uk>
CommitDate: Mon Jan 30 17:29:08 2023 +0000
loplugin:virtualdead
GetPDFAnchorStructureElementId was added in commit 6e5d59c2ca696, but
was unused even there
Change-Id: Id0624cac2854f5406ca93a4c495632fc3c1d0e74
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146354
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.gran...@collabora.co.uk>
diff --git a/compilerplugins/clang/virtualdead.results
b/compilerplugins/clang/virtualdead.results
index 1a7b0add3948..d3b3e8435745 100644
--- a/compilerplugins/clang/virtualdead.results
+++ b/compilerplugins/clang/virtualdead.results
@@ -31,7 +31,7 @@ include/basegfx/utils/unopolypolygon.hxx:93
include/connectivity/sdbcx/IRefreshable.hxx:29
void connectivity::sdbcx::IRefreshableGroups::refreshGroups()
empty
-include/filter/msfilter/msdffimp.hxx:545
+include/filter/msfilter/msdffimp.hxx:547
_Bool SvxMSDffManager::ShapeHasText(unsigned long,unsigned long,)const
1
include/svl/svdde.hxx:236
@@ -67,12 +67,12 @@ include/unotools/desktopterminationobserver.hxx:36
include/vbahelper/vbahelperinterface.hxx:75
int InheritedHelperInterfaceImpl::getCreator()
1400204879
-sc/source/core/opencl/formulagroupcl.cxx:1075
- void sc::opencl::(anonymous
namespace)::DynamicKernelSlidingArgument::GenSlidingWindowFunction(class
sc::opencl::outputstream &,)
- empty
-sc/source/core/opencl/opbase.hxx:212
+sc/source/core/opencl/opbase.hxx:333
_Bool sc::opencl::OpBase::takeNumeric()const
1
+sc/source/core/opencl/opbase.hxx:447
+ void
sc::opencl::DynamicKernelSlidingArgument::GenSlidingWindowFunction(class
sc::opencl::outputstream &,)
+ empty
sc/source/ui/vba/vbasheetobject.hxx:116
class rtl::OUString ScVbaSheetObjectBase::implGetBaseName()const
"Button"
@@ -82,15 +82,27 @@ sc/source/ui/vba/vbasheetobjects.cxx:145
slideshow/source/engine/animationfactory.cxx:617
void slideshow::internal::(anonymous
namespace)::GenericAnimation::prefetch()
empty
+unoxml/inc/node.hxx:137
+ _Bool DOM::CNode::IsChildTypeAllowed(const enum
com::sun::star::xml::dom::NodeType,const enum
com::sun::star::xml::dom::NodeType *const,)
+ 0
+vcl/inc/font/LogicalFontInstance.hxx:126
+ void LogicalFontInstance::ImplInitHbFont(struct hb_font_t *,)
+ empty
vcl/inc/qt5/QtFilePicker.hxx:182
void QtFilePicker::updateAutomaticFileExtension()
empty
+vcl/inc/salbmp.hxx:71
+ _Bool SalBitmap::Create(const class com::sun::star::uno::Reference<class
com::sun::star::rendering::XBitmapCanvas> &,class Size &,_Bool,)
+ 0
vcl/inc/salframe.hxx:145
void SalFrame::SetRepresentedURL(const class rtl::OUString &,)
empty
vcl/inc/salframe.hxx:204
_Bool SalFrame::MapUnicodeToKeyCode(char16_t,struct
o3tl::strong_int<unsigned short, struct LanguageTypeTag>,class vcl::KeyCode &,)
0
+vcl/inc/salgdiimpl.hxx:79
+ void SalGraphicsImpl::freeResources()
+ empty
vcl/inc/salinst.hxx:95
_Bool SalInstance::SVMainHook(int *,)
0
diff --git a/compilerplugins/clang/virtualdead.unusedparams.results
b/compilerplugins/clang/virtualdead.unusedparams.results
index df9931e68826..0fa4b4b31bd3 100644
--- a/compilerplugins/clang/virtualdead.unusedparams.results
+++ b/compilerplugins/clang/virtualdead.unusedparams.results
@@ -70,7 +70,7 @@ include/drawinglayer/primitive2d/textbreakuphelper.hxx:58
include/editeng/editeng.hxx:494
void EditEngine::ParagraphConnected(int,int,)
01
-include/filter/msfilter/msdffimp.hxx:545
+include/filter/msfilter/msdffimp.hxx:547
_Bool SvxMSDffManager::ShapeHasText(unsigned long,unsigned long,)const
00
include/oox/dump/dumperbase.hxx:473
@@ -112,6 +112,9 @@ include/svx/IAccessibleParent.hxx:81
include/svx/selectioncontroller.hxx:48
_Bool sdr::SelectionController::onMouseButtonUp(const class MouseEvent
&,class vcl::Window *,)
10
+include/svx/svdobj.hxx:133
+ int SdrObjUserCall::GetPDFAnchorStructureElementId(const class SdrObject
&,const class OutputDevice &,)
+ 10
include/vcl/accessibletable.hxx:90
class tools::Rectangle
vcl::table::IAccessibleTable::GetFieldCharacterBounds(int,int,int,)
001
@@ -139,9 +142,15 @@ sc/inc/filter.hxx:83
sc/inc/formulagroup.hxx:144
class boost::intrusive_ptr<class ScMatrix>
sc::FormulaGroupInterpreter::inverseMatrix(const class ScMatrix &,)
0
-sc/source/core/opencl/formulagroupcl.cxx:1075
- void sc::opencl::(anonymous
namespace)::DynamicKernelSlidingArgument::GenSlidingWindowFunction(class
sc::opencl::outputstream &,)
+sc/source/core/opencl/opbase.hxx:447
+ void
sc::opencl::DynamicKernelSlidingArgument::GenSlidingWindowFunction(class
sc::opencl::outputstream &,)
0
+sd/source/console/PresenterScrollBar.hxx:177
+ double sdext::presenter::PresenterScrollBar::GetDragDistance(const
int,const int,)const
+ 01
+sd/source/console/PresenterScrollBar.hxx:179
+ double sdext::presenter::PresenterScrollBar::GetMinor(const double,const
double,)const
+ 10
sdext/source/pdfimport/inc/contentsink.hxx:151
void pdfi::ContentSink::drawMask(const class
com::sun::star::uno::Sequence<struct com::sun::star::beans::PropertyValue>
&,_Bool,)
10
@@ -169,18 +178,15 @@ sdext/source/pdfimport/inc/treevisiting.hxx:52
sdext/source/pdfimport/inc/treevisiting.hxx:53
void pdfi::ElementTreeVisitor::visit(struct pdfi::DocumentElement &,const
class __gnu_debug::_Safe_iterator<struct
std::__cxx1998::_List_const_iterator<class std::unique_ptr<struct
pdfi::Element> >, class std::list<class std::unique_ptr<struct pdfi::Element>
>, struct std::bidirectional_iterator_tag> &,)
10
-sdext/source/presenter/PresenterScrollBar.hxx:177
- double sdext::presenter::PresenterScrollBar::GetDragDistance(const
int,const int,)const
- 01
-sdext/source/presenter/PresenterScrollBar.hxx:179
- double sdext::presenter::PresenterScrollBar::GetMinor(const double,const
double,)const
- 10
starmath/source/wordexportbase.hxx:28
void SmWordExportBase::HandleText(const class SmNode *,int,)
10
sw/inc/swcrsr.hxx:163
_Bool SwCursor::LeftRight(_Bool,unsigned short,enum
SwCursorSkipMode,_Bool,_Bool,_Bool,const class SwRootFrame *,_Bool,)
11000000
+sw/qa/inc/swmodeltestbase.hxx:158
+ void SwModelTestBase::postLoad(const char *,)
+ 0
sw/source/core/access/acccontext.hxx:349
_Bool SwAccessibleContext::SetSelectedState(_Bool,)
0
@@ -193,10 +199,25 @@ sw/source/filter/ww8/wrtww8.hxx:799
sw/source/filter/ww8/wrtww8.hxx:869
void MSWordExportBase::OutputGrfNode(const class SwGrfNode &,)
0
+unoxml/inc/node.hxx:137
+ _Bool DOM::CNode::IsChildTypeAllowed(const enum
com::sun::star::xml::dom::NodeType,const enum
com::sun::star::xml::dom::NodeType *const,)
+ 00
vcl/inc/font/fontsubstitution.hxx:53
_Bool vcl::font::GlyphFallbackFontSubstitution::FindFontSubstitute(class
vcl::font::FontSelectPattern &,class LogicalFontInstance *,class rtl::OUString
&,)const
101
-vcl/inc/salbmp.hxx:79
+vcl/inc/font/LogicalFontInstance.hxx:126
+ void LogicalFontInstance::ImplInitHbFont(struct hb_font_t *,)
+ 0
+vcl/inc/font/PhysicalFontFace.hxx:198
+ const class std::vector<struct hb_variation_t> &
vcl::font::PhysicalFontFace::GetVariations(const class LogicalFontInstance
&,)const
+ 0
+vcl/inc/salbmp.hxx:71
+ _Bool SalBitmap::Create(const class com::sun::star::uno::Reference<class
com::sun::star::rendering::XBitmapCanvas> &,class Size &,_Bool,)
+ 000
+vcl/inc/salbmp.hxx:80
+ _Bool SalBitmap::GetSystemData(struct BitmapSystemData &,)
+ 0
+vcl/inc/salbmp.hxx:86
_Bool SalBitmap::Replace(const class Color &,const class Color &,unsigned
char,)
000
vcl/inc/salframe.hxx:145
diff --git a/include/svx/svdobj.hxx b/include/svx/svdobj.hxx
index 3efddc78ac0d..6b779775bc3d 100644
--- a/include/svx/svdobj.hxx
+++ b/include/svx/svdobj.hxx
@@ -130,7 +130,7 @@ class SVXCORE_DLLPUBLIC SdrObjUserCall
public:
virtual ~SdrObjUserCall();
virtual void Changed(const SdrObject& rObj, SdrUserCallType eType, const
tools::Rectangle& rOldBoundRect);
- virtual sal_Int32 GetPDFAnchorStructureElementId(SdrObject const& rObj,
OutputDevice const&);
+ virtual sal_Int32 GetPDFAnchorStructureElementId(SdrObject const& rObj);
};
class SVXCORE_DLLPUBLIC SdrObjMacroHitRec
diff --git a/svx/source/sdr/contact/viewobjectcontact.cxx
b/svx/source/sdr/contact/viewobjectcontact.cxx
index 39421a9542e2..cae227438061 100644
--- a/svx/source/sdr/contact/viewobjectcontact.cxx
+++ b/svx/source/sdr/contact/viewobjectcontact.cxx
@@ -426,8 +426,7 @@ drawinglayer::primitive2d::Primitive2DContainer const &
ViewObjectContact::getPr
sal_Int32 nAnchorId(-1);
if (auto const pUserCall = pSdrObj->GetUserCall())
{
- nAnchorId = pUserCall->GetPDFAnchorStructureElementId(
- *pSdrObj,
*GetObjectContact().TryToGetOutputDevice());
+ nAnchorId =
pUserCall->GetPDFAnchorStructureElementId(*pSdrObj);
}
drawinglayer::primitive2d::Primitive2DReference xReference(
diff --git a/svx/source/svdraw/svdobj.cxx b/svx/source/svdraw/svdobj.cxx
index 4bcd7c386270..f23f9158e56c 100644
--- a/svx/source/svdraw/svdobj.cxx
+++ b/svx/source/svdraw/svdobj.cxx
@@ -136,7 +136,7 @@ void SdrObjUserCall::Changed(const SdrObject& /*rObj*/,
SdrUserCallType /*eType*
{
}
-sal_Int32 SdrObjUserCall::GetPDFAnchorStructureElementId(SdrObject const&,
OutputDevice const&)
+sal_Int32 SdrObjUserCall::GetPDFAnchorStructureElementId(SdrObject const&)
{
return -1;
}
diff --git a/sw/inc/dcontact.hxx b/sw/inc/dcontact.hxx
index c10d83c6dec5..20d99f4e7523 100644
--- a/sw/inc/dcontact.hxx
+++ b/sw/inc/dcontact.hxx
@@ -390,7 +390,7 @@ class SAL_DLLPUBLIC_RTTI SwDrawContact final : public
SwContact
/// Virtual methods of SdrObjUserCall.
virtual void Changed(const SdrObject& rObj, SdrUserCallType eType,
const tools::Rectangle& rOldBoundRect) override;
- virtual sal_Int32 GetPDFAnchorStructureElementId(SdrObject const&
rObj, OutputDevice const&) override;
+ virtual sal_Int32 GetPDFAnchorStructureElementId(SdrObject const&
rObj) override;
/** Used by Changed() and by UndoDraw.
Notifies paragraphs that have to get out of the way. */
diff --git a/sw/source/core/text/EnhancedPDFExportHelper.cxx
b/sw/source/core/text/EnhancedPDFExportHelper.cxx
index 42141b4013f9..c869413c3164 100644
--- a/sw/source/core/text/EnhancedPDFExportHelper.cxx
+++ b/sw/source/core/text/EnhancedPDFExportHelper.cxx
@@ -354,7 +354,7 @@ static auto GetReopenTagFromFrame(SwFrame const& rFrame) ->
sal_Int32
return -1;
}
-sal_Int32 SwDrawContact::GetPDFAnchorStructureElementId(SdrObject const& rObj,
OutputDevice const&)
+sal_Int32 SwDrawContact::GetPDFAnchorStructureElementId(SdrObject const& rObj)
{
SwFrame const*const pAnchorFrame(GetAnchoredObj(&rObj)->GetAnchorFrame());
return pAnchorFrame ? GetReopenTagFromFrame(*pAnchorFrame) : -1;
