vcl/source/app/salvtables.cxx |    7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

New commits:
commit 3191c67deefa13f8c664e0ea1ed27c218b1b6144
Author:     Noel Grandin <noel.gran...@collabora.co.uk>
AuthorDate: Fri Mar 10 11:02:13 2023 +0200
Commit:     Noel Grandin <noel.gran...@collabora.co.uk>
CommitDate: Fri Mar 10 15:44:04 2023 +0000

    tdf#153801 fix transparency in About dialog on gen/kf5
    
    This reverts
        commit 6d404f9ccad3ac6a7ffb83876ae7a656bc2d4547
        Author: Noel Grandin <noelgran...@gmail.com>
        Date:   Sun Feb 5 11:29:27 2023 +0100
        make create_virtual_device not use a separate alpha layer
    
    I made the change to make the
      SalInstanceWidget::create_virtual_device
    and
      GtkInstanceWidget::create_virtual_device
    the same, to make my life easier in landing the transparency->alpha
    patch.
    But that cannot work - the only reason the gtk path works is because gtk
    uses combined alpha (ie. 32-bit) but that requires gtk doing some lying
    and general fudging to the upper vcl layers because they don't know
    about combined alpha.
    
    Change-Id: If0e5046b05302a8f41b87846123685ed8f8e86f4
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148597
    Tested-by: Jenkins
    Reviewed-by: Noel Grandin <noel.gran...@collabora.co.uk>

diff --git a/vcl/source/app/salvtables.cxx b/vcl/source/app/salvtables.cxx
index 9bbd8e5bf05d..f9a6cfc75dc2 100644
--- a/vcl/source/app/salvtables.cxx
+++ b/vcl/source/app/salvtables.cxx
@@ -660,10 +660,9 @@ OUString SalInstanceWidget::strip_mnemonic(const OUString& 
rLabel) const
 
 VclPtr<VirtualDevice> SalInstanceWidget::create_virtual_device() const
 {
-    // create with no separate alpha layer like everything sane does
-    auto xRet = VclPtr<VirtualDevice>::Create();
-    xRet->SetBackground(COL_TRANSPARENT);
-    return xRet;
+    // create with (annoying) separate alpha layer that LibreOffice itself uses
+    return VclPtr<VirtualDevice>::Create(*Application::GetDefaultDevice(),
+                                         DeviceFormat::WITH_ALPHA);
 }
 
 void SalInstanceWidget::call_attention_to()

Reply via email to