include/test/sheet/xdatapilotdescriptor.hxx | 3 ++- test/source/sheet/xdatapilotdescriptor.cxx | 5 ++--- 2 files changed, 4 insertions(+), 4 deletions(-)
New commits: commit 758050caa06bd742dddea55fb29b0eec1b2309e4 Author: Stephan Bergmann <sberg...@redhat.com> AuthorDate: Thu Mar 9 23:05:20 2023 +0100 Commit: Stephan Bergmann <sberg...@redhat.com> CommitDate: Mon Mar 13 19:01:37 2023 +0000 Use a more reasonable type for XDataPilotDescriptor::checkName nIndex parameter Change-Id: If9e6760a6b23c63d03d337d6b111493684d67c85 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148568 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sberg...@redhat.com> diff --git a/include/test/sheet/xdatapilotdescriptor.hxx b/include/test/sheet/xdatapilotdescriptor.hxx index 9186b52ebb8f..5e4e7c62da87 100644 --- a/include/test/sheet/xdatapilotdescriptor.hxx +++ b/include/test/sheet/xdatapilotdescriptor.hxx @@ -16,6 +16,7 @@ #include <test/testdllapi.hxx> +#include <cstddef> #include <vector> namespace apitest { @@ -41,7 +42,7 @@ protected: private: static void testGetDataPilotFields_Impl( css::uno::Reference< css::sheet::XDataPilotDescriptor > const & xDescr ); - static void checkName( css::uno::Reference< css::container::XIndexAccess > const & xIndex, sal_Int32 nIndex ); + static void checkName( css::uno::Reference< css::container::XIndexAccess > const & xIndex, std::size_t nIndex ); static std::vector<OUString> maFieldNames; }; diff --git a/test/source/sheet/xdatapilotdescriptor.cxx b/test/source/sheet/xdatapilotdescriptor.cxx index a9cbcf5b125c..20392ff8ae4b 100644 --- a/test/source/sheet/xdatapilotdescriptor.cxx +++ b/test/source/sheet/xdatapilotdescriptor.cxx @@ -16,7 +16,6 @@ #include <cppunit/TestAssert.h> -#include <o3tl/safeint.hxx> #include <rtl/ustring.hxx> using namespace css; @@ -175,10 +174,10 @@ void XDataPilotDescriptor::testGetHiddenFields() checkName( xIndex, 3 ); } -void XDataPilotDescriptor::checkName( uno::Reference< container::XIndexAccess > const & xIndex, sal_Int32 nIndex ) +void XDataPilotDescriptor::checkName( uno::Reference< container::XIndexAccess > const & xIndex, std::size_t nIndex ) { CPPUNIT_ASSERT(xIndex.is()); - CPPUNIT_ASSERT(maFieldNames.size() >= o3tl::make_unsigned(nIndex)); + CPPUNIT_ASSERT(maFieldNames.size() >= nIndex); for (sal_Int32 i = 0; i < xIndex->getCount(); ++i) {