officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu |    3 ---
 1 file changed, 3 deletions(-)

New commits:
commit cc836756d35df4ab8f54a24bd495dd1b8e1c6be9
Author:     Justin Luth <jl...@mail.com>
AuthorDate: Thu Jun 29 18:02:57 2023 -0400
Commit:     Justin Luth <jl...@mail.com>
CommitDate: Fri Jun 30 15:20:41 2023 +0200

    tdf#118335 remove "Close Preview" PopupLabel from uno:PrintPreview
    
    The PopupLabel cannot be depended on to only be used
    when PrintPreview is already running.
    Specifically, in the notebookbar menus,
    it always said "Close Preview" even when
    the preview was not yet toggled on.
    
    Instead, use uno:ClosePreview in contexts
    that only show up when the preview is running.
    This has already been done in LO codebase.
    
    Change-Id: I3c743da895f9ac4febc18329f251d283c0cec1cf
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153779
    Tested-by: Jenkins
    Reviewed-by: Maxim Monastirsky <momonas...@gmail.com>
    Reviewed-by: Justin Luth <jl...@mail.com>

diff --git 
a/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu 
b/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
index a4fd28f8978d..b840300c29d9 100644
--- a/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
@@ -5880,9 +5880,6 @@ bit 3 (0x8): #define 
UICOMMANDDESCRIPTION_PROPERTIES_TOGGLEBUTTON 8
         <prop oor:name="TooltipLabel" oor:type="xs:string">
           <value xml:lang="en-US">Toggle Print Preview</value>
         </prop>
-        <prop oor:name="PopupLabel" oor:type="xs:string">
-          <value xml:lang="en-US">Close Preview</value>
-        </prop>
         <prop oor:name="Properties" oor:type="xs:int">
           <value>9</value>
         </prop>

Reply via email to