[Libreoffice-commits] core.git: sfx2/source

[Julien Nabet (via logerrit)]

 sfx2/source/doc/Metadatable.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 1eb683b6aff38d9b8226268f428600fa0d3ed58f
Author:     Julien Nabet <serval2...@yahoo.fr>
AuthorDate: Mon Aug 28 14:50:38 2023 +0200
Commit:     Julien Nabet <serval2...@yahoo.fr>
CommitDate: Mon Aug 28 16:54:30 2023 +0200

    incorrect usage of erase..remove idiom
    
    since commit 66a33ea9ef0ede9c90714455e6ad46197425f075
    Replace list by vector in Metadatable (sfx2)
    Change-Id: I707dd27be91711e4f80d39c620a3b9784b5ef122
    Reviewed-on: https://gerrit.libreoffice.org/43376
    Tested-by: Jenkins <c...@libreoffice.org>
    Reviewed-by: Julien Nabet <serval2...@yahoo.fr>
    Tested-by: Julien Nabet <serval2...@yahoo.fr>
    
    Change-Id: I9be82687cc9d7302e5d0ebc7bb52bac74540ce50
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156199
    Reviewed-by: Noel Grandin <noel.gran...@collabora.co.uk>
    Tested-by: Jenkins
    Reviewed-by: Julien Nabet <serval2...@yahoo.fr>

diff --git a/sfx2/source/doc/Metadatable.cxx b/sfx2/source/doc/Metadatable.cxx
index 8360c3634089..493491a9f7c4 100644
--- a/sfx2/source/doc/Metadatable.cxx
+++ b/sfx2/source/doc/Metadatable.cxx
@@ -488,7 +488,7 @@ rmIter(XmlIdMap_t & i_rXmlIdMap, XmlIdMap_t::iterator 
const& i_rIter,
     {
         XmlIdVector_t & rVector( isContentFile(i_rStream)
             ? i_rIter->second.first : i_rIter->second.second );
-        rVector.erase(std::remove(rVector.begin(), rVector.end(), 
&const_cast<Metadatable&>(i_rObject)));
+        rVector.erase(std::remove(rVector.begin(), rVector.end(), 
&const_cast<Metadatable&>(i_rObject)), rVector.end());
         if (i_rIter->second.first.empty() && i_rIter->second.second.empty())
         {
             i_rXmlIdMap.erase(i_rIter);