sc/qa/unit/functions_test.cxx | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
New commits:
commit 63582b234ddcca3bcb1f76843363e5e7d0b0a08e
Author: Eike Rathke <er...@redhat.com>
AuthorDate: Thu Aug 31 14:53:37 2023 +0200
Commit: Eike Rathke <er...@redhat.com>
CommitDate: Thu Aug 31 17:07:09 2023 +0200
Related: tdf#156985 Do not fail for first empty check cell in test failure
case
So we can actually find a detail if there are empty rows and not
just bail out with "Sheet2.A1 '' result: 0, expected: 0" or such.
Change-Id: I163f84edebfb98f6f0351ba3dc889d3fab0e6789
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156344
Reviewed-by: Eike Rathke <er...@redhat.com>
Tested-by: Jenkins
diff --git a/sc/qa/unit/functions_test.cxx b/sc/qa/unit/functions_test.cxx
index 8efdfa5b0f82..40504480d04d 100644
--- a/sc/qa/unit/functions_test.cxx
+++ b/sc/qa/unit/functions_test.cxx
@@ -40,8 +40,10 @@ bool FunctionsTest::load(const OUString& rFilter, const
OUString& rURL,
SCROW maxRow = rDoc.GetLastDataRow(tab, 2, 2, rDoc.MaxRow());
for(SCROW row = 0; row <= maxRow; ++row)
{
- // Column C has the check result, column D has the formula
text.
- if(rDoc.HasStringData(2, row, tab))
+ // Column A has the result value, column B has the expected
+ // value, Column C has the check result (1 or 0), column D has
+ // the formula text.
+ if(rDoc.HasStringData(2, row, tab) || !rDoc.HasData(2, row,
tab))
continue;
if(!rtl::math::approxEqual(1.0, rDoc.GetValue(2, row, 1)))
CPPUNIT_FAIL( OUString( "Testing " + rURL + " failed, "
