[Libreoffice-commits] core.git: sw/qa

[Miklos Vajna (via logerrit)]

 sw/qa/inc/swmodeltestbase.hxx  |    8 --------
 sw/qa/unit/swmodeltestbase.cxx |    4 ----
 2 files changed, 12 deletions(-)

New commits:
commit fa38d98155a857908641380c7a1a5a34fafe934e
Author:     Miklos Vajna <vmik...@collabora.com>
AuthorDate: Tue Dec 5 19:57:53 2023 +0100
Commit:     Miklos Vajna <vmik...@collabora.com>
CommitDate: Wed Dec 6 08:19:43 2023 +0100

    Remove now unused SwModelTestBase::preTest()
    
    Which was a way to place test setup code far from the test itself, so
    good to get rid of it.
    
    Change-Id: I9f88ded958e7b546f0b1ecd7ce025e72a2a5e245
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160373
    Tested-by: Jenkins
    Reviewed-by: Miklos Vajna <vmik...@collabora.com>

diff --git a/sw/qa/inc/swmodeltestbase.hxx b/sw/qa/inc/swmodeltestbase.hxx
index 7eb41f2eda7c..950136e66eba 100644
--- a/sw/qa/inc/swmodeltestbase.hxx
+++ b/sw/qa/inc/swmodeltestbase.hxx
@@ -140,14 +140,6 @@ protected:
         CPPUNIT_FAIL( "verify method must be overridden" );
     }
 
-    /**
-     * Override this function if some special filename-specific setup is needed
-     */
-    virtual std::unique_ptr<Resetter> preTest(const char* /*filename*/)
-    {
-        return nullptr;
-    }
-
     /// Override this function if some special file-specific setup is needed 
during export test: after load, but before save.
     virtual void postLoad(const char* /*pFilename*/)
     {
diff --git a/sw/qa/unit/swmodeltestbase.cxx b/sw/qa/unit/swmodeltestbase.cxx
index 5029421a631a..d5248bd414fb 100644
--- a/sw/qa/unit/swmodeltestbase.cxx
+++ b/sw/qa/unit/swmodeltestbase.cxx
@@ -66,7 +66,6 @@ void SwModelTestBase::executeImportTest(const char* filename, 
const char* pPassw
 {
     maTempFile.EnableKillingFile(false);
     header();
-    std::unique_ptr<Resetter> const pChanges(preTest(filename));
     loadURL(createFileURL(OUString::createFromAscii(filename)), pPassword);
     verify();
     finish();
@@ -77,7 +76,6 @@ void SwModelTestBase::executeLoadVerifyReloadVerify(const 
char* filename, const
 {
     maTempFile.EnableKillingFile(false);
     header();
-    std::unique_ptr<Resetter> const pChanges(preTest(filename));
     loadURL(createFileURL(OUString::createFromAscii(filename)), pPassword);
     verify();
     postLoad(filename);
@@ -91,7 +89,6 @@ void SwModelTestBase::executeLoadReloadVerify(const char* 
filename, const char*
 {
     maTempFile.EnableKillingFile(false);
     header();
-    std::unique_ptr<Resetter> const pChanges(preTest(filename));
     loadURL(createFileURL(OUString::createFromAscii(filename)), pPassword);
     postLoad(filename);
     saveAndReload(mpFilter, pPassword);
@@ -104,7 +101,6 @@ void SwModelTestBase::executeImportExport(const char* 
filename, const char* pPas
 {
     maTempFile.EnableKillingFile(false);
     header();
-    std::unique_ptr<Resetter> const pChanges(preTest(filename));
     loadAndSave(filename, pPassword);
     maTempFile.EnableKillingFile(false);
     verify();