[Libreoffice-commits] core.git: 2 commits - tsan-suppress.txt unotools/source

[Noel Grandin (via logerrit)]

 tsan-suppress.txt                     |    3 +++
 unotools/source/config/cmdoptions.cxx |    2 ++
 2 files changed, 5 insertions(+)

New commits:
commit c574def363c96aa38e8db4e8a03fa9ebcc41da7b
Author:     Noel Grandin <noel.gran...@collabora.co.uk>
AuthorDate: Wed Dec 6 14:24:20 2023 +0200
Commit:     Noel Grandin <noel.gran...@collabora.co.uk>
CommitDate: Wed Dec 6 20:27:49 2023 +0100

    update tsan suppressions
    
    Change-Id: Ib91f900e93c10225769ba92f4d0819a4084f5847
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160390
    Tested-by: Jenkins
    Reviewed-by: Noel Grandin <noel.gran...@collabora.co.uk>

diff --git a/tsan-suppress.txt b/tsan-suppress.txt
index 2c431f4da22d..e72f33ba5d13 100644
--- a/tsan-suppress.txt
+++ b/tsan-suppress.txt
@@ -17,6 +17,9 @@ deadlock:AffineBridge::v_callInto_v
 # Ignore stuff in external DBUS library.
 # Some kind of dbus lock issue when we call it from psp::CUPSManager.
 deadlock:_dbus_lock
+race:g_dbus_connection_signal_unsubscribe
+race:g_path_get_basename
+race:g_date_time_format_iso8601
 
 # inside an assert so I don't care.
 race:cppu::OWeakConnectionPoint::acquire
commit de9667d419bae2c03adf9a9c08b20cd519137cba
Author:     Noel Grandin <noel.gran...@collabora.co.uk>
AuthorDate: Wed Dec 6 15:03:55 2023 +0200
Commit:     Noel Grandin <noel.gran...@collabora.co.uk>
CommitDate: Wed Dec 6 20:27:35 2023 +0100

    tdf#157915 Error when running a Basic macro with instruction commitChanges
    
    regression from
        commit 1576ef8532cf2cea2da361db9c5707f1994e65e2
        Author: Noel Grandin <noelgran...@gmail.com>
        Date:   Thu Dec 23 18:40:44 2021 +0200
        osl::Mutex->std::mutex in SvtCommandOptions
    
    Note that this only fixes part of the issue - specifically the part that
    the original reporter described.
    
    There is a further issue, not fixed here, which only happens on
    Linux/GTK, where the messagebox dialog manages to end up behind the
    About dialog, and consequently cannot be closed, which freezes the
    program.
    
    Change-Id: Idbb7f51e494a69886c80eb92efaa7cf7c6911c16
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160393
    Tested-by: Jenkins
    Reviewed-by: Noel Grandin <noel.gran...@collabora.co.uk>

diff --git a/unotools/source/config/cmdoptions.cxx 
b/unotools/source/config/cmdoptions.cxx
index ec4e826b8c8a..015637d644a2 100644
--- a/unotools/source/config/cmdoptions.cxx
+++ b/unotools/source/config/cmdoptions.cxx
@@ -222,7 +222,9 @@ void SvtCommandOptions_Impl::Notify( const Sequence< 
OUString >& )
         css::uno::Reference< css::frame::XFrame > xFrame(pIt->get(), 
css::uno::UNO_QUERY);
         if (xFrame.is())
         {
+            aGuard.unlock(); // because we can call back into ourself
             xFrame->contextChanged();
+            aGuard.lock();
             ++pIt;
         }
         else