scaddins/source/analysis/analysishelper.cxx | 2 +- scaddins/source/datefunc/datefunc.cxx | 2 +- scaddins/source/pricing/pricing.cxx | 2 +- sd/source/ui/view/drviews2.cxx | 18 +++++++++--------- 4 files changed, 12 insertions(+), 12 deletions(-)
New commits: commit a1b7ae437c9e37cb1fe3063906609b60dc7e7f13 Author: Julien Nabet <[email protected]> AuthorDate: Tue Dec 26 18:42:03 2023 +0100 Commit: Julien Nabet <[email protected]> CommitDate: Tue Dec 26 21:31:11 2023 +0100 Use emplace_back instead of push_back (sd) Change-Id: I5641a98f26a19efabb3a5eee25e48282d44faca4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161332 Tested-by: Jenkins Reviewed-by: Julien Nabet <[email protected]> diff --git a/sd/source/ui/view/drviews2.cxx b/sd/source/ui/view/drviews2.cxx index 54b16db4b1e7..8358e95cf8a9 100644 --- a/sd/source/ui/view/drviews2.cxx +++ b/sd/source/ui/view/drviews2.cxx @@ -277,7 +277,7 @@ private: // Get Weight of current paragraph OUString sWeightProperty = getWeightString(rEditText.GetParaAttribs(nCurrentParagraph)); // Insert new paragraph into collection - m_aResults.push_back({ svx::ClassificationType::PARAGRAPH, sWeightProperty, sBlank, sBlank }); + m_aResults.emplace_back(svx::ClassificationType::PARAGRAPH, sWeightProperty, sBlank, sBlank); } const SvxFieldItem* pFieldItem = findField(rSection); @@ -289,27 +289,27 @@ private: const OUString& aKey = pCustomPropertyField->GetName(); if (m_aKeyCreator.isMarkingTextKey(aKey)) { - m_aResults.push_back({ svx::ClassificationType::TEXT, + m_aResults.emplace_back(svx::ClassificationType::TEXT, svx::classification::getProperty(m_xPropertyContainer, aKey), - sBlank, sBlank }); + sBlank, sBlank); } else if (m_aKeyCreator.isCategoryNameKey(aKey) || m_aKeyCreator.isCategoryIdentifierKey(aKey)) { - m_aResults.push_back({ svx::ClassificationType::CATEGORY, + m_aResults.emplace_back(svx::ClassificationType::CATEGORY, svx::classification::getProperty(m_xPropertyContainer, aKey), - sBlank, sBlank }); + sBlank, sBlank); } else if (m_aKeyCreator.isMarkingKey(aKey)) { - m_aResults.push_back({ svx::ClassificationType::MARKING, + m_aResults.emplace_back(svx::ClassificationType::MARKING, svx::classification::getProperty(m_xPropertyContainer, aKey), - sBlank, sBlank }); + sBlank, sBlank); } else if (m_aKeyCreator.isIntellectualPropertyPartKey(aKey)) { - m_aResults.push_back({ svx::ClassificationType::INTELLECTUAL_PROPERTY_PART, + m_aResults.emplace_back(svx::ClassificationType::INTELLECTUAL_PROPERTY_PART, svx::classification::getProperty(m_xPropertyContainer, aKey), - sBlank, sBlank }); + sBlank, sBlank); } } } commit 79a26ca7e5cb8ae3b78915b1389f03293b710000 Author: Julien Nabet <[email protected]> AuthorDate: Tue Dec 26 18:46:44 2023 +0100 Commit: Julien Nabet <[email protected]> CommitDate: Tue Dec 26 21:31:01 2023 +0100 Use emplace_back instead of push_back (scaddins) Change-Id: I08b22351a3e75d5accbb3e59890f5e04b8fbb6d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161333 Tested-by: Jenkins Reviewed-by: Julien Nabet <[email protected]> diff --git a/scaddins/source/analysis/analysishelper.cxx b/scaddins/source/analysis/analysishelper.cxx index dfd41f953d29..974dcadc7c98 100644 --- a/scaddins/source/analysis/analysishelper.cxx +++ b/scaddins/source/analysis/analysishelper.cxx @@ -1368,7 +1368,7 @@ sal_uInt16 FuncData::GetStrIndex( sal_uInt16 nParamNum ) const void InitFuncDataList(FuncDataList& rList) { for(const auto & rFuncData : pFuncDatas) - rList.push_back(FuncData(rFuncData)); + rList.emplace_back(rFuncData); } SortedIndividualInt32List::SortedIndividualInt32List() diff --git a/scaddins/source/datefunc/datefunc.cxx b/scaddins/source/datefunc/datefunc.cxx index 9b59adcb5dde..c8839662d04e 100644 --- a/scaddins/source/datefunc/datefunc.cxx +++ b/scaddins/source/datefunc/datefunc.cxx @@ -82,7 +82,7 @@ sal_uInt16 ScaFuncData::GetStrIndex( sal_uInt16 nParam ) const static void InitScaFuncDataList(ScaFuncDataList& rList) { for (const auto & nIndex : pFuncDataArr) - rList.push_back(ScaFuncData(nIndex)); + rList.emplace_back(nIndex); } // entry points for service registration / instantiation diff --git a/scaddins/source/pricing/pricing.cxx b/scaddins/source/pricing/pricing.cxx index 3182024abe35..161f15f55c4a 100644 --- a/scaddins/source/pricing/pricing.cxx +++ b/scaddins/source/pricing/pricing.cxx @@ -75,7 +75,7 @@ sal_uInt16 ScaFuncData::GetStrIndex( sal_uInt16 nParam ) const void sca::pricing::InitScaFuncDataList(ScaFuncDataList& rList) { for (const auto & nIndex : pFuncDataArr) - rList.push_back(ScaFuncData(nIndex)); + rList.emplace_back(nIndex); } // entry points for service registration / instantiation
