sw/source/uibase/utlui/content.cxx |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

New commits:
commit 4c8c57d542a7c9becef166d3fefdf5320500a012
Author:     Jim Raykowski <rayk...@gmail.com>
AuthorDate: Sun Jan 14 14:10:21 2024 -0900
Commit:     Jim Raykowski <rayk...@gmail.com>
CommitDate: Tue Jan 16 19:56:09 2024 +0100

    SwNavigator: remove useless code
    
    The comment states:
    
    -> the user data here are no longer valid!
    
    meaning sOldSelEntryId = m_xTreeView->get_id(*xOldSelEntry) isn't
    valid here.
    
    Change-Id: Ie5591a93a96eefb97b7563af69753f4a105696eb
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162068
    Tested-by: Jenkins
    Reviewed-by: Jim Raykowski <rayk...@gmail.com>

diff --git a/sw/source/uibase/utlui/content.cxx 
b/sw/source/uibase/utlui/content.cxx
index 831642462675..2f0bdc06f739 100644
--- a/sw/source/uibase/utlui/content.cxx
+++ b/sw/source/uibase/utlui/content.cxx
@@ -2850,14 +2850,12 @@ void SwContentTree::Display( bool bActive )
     std::unique_ptr<weld::TreeIter> xOldSelEntry(m_xTreeView->make_iterator());
     if (!m_xTreeView->get_selected(xOldSelEntry.get()))
         xOldSelEntry.reset();
-    OUString sOldSelEntryId;
     size_t nEntryRelPos = 0; // relative position to their parent
     size_t nOldEntryCount = GetEntryCount();
     sal_Int32 nOldScrollPos = 0;
     if (xOldSelEntry)
     {
         UpdateLastSelType();
-        sOldSelEntryId = m_xTreeView->get_id(*xOldSelEntry);
         nOldScrollPos = m_xTreeView->vadjustment_get_value();
         std::unique_ptr<weld::TreeIter> xParentEntry = 
m_xTreeView->make_iterator(xOldSelEntry.get());
         while (m_xTreeView->get_iter_depth(*xParentEntry))
@@ -3004,7 +3002,7 @@ void SwContentTree::Display( bool bActive )
                 bool bNext;
                 while ((bNext = m_xTreeView->iter_next(*xIter) && 
lcl_IsContent(*xIter, *m_xTreeView)))
                 {
-                    if (m_xTreeView->get_id(*xIter) == sOldSelEntryId || nPos 
== nEntryRelPos)
+                    if (nPos == nEntryRelPos)
                     {
                         m_xTreeView->copy_iterator(*xIter, *xSelEntry);
                         break;

Reply via email to