core.git: sfx2/source

[Noel Grandin (via logerrit)]

 sfx2/source/control/request.cxx |    1 -
 1 file changed, 1 deletion(-)

New commits:
commit 8d76c5bc29b8ed4cb616bed845acc30b96a38c77
Author:     Noel Grandin <noelgran...@gmail.com>
AuthorDate: Tue Mar 12 21:23:39 2024 +0200
Commit:     Noel Grandin <noel.gran...@collabora.co.uk>
CommitDate: Wed Mar 13 08:15:06 2024 +0100

    remove DBG_ASSERT
    
    this is testing the wrong thing anyway. I briefly converted it
    to a real assert, but surprise surprise, real code appears to
    now rely on being able to set this more than once, so just remove
    it.
    
    Change-Id: Ib272b002e3038eb8537df4768d980b3c3cf938fd
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164726
    Tested-by: Jenkins
    Reviewed-by: Noel Grandin <noel.gran...@collabora.co.uk>

diff --git a/sfx2/source/control/request.cxx b/sfx2/source/control/request.cxx
index f6b7645fef13..9406ce8b9fd3 100644
--- a/sfx2/source/control/request.cxx
+++ b/sfx2/source/control/request.cxx
@@ -418,7 +418,6 @@ void SfxRequest::RemoveItem( sal_uInt16 nID )
 
 void SfxRequest::SetReturnValue(const SfxPoolItem &rItem)
 {
-    DBG_ASSERT(!pImpl, "Set Return value multiple times?");
     DBG_ASSERT(nullptr != pImpl->pPool, "Missing SfxItemPool (!)");
     if (nullptr != pImpl->pPool)
         pImpl->aRetVal = SfxPoolItemHolder(*pImpl->pPool, &rItem);