svx/uiconfig/ui/accessibilitycheckentry.ui | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
New commits:
commit 31b3d5a1062366a7ab0cf0fa42359b90d1ed3c4b
Author: Tomaž Vajngerl <tomaz.vajng...@collabora.co.uk>
AuthorDate: Wed May 8 17:58:00 2024 +0900
Commit: Tomaž Vajngerl <qui...@gmail.com>
CommitDate: Thu May 9 10:28:52 2024 +0200
svx: a11y check entry box - provide accessible name and description
If the accessible name and description is not set in the .ui file,
the code will look into help for accessible description, which will
always return an empty string as the widgets are added dynamically.
Searching in help takes some time (2ms), which can add up and is
"felt" in accessibility check sidebar in online when the documents
has a lot of accessibility issues (it can add up to seconds). To
avoid this cost and for better accessibility info, it is better
to provide some general description for this widgets.
Change-Id: I91c5a091781532068c517be937d225fc9345dc5c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167346
Reviewed-by: Tomaž Vajngerl <qui...@gmail.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoff...@gmail.com>
Reviewed-by: Szymon Kłos <szymon.k...@collabora.com>
diff --git a/svx/uiconfig/ui/accessibilitycheckentry.ui
b/svx/uiconfig/ui/accessibilitycheckentry.ui
index f5b79bd9a203..a565b4089fcf 100644
--- a/svx/uiconfig/ui/accessibilitycheckentry.ui
+++ b/svx/uiconfig/ui/accessibilitycheckentry.ui
@@ -21,6 +21,8 @@
<property name="xalign">0</property>
<child internal-child="accessible">
<object class="AtkObject"
id="accessibilityCheckEntryLabel-atkobject">
+ <property name="AtkObject::accessible-name" translatable="yes"
context="accessibilitycheckentry|accessibilityCheckEntryLabel - Acessible
Name">Document accessibility issue text label</property>
+ <property name="AtkObject::accessible-description"
translatable="yes"
context="accessibilitycheckentry|accessibilityCheckEntryLabel - Acessible
Description">This is a document accessibility issue text label, which describes
the issue.</property>
<property name="AtkObject::accessible-role">static</property>
</object>
</child>
@@ -38,6 +40,12 @@
<property name="hexpand">True</property>
<property name="relief">none</property>
<property name="xalign">0</property>
+ <child internal-child="accessible">
+ <object class="AtkObject"
id="accessibilityCheckEntryLinkButton-atkobject">
+ <property name="AtkObject::accessible-name" translatable="yes"
context="accessibilitycheckentry|accessibilityCheckEntryLinkButton - Acessible
Name">Document accessibility issue text link button</property>
+ <property name="AtkObject::accessible-description"
translatable="yes"
context="accessibilitycheckentry|accessibilityCheckEntryLinkButton - Acessible
Description">This is a document accessibility issue link button, which
describes the issue and provides a link, which will jump to the place of the
issue in the document when clicked.</property>
+ </object>
+ </child>
</object>
<packing>
<property name="left-attach">1</property>
@@ -52,11 +60,23 @@
<property name="receives-default">True</property>
<property name="halign">end</property>
<property name="valign">center</property>
+ <child internal-child="accessible">
+ <object class="AtkObject"
id="accessibilityCheckEntryFixButton-atkobject">
+ <property name="AtkObject::accessible-name" translatable="yes"
context="accessibilitycheckentry|accessibilityCheckEntryFixButton - Acessible
Name">Document accessibility issue fix button</property>
+ <property name="AtkObject::accessible-description"
translatable="yes"
context="accessibilitycheckentry|accessibilityCheckEntryFixButton - Acessible
Description">This is a document accessibility issue fix button, which will
provide a way to fix the issue if clicked.</property>
+ </object>
+ </child>
</object>
<packing>
<property name="left-attach">2</property>
<property name="top-attach">0</property>
</packing>
</child>
+ <child internal-child="accessible">
+ <object class="AtkObject" id="accessibilityCheckEntryBox-atkobject">
+ <property name="AtkObject::accessible-name" translatable="yes"
context="accessibilitycheckentry|accessibilityCheckEntryBox - Acessible
Name">Document accessibility issue container</property>
+ <property name="AtkObject::accessible-description" translatable="yes"
context="accessibilitycheckentry|accessibilityCheckEntryBox - Acessible
Description">This is a document accessibility issue container, which describes
an document accessibility issue and potentially provides a solution how to fix
the issue.</property>
+ </object>
+ </child>
</object>
</interface>
