sc/source/filter/excel/xistream.cxx | 2 +- sd/source/ui/func/fuoaprms.cxx | 2 +- slideshow/source/engine/transitions/sweepwipe.cxx | 4 +++- 3 files changed, 5 insertions(+), 3 deletions(-)
New commits: commit d7a20237bd62821e45849fb2d5f90b20148035a8 Author: Caolán McNamara <[email protected]> AuthorDate: Sat Aug 17 14:35:58 2024 +0100 Commit: Caolán McNamara <[email protected]> CommitDate: Mon Aug 19 15:15:20 2024 +0200 cid#1558041 silence COPY_INSTEAD_OF_MOVE Change-Id: I176158eb311fa1ae61ba39fd1d810b9faacef1f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172025 Tested-by: Jenkins Reviewed-by: Caolán McNamara <[email protected]> diff --git a/slideshow/source/engine/transitions/sweepwipe.cxx b/slideshow/source/engine/transitions/sweepwipe.cxx index e6fcb8c2d028..8fcce26fdeb6 100644 --- a/slideshow/source/engine/transitions/sweepwipe.cxx +++ b/slideshow/source/engine/transitions/sweepwipe.cxx @@ -64,7 +64,9 @@ namespace slideshow::internal { res.append(poly); } - return m_flipOnYAxis ? flipOnYAxis(res) : res; + if (m_flipOnYAxis) + return flipOnYAxis(res); + return res; } } commit 8a86dfaf59822605fce1e856672100c28a399500 Author: Caolán McNamara <[email protected]> AuthorDate: Sat Aug 17 15:04:20 2024 +0100 Commit: Caolán McNamara <[email protected]> CommitDate: Mon Aug 19 15:15:13 2024 +0200 cid#1607580 silence Overflowed constant Change-Id: I61c1728293347aec967a95cdf7a9f40aa52b7aa3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172024 Tested-by: Jenkins Reviewed-by: Caolán McNamara <[email protected]> diff --git a/sc/source/filter/excel/xistream.cxx b/sc/source/filter/excel/xistream.cxx index 16eea86e7cd8..c4aa3c2b502f 100644 --- a/sc/source/filter/excel/xistream.cxx +++ b/sc/source/filter/excel/xistream.cxx @@ -459,7 +459,7 @@ bool XclImpStream::StartNextRecord() /* #i4266# Counter to ignore zero records (id==len==0) (i.e. the application "Crystal Report" writes zero records between other records) */ - std::size_t nZeroRecCount = 5; + int nZeroRecCount = 5; bool bIsZeroRec = false; do commit a971a176b476eae49784261e6b6e46f3210e43af Author: Caolán McNamara <[email protected]> AuthorDate: Sun Aug 18 21:17:21 2024 +0100 Commit: Caolán McNamara <[email protected]> CommitDate: Mon Aug 19 15:15:06 2024 +0200 cid#1616524 COPY_INSTEAD_OF_MOVE Change-Id: Idb3775f795056ec848b01b666cc258604eda7588 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172023 Tested-by: Caolán McNamara <[email protected]> Reviewed-by: Caolán McNamara <[email protected]> diff --git a/sd/source/ui/func/fuoaprms.cxx b/sd/source/ui/func/fuoaprms.cxx index 95ddea361627..d6f356d257f3 100644 --- a/sd/source/ui/func/fuoaprms.cxx +++ b/sd/source/ui/func/fuoaprms.cxx @@ -448,7 +448,7 @@ void FuObjectAnimationParameters::DoExecute( SfxRequest& rReq ) SdAbstractDialogFactory* pFact = SdAbstractDialogFactory::Create(); VclPtr<SfxAbstractDialog> pDlg( pFact->CreatSdActionDialog(mpViewShell->GetFrameWeld(), *aSet, mpView) ); rtl::Reference<FuObjectAnimationParameters> xThis( this ); // avoid destruction within async processing - pDlg->StartExecuteAsync([pDlg, xThis, xRequest=std::move(xRequest), aSet](sal_Int32 nResult){ + pDlg->StartExecuteAsync([pDlg, xThis, xRequest=std::move(xRequest), aSet=std::move(aSet)](sal_Int32 nResult){ if (nResult == RET_OK) { xThis->Finish(xRequest, pDlg); }
