core.git: Branch 'libreoffice-24-8' - svx/source

[Mike Kaganski (via logerrit)]

 svx/source/svdraw/svdview.cxx |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 294ebaea6bfc7e298765ca7b053068d6293fc86d
Author:     Mike Kaganski <mike.kagan...@collabora.com>
AuthorDate: Mon Oct 14 15:51:31 2024 +0200
Commit:     Xisco Fauli <xiscofa...@libreoffice.org>
CommitDate: Tue Oct 15 09:31:19 2024 +0200

    Dereference before nullptr check
    
    After commit 2c8c436c4a8546276e285dd18f3f7ded091a2c4e (tdf#152992:
    for Impress/Draw add horizontal hit tolerance for quick text edit,
    2023-07-21).
    
    Change-Id: Ia19bca115f95c53851dc63cdc7e4336f0289d731
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174793
    Tested-by: Jenkins
    Reviewed-by: Mike Kaganski <mike.kagan...@collabora.com>
    (cherry picked from commit c5703bbeebc6b4976dbf7cafb2e0bfda6345f864)
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174800
    Reviewed-by: Xisco Fauli <xiscofa...@libreoffice.org>

diff --git a/svx/source/svdraw/svdview.cxx b/svx/source/svdraw/svdview.cxx
index 36e7fce43950..6e7e5c5a33e5 100644
--- a/svx/source/svdraw/svdview.cxx
+++ b/svx/source/svdraw/svdview.cxx
@@ -514,8 +514,8 @@ SdrHitKind SdrView::PickAnything(const Point& rLogicPos, 
SdrViewEvent& rVEvt) co
 
         // Around the TextEditArea there's a border to select without going 
into text edit mode.
         tools::Rectangle aBoundRect;
-        const GeoStat& rGeo = pTextObj->GetGeoStat();
-        if (pTextObj && !rGeo.m_nRotationAngle && !rGeo.m_nShearAngle)
+        if (pTextObj && !pTextObj->GetGeoStat().m_nRotationAngle
+            && !pTextObj->GetGeoStat().m_nShearAngle)
         {
             pTextObj->TakeTextEditArea(nullptr, nullptr, &aBoundRect, nullptr);
         }