avmedia/source/framework/mediaitem.cxx | 2 +- basctl/source/basicide/baside2.hxx | 4 ++-- basctl/source/inc/BasicColorConfig.hxx | 2 +- canvas/inc/parametricpolypolygon.hxx | 2 +- canvas/source/tools/parametricpolypolygon.cxx | 2 +- chart2/source/controller/dialogs/ChartResourceGroups.cxx | 4 ++-- chart2/source/controller/dialogs/DataBrowser.cxx | 4 ++-- chart2/source/controller/dialogs/DataBrowser.hxx | 2 +- chart2/source/controller/dialogs/DataBrowserModel.cxx | 4 ++-- chart2/source/inc/ChartResourceGroups.hxx | 4 ++-- chart2/source/inc/DataBrowserModel.hxx | 2 +- chart2/source/inc/chartview/DrawModelWrapper.hxx | 2 +- chart2/source/view/axes/VAxisBase.hxx | 2 +- chart2/source/view/main/DrawModelWrapper.cxx | 2 +- connectivity/source/commontools/sqlerror.cxx | 4 ++-- connectivity/source/drivers/mozab/bootstrap/MNSFolders.cxx | 4 ++-- connectivity/source/drivers/mozab/bootstrap/MNSFolders.hxx | 2 +- connectivity/source/drivers/odbc/ODatabaseMetaDataResultSet.cxx | 4 ++-- connectivity/source/inc/odbc/ODatabaseMetaDataResultSet.hxx | 2 +- include/avmedia/mediaitem.hxx | 2 +- 20 files changed, 28 insertions(+), 28 deletions(-)
New commits: commit 6e1207c9def3af1b979b57c3d19c51a2c33ecf2d Author: Noel Grandin <[email protected]> AuthorDate: Thu Nov 7 08:17:33 2024 +0200 Commit: Noel Grandin <[email protected]> CommitDate: Thu Nov 7 10:03:52 2024 +0100 loplugin:passstuffbyref in chart2..connectivity Change-Id: Ic2c6606ea0ce1d5c3089bc4c1a879fed3f2c7aff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176180 Tested-by: Jenkins Reviewed-by: Noel Grandin <[email protected]> diff --git a/chart2/source/controller/dialogs/ChartResourceGroups.cxx b/chart2/source/controller/dialogs/ChartResourceGroups.cxx index a684b481c07d..1e43eb481a36 100644 --- a/chart2/source/controller/dialogs/ChartResourceGroups.cxx +++ b/chart2/source/controller/dialogs/ChartResourceGroups.cxx @@ -205,7 +205,7 @@ SplineResourceGroup::SplineResourceGroup(weld::Builder* pBuilder, weld::Window* m_xLB_LineType->connect_changed(LINK(this, SplineResourceGroup, LineTypeChangeHdl)); } -std::shared_ptr<SplinePropertiesDialog> SplineResourceGroup::getSplinePropertiesDialog() +const std::shared_ptr<SplinePropertiesDialog>& SplineResourceGroup::getSplinePropertiesDialog() { if (!m_xSplinePropertiesDialog) { @@ -214,7 +214,7 @@ std::shared_ptr<SplinePropertiesDialog> SplineResourceGroup::getSplineProperties return m_xSplinePropertiesDialog; } -std::shared_ptr<SteppedPropertiesDialog> SplineResourceGroup::getSteppedPropertiesDialog() +const std::shared_ptr<SteppedPropertiesDialog>& SplineResourceGroup::getSteppedPropertiesDialog() { if (!m_xSteppedPropertiesDialog) { diff --git a/chart2/source/controller/dialogs/DataBrowser.cxx b/chart2/source/controller/dialogs/DataBrowser.cxx index b80dcf2043e0..c7b751c944c9 100644 --- a/chart2/source/controller/dialogs/DataBrowser.cxx +++ b/chart2/source/controller/dialogs/DataBrowser.cxx @@ -663,12 +663,12 @@ void DataBrowser::RenewTable() Invalidate(); } -OUString DataBrowser::GetColString( sal_Int32 nColumnId ) const +const OUString & DataBrowser::GetColString( sal_Int32 nColumnId ) const { OSL_ASSERT(m_apDataBrowserModel); if( nColumnId > 0 ) return m_apDataBrowserModel->getRoleOfColumn( nColumnId - 1 ); - return OUString(); + return EMPTY_OUSTRING; } OUString DataBrowser::GetCellText( sal_Int32 nRow, sal_uInt16 nColumnId ) const diff --git a/chart2/source/controller/dialogs/DataBrowser.hxx b/chart2/source/controller/dialogs/DataBrowser.hxx index c1d6a72e6cf8..46c62ba63e3c 100644 --- a/chart2/source/controller/dialogs/DataBrowser.hxx +++ b/chart2/source/controller/dialogs/DataBrowser.hxx @@ -174,7 +174,7 @@ private: void RenewTable(); void ImplAdjustHeaderControls(); - OUString GetColString( sal_Int32 nColumnId ) const; + const OUString & GetColString( sal_Int32 nColumnId ) const; DECL_LINK( SeriesHeaderGotFocus, impl::SeriesHeaderEdit&, void ); DECL_LINK( SeriesHeaderChanged, impl::SeriesHeaderEdit&, void ); diff --git a/chart2/source/controller/dialogs/DataBrowserModel.cxx b/chart2/source/controller/dialogs/DataBrowserModel.cxx index 9f01c68f61fc..1f04f29ae69f 100644 --- a/chart2/source/controller/dialogs/DataBrowserModel.cxx +++ b/chart2/source/controller/dialogs/DataBrowserModel.cxx @@ -708,12 +708,12 @@ sal_Int32 DataBrowserModel::getMaxRowCount() const return nResult; } -OUString DataBrowserModel::getRoleOfColumn( sal_Int32 nColumnIndex ) const +const OUString & DataBrowserModel::getRoleOfColumn( sal_Int32 nColumnIndex ) const { if( nColumnIndex != -1 && o3tl::make_unsigned( nColumnIndex ) < m_aColumns.size()) return m_aColumns[ nColumnIndex ].m_aUIRoleName; - return OUString(); + return EMPTY_OUSTRING; } bool DataBrowserModel::isCategoriesColumn( sal_Int32 nColumnIndex ) const diff --git a/chart2/source/inc/ChartResourceGroups.hxx b/chart2/source/inc/ChartResourceGroups.hxx index ecb886f194af..9b6d5ee267f7 100644 --- a/chart2/source/inc/ChartResourceGroups.hxx +++ b/chart2/source/inc/ChartResourceGroups.hxx @@ -112,8 +112,8 @@ private: DECL_LINK(LineTypeChangeHdl, weld::ComboBox&, void); DECL_LINK(SplineDetailsDialogHdl, weld::Button&, void); DECL_LINK(SteppedDetailsDialogHdl, weld::Button&, void); - std::shared_ptr<SplinePropertiesDialog> getSplinePropertiesDialog(); - std::shared_ptr<SteppedPropertiesDialog> getSteppedPropertiesDialog(); + const std::shared_ptr<SplinePropertiesDialog>& getSplinePropertiesDialog(); + const std::shared_ptr<SteppedPropertiesDialog>& getSteppedPropertiesDialog(); private: weld::Window* m_pParent; diff --git a/chart2/source/inc/DataBrowserModel.hxx b/chart2/source/inc/DataBrowserModel.hxx index 16acb2de0b07..f5b2d80070ad 100644 --- a/chart2/source/inc/DataBrowserModel.hxx +++ b/chart2/source/inc/DataBrowserModel.hxx @@ -98,7 +98,7 @@ public: sal_Int32 getMaxRowCount() const; // returns the UI string of the corresponding role - OUString getRoleOfColumn( sal_Int32 nColumnIndex ) const; + const OUString & getRoleOfColumn( sal_Int32 nColumnIndex ) const; bool isCategoriesColumn( sal_Int32 nColumnIndex ) const; struct tDataHeader diff --git a/chart2/source/inc/chartview/DrawModelWrapper.hxx b/chart2/source/inc/chartview/DrawModelWrapper.hxx index e555fb7ab021..94ad117b87b0 100644 --- a/chart2/source/inc/chartview/DrawModelWrapper.hxx +++ b/chart2/source/inc/chartview/DrawModelWrapper.hxx @@ -68,7 +68,7 @@ public: SAL_DLLPRIVATE virtual css::uno::Reference< css::frame::XModel > createUnoModel() override; - SAL_DLLPRIVATE css::uno::Reference< css::frame::XModel > + SAL_DLLPRIVATE const css::uno::Reference< css::frame::XModel > & getUnoModel(); SdrModel& getSdrModel(); diff --git a/chart2/source/view/axes/VAxisBase.hxx b/chart2/source/view/axes/VAxisBase.hxx index 4ee4f5e288ae..4b1a8de92750 100644 --- a/chart2/source/view/axes/VAxisBase.hxx +++ b/chart2/source/view/axes/VAxisBase.hxx @@ -70,7 +70,7 @@ public: rtl::Reference<::chart::ChartModel> const& xChartDoc, css::uno::Reference<css::uno::XComponentContext> const& rComponentContext); - std::shared_ptr<DataTableView> getDataTableView() { return m_pDataTableView; } + const std::shared_ptr<DataTableView> & getDataTableView() { return m_pDataTableView; } protected: //methods static size_t getIndexOfLongestLabel( const css::uno::Sequence<OUString>& rLabels ); diff --git a/chart2/source/view/main/DrawModelWrapper.cxx b/chart2/source/view/main/DrawModelWrapper.cxx index 71cd8d699cf7..8c418ec2374d 100644 --- a/chart2/source/view/main/DrawModelWrapper.cxx +++ b/chart2/source/view/main/DrawModelWrapper.cxx @@ -127,7 +127,7 @@ uno::Reference< frame::XModel > DrawModelWrapper::createUnoModel() return new SvxUnoDrawingModel( this ); //tell Andreas Schluens if SvxUnoDrawingModel is not needed anymore -> remove export from svx to avoid link problems in writer } -uno::Reference< frame::XModel > DrawModelWrapper::getUnoModel() +const uno::Reference< frame::XModel > & DrawModelWrapper::getUnoModel() { return SdrModel::getUnoModel(); } diff --git a/connectivity/source/commontools/sqlerror.cxx b/connectivity/source/commontools/sqlerror.cxx index 50c5968cd7d6..a4855e81d894 100644 --- a/connectivity/source/commontools/sqlerror.cxx +++ b/connectivity/source/commontools/sqlerror.cxx @@ -127,7 +127,7 @@ namespace connectivity return {}; } - OUString lcl_getResourceState(const ErrorCondition _eCondition) + const OUString & lcl_getResourceState(const ErrorCondition _eCondition) { switch (_eCondition) { @@ -136,7 +136,7 @@ namespace connectivity case css::sdb::ErrorCondition::DATA_CANNOT_SELECT_UNFILTERED: return STR_DATA_CANNOT_SELECT_UNFILTERED_STATE; } - return OUString(); + return EMPTY_OUSTRING; } } diff --git a/connectivity/source/drivers/mozab/bootstrap/MNSFolders.cxx b/connectivity/source/drivers/mozab/bootstrap/MNSFolders.cxx index 71c70c641b30..8b8bf0939a5b 100644 --- a/connectivity/source/drivers/mozab/bootstrap/MNSFolders.cxx +++ b/connectivity/source/drivers/mozab/bootstrap/MNSFolders.cxx @@ -148,10 +148,10 @@ namespace } -OUString getRegistryDir(MozillaProductType product) +const OUString & getRegistryDir(MozillaProductType product) { if (product == MozillaProductType_Default) - return OUString(); + return EMPTY_OUSTRING; return lcl_guessProfileRoot( product ); } diff --git a/connectivity/source/drivers/mozab/bootstrap/MNSFolders.hxx b/connectivity/source/drivers/mozab/bootstrap/MNSFolders.hxx index 90674a0f4e62..f61b808223a9 100644 --- a/connectivity/source/drivers/mozab/bootstrap/MNSFolders.hxx +++ b/connectivity/source/drivers/mozab/bootstrap/MNSFolders.hxx @@ -23,6 +23,6 @@ #include <rtl/ustring.hxx> -OUString getRegistryDir(css::mozilla::MozillaProductType product); +const OUString& getRegistryDir(css::mozilla::MozillaProductType product); /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/connectivity/source/drivers/odbc/ODatabaseMetaDataResultSet.cxx b/connectivity/source/drivers/odbc/ODatabaseMetaDataResultSet.cxx index dd153a6acaa5..f4ecb960c188 100644 --- a/connectivity/source/drivers/odbc/ODatabaseMetaDataResultSet.cxx +++ b/connectivity/source/drivers/odbc/ODatabaseMetaDataResultSet.cxx @@ -679,9 +679,9 @@ sal_Int32 ODatabaseMetaDataResultSet::getFetchSize() return 1; } -OUString ODatabaseMetaDataResultSet::getCursorName() +const OUString & ODatabaseMetaDataResultSet::getCursorName() { - return OUString(); + return EMPTY_OUSTRING; } diff --git a/connectivity/source/inc/odbc/ODatabaseMetaDataResultSet.hxx b/connectivity/source/inc/odbc/ODatabaseMetaDataResultSet.hxx index 4b151b2517ed..6056041020ab 100644 --- a/connectivity/source/inc/odbc/ODatabaseMetaDataResultSet.hxx +++ b/connectivity/source/inc/odbc/ODatabaseMetaDataResultSet.hxx @@ -87,7 +87,7 @@ namespace connectivity::odbc static sal_Int32 getFetchSize(); /// @throws css::sdbc::SQLException /// @throws css::uno::RuntimeException - static OUString getCursorName(); + static const OUString & getCursorName(); SWORD impl_getColumnType_nothrow(sal_Int32 columnIndex); sal_Int32 mapColumn (sal_Int32 column); commit 91106b5b6153f324399f4fbb74b0f90c6eccc7ec Author: Noel Grandin <[email protected]> AuthorDate: Thu Nov 7 08:16:35 2024 +0200 Commit: Noel Grandin <[email protected]> CommitDate: Thu Nov 7 10:03:42 2024 +0100 loplugin:passstuffbyref in avmedia..canvas Change-Id: I916a6431eb0720af16dcb5aa46b758f92dbe4ec4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176179 Tested-by: Jenkins Reviewed-by: Noel Grandin <[email protected]> diff --git a/avmedia/source/framework/mediaitem.cxx b/avmedia/source/framework/mediaitem.cxx index f587ced4241a..c2ecaa29d9bf 100644 --- a/avmedia/source/framework/mediaitem.cxx +++ b/avmedia/source/framework/mediaitem.cxx @@ -285,7 +285,7 @@ bool MediaItem::setMimeType(const OUString& rMimeType) return bChanged; } -OUString MediaItem::getMimeType() const +const OUString & MediaItem::getMimeType() const { return !m_pImpl->m_sMimeType.isEmpty() ? m_pImpl->m_sMimeType : AVMEDIA_MIMETYPE_COMMON; } diff --git a/basctl/source/basicide/baside2.hxx b/basctl/source/basicide/baside2.hxx index 37d7d75754a7..3006b5a76bd8 100644 --- a/basctl/source/basicide/baside2.hxx +++ b/basctl/source/basicide/baside2.hxx @@ -402,7 +402,7 @@ public: virtual bool HasActiveEditor () const override; void UpdateModule (); - OUString GetEditorColorScheme() { return m_sWinColorScheme; } + const OUString & GetEditorColorScheme() { return m_sWinColorScheme; } void SetEditorColorScheme(const OUString& rColorScheme); }; @@ -428,7 +428,7 @@ public: Color const & GetSyntaxBackgroundColor () const { return aSyntaxColors.GetBackgroundColor(); } Color const & GetFontColor () const { return aSyntaxColors.GetFontColor(); } Color const & GetSyntaxColor (TokenType eType) const { return aSyntaxColors.GetColor(eType); } - OUString GetActiveColorSchemeId() { return m_sColorSchemeId; } + const OUString & GetActiveColorSchemeId() { return m_sColorSchemeId; } void ApplyColorSchemeToCurrentWindow(const OUString& rSchemeId); protected: diff --git a/basctl/source/inc/BasicColorConfig.hxx b/basctl/source/inc/BasicColorConfig.hxx index 15b2f3faf78f..88be8a7662d8 100644 --- a/basctl/source/inc/BasicColorConfig.hxx +++ b/basctl/source/inc/BasicColorConfig.hxx @@ -73,7 +73,7 @@ public: virtual void Notify(const css::uno::Sequence<OUString>& aPropertyNames) override; ColorScheme GetColorScheme(const OUString& rScheme); - css::uno::Sequence<OUString> GetColorSchemeNames() { return m_aSchemeNames; } + const css::uno::Sequence<OUString>& GetColorSchemeNames() { return m_aSchemeNames; } // Returns the color scheme defined by the current Application Colors ColorScheme GetAutomaticColorScheme(); diff --git a/canvas/inc/parametricpolypolygon.hxx b/canvas/inc/parametricpolypolygon.hxx index 474bd5da247a..511ff2baff91 100644 --- a/canvas/inc/parametricpolypolygon.hxx +++ b/canvas/inc/parametricpolypolygon.hxx @@ -105,7 +105,7 @@ namespace canvas virtual css::uno::Sequence< OUString > SAL_CALL getSupportedServiceNames( ) override; /// Query all defining values of this object atomically - Values getValues() const; + const Values & getValues() const; private: virtual ~ParametricPolyPolygon() override; // we're a ref-counted UNO class. _We_ destroy ourselves. diff --git a/canvas/source/tools/parametricpolypolygon.cxx b/canvas/source/tools/parametricpolypolygon.cxx index d4d0a524e0e3..cb948e095277 100644 --- a/canvas/source/tools/parametricpolypolygon.cxx +++ b/canvas/source/tools/parametricpolypolygon.cxx @@ -226,7 +226,7 @@ namespace canvas { } - ParametricPolyPolygon::Values ParametricPolyPolygon::getValues() const + const ParametricPolyPolygon::Values & ParametricPolyPolygon::getValues() const { return maValues; } diff --git a/include/avmedia/mediaitem.hxx b/include/avmedia/mediaitem.hxx index 7d75b7ab4350..9836346c2159 100644 --- a/include/avmedia/mediaitem.hxx +++ b/include/avmedia/mediaitem.hxx @@ -121,7 +121,7 @@ public: const OUString& getFallbackURL() const; bool setMimeType(const OUString& rMimeType); - OUString getMimeType() const; + const OUString& getMimeType() const; bool setGraphic(const Graphic& rGraphic); const Graphic & getGraphic() const; bool setCrop(const css::text::GraphicCrop& rCrop);
