editeng/source/items/rubyitem.cxx | 2 -- include/editeng/rubyitem.hxx | 2 -- include/svx/sidebar/InspectorTextPanel.hxx | 2 -- sd/source/console/PresenterController.cxx | 6 ------ sd/source/console/PresenterController.hxx | 2 -- sd/source/ui/dlg/sdtreelb.cxx | 19 ------------------- sd/source/ui/inc/sdtreelb.hxx | 6 ------ svx/source/sidebar/inspector/InspectorTextPanel.cxx | 9 --------- sw/inc/docstyle.hxx | 10 ---------- sw/inc/frmfmt.hxx | 7 ------- sw/inc/names.hxx | 5 ----- sw/inc/swabstdlg.hxx | 3 --- sw/inc/unostyle.hxx | 1 - sw/source/ui/dialog/swdlgfact.cxx | 5 ----- sw/source/uibase/inc/fldtdlg.hxx | 1 - 15 files changed, 80 deletions(-)
New commits: commit 9585f2400eb1dee4ee345e7e659203410d1a6909 Author: Noel Grandin <noel.gran...@collabora.co.uk> AuthorDate: Fri May 16 14:03:50 2025 +0200 Commit: Noel Grandin <noel.gran...@collabora.co.uk> CommitDate: Sat May 17 13:00:55 2025 +0200 loplugin:unusedmethods Change-Id: If9b083dd1a4ffcf093ee8af0c654df7fdb38e220 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185413 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.gran...@collabora.co.uk> diff --git a/editeng/source/items/rubyitem.cxx b/editeng/source/items/rubyitem.cxx index 76d8ecab701e..e79d2137dfbc 100644 --- a/editeng/source/items/rubyitem.cxx +++ b/editeng/source/items/rubyitem.cxx @@ -22,8 +22,6 @@ using namespace ::com::sun::star; -SfxPoolItem* SvxRubyItem::CreateDefault() { return new SvxRubyItem(0); } - SvxRubyItem::SvxRubyItem(const sal_uInt16 nId) : SfxPoolItem(nId) { diff --git a/include/editeng/rubyitem.hxx b/include/editeng/rubyitem.hxx index 3c8b88ea2c3d..3b2fd44e1e11 100644 --- a/include/editeng/rubyitem.hxx +++ b/include/editeng/rubyitem.hxx @@ -30,8 +30,6 @@ class EDITENG_DLLPUBLIC SvxRubyItem : public SfxPoolItem sal_Int16 m_ePosition = css::text::RubyPosition::ABOVE; public: - static SfxPoolItem* CreateDefault(); - DECLARE_ITEM_TYPE_FUNCTION(SvxRubyItem) explicit SvxRubyItem(const sal_uInt16 nId); diff --git a/include/svx/sidebar/InspectorTextPanel.hxx b/include/svx/sidebar/InspectorTextPanel.hxx index 2c875dc99d57..331ea29f0fe5 100644 --- a/include/svx/sidebar/InspectorTextPanel.hxx +++ b/include/svx/sidebar/InspectorTextPanel.hxx @@ -49,8 +49,6 @@ class SVX_DLLPUBLIC InspectorTextPanel public: virtual ~InspectorTextPanel() override; - static std::unique_ptr<PanelLayout> Create(weld::Widget* pParent, SfxBindings* pBindings); - InspectorTextPanel(weld::Widget* pParent, SfxBindings* pBindings); void updateEntries(const std::vector<TreeNode>& rStore, const sal_Int32 nParIdx); diff --git a/sd/source/console/PresenterController.cxx b/sd/source/console/PresenterController.cxx index 127f5e61e67d..764bea6ca778 100644 --- a/sd/source/console/PresenterController.cxx +++ b/sd/source/console/PresenterController.cxx @@ -527,12 +527,6 @@ util::URL PresenterController::CreateURLFromString (const OUString& rsURL) const return aURL; } -const Reference<drawing::framework::XConfigurationController>& - PresenterController::GetConfigurationController() const -{ - return mxConfigurationController; -} - const Reference<drawing::XDrawPage>& PresenterController::GetCurrentSlide() const { return mxCurrentSlide; diff --git a/sd/source/console/PresenterController.hxx b/sd/source/console/PresenterController.hxx index 76d9367f5372..ff3a6d95f775 100644 --- a/sd/source/console/PresenterController.hxx +++ b/sd/source/console/PresenterController.hxx @@ -116,8 +116,6 @@ public: css::uno::Reference<css::frame::XDispatch> GetDispatch ( const css::util::URL& rURL) const; css::util::URL CreateURLFromString (const OUString& rsURL) const; - const css::uno::Reference<css::drawing::framework::XConfigurationController>& - GetConfigurationController() const; const css::uno::Reference<css::drawing::XDrawPage>& GetCurrentSlide() const; static bool HasTransition (css::uno::Reference<css::drawing::XDrawPage> const & rxPage); static bool HasCustomAnimation (css::uno::Reference<css::drawing::XDrawPage> const & rxPage); diff --git a/sd/source/ui/dlg/sdtreelb.cxx b/sd/source/ui/dlg/sdtreelb.cxx index 2db89458adca..caebcba126e0 100644 --- a/sd/source/ui/dlg/sdtreelb.cxx +++ b/sd/source/ui/dlg/sdtreelb.cxx @@ -76,13 +76,6 @@ sd::DrawViewShell* lcl_getDrawViewShell(const SdDrawDocument* pDoc) } -bool SdPageObjsTLV::bIsInDrag = false; - -bool SdPageObjsTLV::IsInDrag() -{ - return bIsInDrag; -} - SotClipboardFormatId SdPageObjsTLV::SdPageObjsTransferable::mnListBoxDropFormatId = static_cast<SotClipboardFormatId>(SAL_MAX_UINT32); SdPageObjsTLV::SdPageObjsTransferable::SdPageObjsTransferable( @@ -128,12 +121,6 @@ bool SdPageObjsTLV::SdPageObjsTransferable::GetData( const css::datatransfer::Da } } -void SdPageObjsTLV::SdPageObjsTransferable::DragFinished( sal_Int8 nDropAction ) -{ - SdPageObjsTLV::OnDragFinished(); - SdTransferable::DragFinished(nDropAction); -} - SdPageObjsTLV::SdPageObjsTransferable* SdPageObjsTLV::SdPageObjsTransferable::getImplementation( const css::uno::Reference< css::uno::XInterface >& rxData ) noexcept { @@ -457,7 +444,6 @@ bool SdPageObjsTLV::DoDrag() m_xDropTargetHelper->SetDrawView(pViewShell->GetDrawView()); m_xDropTargetHelper->SetOrderFrontToBack(m_bOrderFrontToBack); - bIsInDrag = true; std::unique_ptr<weld::TreeIter> xEntry = m_xTreeView->make_iterator(); bool bUserData = m_xTreeView->get_cursor(xEntry.get()); @@ -495,11 +481,6 @@ bool SdPageObjsTLV::DoDrag() return false; } -void SdPageObjsTLV::OnDragFinished() -{ - bIsInDrag = false; -} - SdPageObjsTLVDropTarget::SdPageObjsTLVDropTarget(weld::TreeView& rTreeView) : DropTargetHelper(rTreeView.get_drop_target()) , m_rTreeView(rTreeView) diff --git a/sd/source/ui/inc/sdtreelb.hxx b/sd/source/ui/inc/sdtreelb.hxx index e61a6d0bd127..efe735f0c5b2 100644 --- a/sd/source/ui/inc/sdtreelb.hxx +++ b/sd/source/ui/inc/sdtreelb.hxx @@ -71,8 +71,6 @@ public: class SdPageObjsTLV { private: - static bool bIsInDrag; ///< static, in the case the navigator is deleted in ExecuteDrag - std::unique_ptr<weld::TreeView> m_xTreeView; std::unique_ptr<weld::TreeIter> m_xScratchIter; std::unique_ptr<SdPageObjsTLVDropTarget> m_xDropTargetHelper; @@ -163,7 +161,6 @@ private: bool PageBelongsToCurrentShow (const SdPage* pPage) const; bool DoDrag(); - static void OnDragFinished(); // DragSourceHelper bool StartDrag(); @@ -326,8 +323,6 @@ public: bool IsEqualToShapeList(std::unique_ptr<weld::TreeIter>& rEntry, const SdrObjList& rList, std::u16string_view rListName); - static bool IsInDrag(); - /** Return the view shell that is linked to the given doc shell. Call this method when the there is a chance that the doc shell has been disconnected from the view shell (but not the other @@ -435,7 +430,6 @@ public: virtual void AddSupportedFormats() override; virtual bool GetData( const css::datatransfer::DataFlavor& rFlavor, const OUString& rDestDoc ) override; - virtual void DragFinished( sal_Int8 nDropAction ) override; }; friend class SdPageObjsTLV::SdPageObjsTransferable; diff --git a/svx/source/sidebar/inspector/InspectorTextPanel.cxx b/svx/source/sidebar/inspector/InspectorTextPanel.cxx index 4ec0f39f97ba..930ed0f792e6 100644 --- a/svx/source/sidebar/inspector/InspectorTextPanel.cxx +++ b/svx/source/sidebar/inspector/InspectorTextPanel.cxx @@ -41,15 +41,6 @@ const int MinimumPanelWidth = 250; namespace svx::sidebar { -std::unique_ptr<PanelLayout> InspectorTextPanel::Create(weld::Widget* pParent, - SfxBindings* pBindings) -{ - if (pParent == nullptr) - throw lang::IllegalArgumentException( - u"no parent Window given to InspectorTextPanel::Create"_ustr, nullptr, 0); - return std::make_unique<InspectorTextPanel>(pParent, pBindings); -} - InspectorTextPanel::InspectorTextPanel(weld::Widget* pParent, SfxBindings* pBindings) : PanelLayout(pParent, u"InspectorTextPanel"_ustr, u"svx/ui/inspectortextpanel.ui"_ustr) , mpListBoxStyles(m_xBuilder->weld_tree_view(u"listbox_fonts"_ustr)) diff --git a/sw/inc/docstyle.hxx b/sw/inc/docstyle.hxx index 8be2c4f71d30..69054b9eb1a2 100644 --- a/sw/inc/docstyle.hxx +++ b/sw/inc/docstyle.hxx @@ -145,16 +145,6 @@ public: virtual bool IsUsed() const override; }; -namespace std { -template<> -struct hash<std::pair<SfxStyleFamily,OUString>> -{ - std::size_t operator()(std::pair<SfxStyleFamily,OUString> const & pair) const - { return static_cast<std::size_t>(pair.first) ^ std::size_t(pair.second.hashCode()); } -}; -} - - // Iterator for Pool. class SwStyleSheetIterator final : public SfxStyleSheetIterator, public SfxListener { diff --git a/sw/inc/frmfmt.hxx b/sw/inc/frmfmt.hxx index 590dda6db131..22108028ca4c 100644 --- a/sw/inc/frmfmt.hxx +++ b/sw/inc/frmfmt.hxx @@ -87,13 +87,6 @@ class SW_DLLPUBLIC SwFrameFormat std::shared_ptr< SwTextBoxNode > m_pOtherTextBoxFormats; - struct change_name - { - change_name(const UIName &rName) : mName(rName) {} - void operator()(SwFormat *pFormat) { pFormat->m_aFormatName = mName; } - const UIName &mName; - }; - protected: SwFrameFormat( SwAttrPool& rPool, diff --git a/sw/inc/names.hxx b/sw/inc/names.hxx index ce6351eca4da..0ea33b4830bd 100644 --- a/sw/inc/names.hxx +++ b/sw/inc/names.hxx @@ -26,7 +26,6 @@ public: bool operator==(const OUString& s) const { return m_s == s; } bool operator==(std::u16string_view s) const { return m_s == s; } bool operator<(const UIName& s) const { return m_s < s.m_s; } - bool operator>(const UIName& s) const { return m_s > s.m_s; } private: OUString m_s; @@ -74,7 +73,6 @@ public: bool operator==(const OUString& s) const { return m_s == s; } bool operator==(std::u16string_view s) const { return m_s == s; } bool operator<(const SwMarkName& s) const { return m_s < s.m_s; } - bool operator>(const SwMarkName& s) const { return m_s > s.m_s; } private: OUString m_s; @@ -104,10 +102,7 @@ public: const OUString& toString() const { return m_s; } bool isEmpty() const { return m_s.isEmpty(); } bool operator==(const TableStyleName& s) const = default; - bool operator==(const OUString& s) const { return m_s == s; } bool operator==(std::u16string_view s) const { return m_s == s; } - bool operator<(const TableStyleName& s) const { return m_s < s.m_s; } - bool operator>(const TableStyleName& s) const { return m_s > s.m_s; } private: OUString m_s; diff --git a/sw/inc/swabstdlg.hxx b/sw/inc/swabstdlg.hxx index 77307b0cac3d..48d806486d3c 100644 --- a/sw/inc/swabstdlg.hxx +++ b/sw/inc/swabstdlg.hxx @@ -359,9 +359,6 @@ protected: virtual ~AbstractSwRenameXNamedDlg() override = default; public: virtual void SetForbiddenChars( const OUString& rSet ) = 0; - virtual void SetAlternativeAccess( - css::uno::Reference< css::container::XNameAccess > & xSecond, - css::uno::Reference< css::container::XNameAccess > & xThird ) = 0; }; /** diff --git a/sw/inc/unostyle.hxx b/sw/inc/unostyle.hxx index aa11a858683f..e63eeda2da3b 100644 --- a/sw/inc/unostyle.hxx +++ b/sw/inc/unostyle.hxx @@ -454,7 +454,6 @@ public: virtual sal_Bool SAL_CALL supportsService(const OUString& rServiceName) override; virtual css::uno::Sequence< OUString > SAL_CALL getSupportedServiceNames() override; - rtl::Reference<SwXBaseStyle> getStyleByUIName(const UIName& rName); rtl::Reference<SwXBaseStyle> getStyleByName(const OUString& rName); rtl::Reference<SwXPageStyle> getPageStyleByName(const OUString& rName); rtl::Reference<SwXStyle> getCharacterStyleByName(const OUString& rName); diff --git a/sw/source/ui/dialog/swdlgfact.cxx b/sw/source/ui/dialog/swdlgfact.cxx index e5ee386d07ec..22375eb34cc3 100644 --- a/sw/source/ui/dialog/swdlgfact.cxx +++ b/sw/source/ui/dialog/swdlgfact.cxx @@ -737,11 +737,6 @@ class AbstractSwRenameXNamedDlg_Impl public: using AbstractDialogImpl_BASE::AbstractDialogImpl_BASE; void SetForbiddenChars(const OUString& rSet) override { m_pDlg->SetForbiddenChars(rSet); } - void SetAlternativeAccess(css::uno::Reference<css::container::XNameAccess>& xSecond, - css::uno::Reference<css::container::XNameAccess>& xThird) override - { - m_pDlg->SetAlternativeAccess(xSecond, xThird); - } }; } diff --git a/sw/source/uibase/inc/fldtdlg.hxx b/sw/source/uibase/inc/fldtdlg.hxx index 46e18d176131..a77aa3edc6fd 100644 --- a/sw/source/uibase/inc/fldtdlg.hxx +++ b/sw/source/uibase/inc/fldtdlg.hxx @@ -52,7 +52,6 @@ public: DECL_LINK(CancelHdl, weld::Button&, void); void Initialize(SfxChildWinInfo const *pInfo); - void ReInitDlg(); void EnableInsert(bool bEnable); void InsertHdl(); void ActivateDatabasePage();