compilerplugins/clang/unusedfields.only-used-in-constructor.results | 36 +++----- compilerplugins/clang/unusedfields.readonly.results | 34 ++++++-- compilerplugins/clang/unusedfields.untouched.results | 10 -- compilerplugins/clang/unusedfields.writeonly.results | 42 +++++----- cui/source/inc/connect.hxx | 1 cui/source/tabpages/connect.cxx | 3 forms/source/component/FormComponent.cxx | 1 forms/source/inc/FormComponent.hxx | 2 sw/source/ui/utlui/swrenamexnameddlg.cxx | 2 sw/source/uibase/inc/swrenamexnameddlg.hxx | 2 10 files changed, 71 insertions(+), 62 deletions(-)
New commits: commit 7ed9c9b724aabe7aa09649dc6da4142fa7d33704 Author: Noel Grandin <noel.gran...@collabora.co.uk> AuthorDate: Tue Jun 17 13:12:21 2025 +0200 Commit: Noel Grandin <noel.gran...@collabora.co.uk> CommitDate: Wed Jun 18 22:04:09 2025 +0200 loplugin:unusedfields update results Change-Id: If922c73df12422d0f102f3e64bdf0211a3d487c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186670 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.gran...@collabora.co.uk> diff --git a/compilerplugins/clang/unusedfields.only-used-in-constructor.results b/compilerplugins/clang/unusedfields.only-used-in-constructor.results index 020c7d86ae32..88aa8b8b03be 100644 --- a/compilerplugins/clang/unusedfields.only-used-in-constructor.results +++ b/compilerplugins/clang/unusedfields.only-used-in-constructor.results @@ -142,8 +142,6 @@ cppu/source/uno/check.cxx:137 (anonymous namespace)::Char3 c3 char cppu/source/uno/check.cxx:267 (anonymous namespace)::Char4 chars Char3 -cui/source/dialogs/colorpicker.cxx:744 - cui::(anonymous namespace)::ColorPickerDialog m_aColorPrevious ColorPreviewControl cui/source/factory/dlgfact.cxx:1177 (anonymous namespace)::SvxMacroAssignDialog_Impl m_aItems SfxItemSet cui/source/inc/AdditionsDialog.hxx:46 @@ -152,6 +150,8 @@ cui/source/inc/AdditionsDialog.hxx:82 AdditionsDialog m_sTag OUString cui/source/inc/cfgutil.hxx:244 SvxScriptSelectorDialog m_aStylesInfo SfxStylesInfo_Impl +cui/source/inc/connect.hxx:34 + SvxConnectionPage rOutAttrs const SfxItemSet & cui/source/inc/cuitabarea.hxx:232 SvxAreaTabPage maFixed_ChangeType ChangeType cui/source/inc/cuitabarea.hxx:236 @@ -254,7 +254,7 @@ include/LibreOfficeKit/LibreOfficeKitGtk.h:41 _LOKDocView aDrawingArea GtkDrawingArea include/LibreOfficeKit/LibreOfficeKitGtk.h:46 _LOKDocViewClass parent_class GtkDrawingAreaClass -include/oox/export/shapes.hxx:104 +include/oox/export/shapes.hxx:103 oox::drawingml::ShapeExport maShapeMap ShapeHashMap include/registry/registry.hxx:34 Registry_Api acquire void (*)(RegHandle) @@ -520,7 +520,7 @@ sc/source/filter/inc/xistream.hxx:171 XclImpBiff8StdDecrypter maCodec ::msfilter::MSCodec_Std97 sc/source/filter/inc/xistream.hxx:193 XclImpBiff8CryptoAPIDecrypter maCodec ::msfilter::MSCodec_CryptoAPI -sc/source/filter/oox/worksheethelper.cxx:398 +sc/source/filter/oox/worksheethelper.cxx:396 oox::xls::WorksheetGlobals mxProgressBar ISegmentProgressBarRef sc/source/filter/xml/xmldrani.hxx:71 ScXMLDatabaseRangeContext bIsSelection _Bool @@ -550,7 +550,7 @@ sd/inc/anminfo.hxx:51 SdAnimationInfo maSecondSoundFile OUString sd/qa/inc/sdtiledrenderingtest.hxx:79 SdTestViewCallback m_callbackWrapper TestLokCallbackWrapper -sd/qa/unit/tiledrendering/tiledrendering.cxx:2835 +sd/qa/unit/tiledrendering/tiledrendering.cxx:2830 (anonymous namespace)::SlideRendererChecker mnSlideNumber sal_Int32 sd/source/filter/eppt/epptbase.hxx:348 PPTWriterBase maFraction Fraction @@ -752,7 +752,7 @@ sw/inc/unosett.hxx:143 SwXNumberingRules m_pImpl ::sw::UnoImplPtr<Impl> sw/qa/core/test_ToxTextGenerator.cxx:145 (anonymous namespace)::ToxTextGeneratorWithMockedChapterField mChapterFieldType SwChapterFieldType -sw/qa/extras/uiwriter/uiwriter10.cxx:47 +sw/qa/extras/uiwriter/uiwriter10.cxx:48 SwUiWriterTest5 m_aSavedSettings AllSettings sw/qa/inc/swtestviewcallback.hxx:56 SwTestViewCallback m_callbackWrapper TestLokCallbackWrapper @@ -764,9 +764,9 @@ sw/source/core/inc/swfont.hxx:999 SvStatistics nGetStretchTextSize sal_uInt16 sw/source/core/layout/dbg_lay.cxx:181 SwImplEnterLeave m_nAction DbgAction -sw/source/core/text/inftxt.cxx:564 +sw/source/core/text/inftxt.cxx:568 (anonymous namespace)::SwTransparentTextGuard m_aContentVDev ScopedVclPtrInstance<VirtualDevice> -sw/source/core/text/inftxt.hxx:725 +sw/source/core/text/inftxt.hxx:732 SwTextSlot aText OUString sw/source/core/text/porfld.cxx:146 (anonymous namespace)::SwFieldSlot aText OUString @@ -784,8 +784,6 @@ sw/source/uibase/docvw/romenu.hxx:49 SwReadOnlyPopup m_nReadonlyBackgroundtogallery sal_uInt16 sw/source/uibase/inc/conttree.hxx:343 SwGlobalTree m_aDropTargetHelper SwGlobalTreeDropTarget -sw/source/uibase/inc/fldtdlg.hxx:35 - SwFieldDlg m_bHtmlMode _Bool sw/source/uibase/inc/olmenu.hxx:78 SwSpellPopup m_aBuilder VclBuilder sw/source/uibase/inc/swuicnttab.hxx:244 @@ -910,7 +908,7 @@ vcl/inc/font/TTFStructure.hxx:114 font::HeadTable nGlyphDataFormat o3tl::sal_uInt16_BE vcl/inc/font/TTFStructure.hxx:126 font::NameTable nVersion o3tl::sal_uInt16_BE -vcl/inc/graphic/Manager.hxx:37 +vcl/inc/graphic/Manager.hxx:38 vcl::graphic::MemoryManager mnTimeout sal_Int32 vcl/inc/headless/BitmapHelper.hxx:32 BitmapHelper aTmpBmp SvpSalBitmap @@ -926,15 +924,13 @@ vcl/inc/pdf/pdfbuildin_fonts.hxx:42 vcl::pdf::BuildinFont m_aWidths const int[256] vcl/inc/pdf/pdfwriter_impl.hxx:1077 vcl::PDFWriterImpl m_bIsPDF_A4 _Bool -vcl/inc/qt5/QtDragAndDrop.hxx:56 - QtDropTarget m_pFrame QtFrame * vcl/inc/qt5/QtInstanceToolbar.hxx:20 QtInstanceToolbar m_pToolBar QToolBar * vcl/inc/salprn.hxx:46 SalPrinterQueueInfo moPortName std::optional<OUString> -vcl/inc/salvtables.hxx:613 +vcl/inc/salvtables.hxx:615 SalInstanceEntry m_aTextFilter WeldTextFilter -vcl/inc/salvtables.hxx:1004 +vcl/inc/salvtables.hxx:1006 SalInstanceComboBoxWithEdit m_aTextFilter WeldTextFilter vcl/inc/sft.hxx:178 vcl::TTGlobalFontInfo_ fsSelection sal_uInt16 @@ -988,15 +984,15 @@ vcl/unx/gtk3/gloactiongroup.cxx:27 (anonymous namespace)::GLOAction parent_instance GObject vcl/unx/gtk3/glomenu.cxx:16 GLOMenu parent_instance const GMenuModel -vcl/unx/gtk3/gtkinst.cxx:7428 +vcl/unx/gtk3/gtkinst.cxx:7446 (anonymous namespace)::GtkInstanceAssistant m_pButtonBox GtkButtonBox * -vcl/unx/gtk3/gtkinst.cxx:11134 +vcl/unx/gtk3/gtkinst.cxx:11152 (anonymous namespace)::GtkInstanceMenuToggleButton m_pContainer GtkBox * -vcl/unx/gtk3/gtkinst.cxx:11136 +vcl/unx/gtk3/gtkinst.cxx:11154 (anonymous namespace)::GtkInstanceMenuToggleButton m_pMenuButton GtkMenuButton * -vcl/unx/gtk3/gtkinst.cxx:21286 +vcl/unx/gtk3/gtkinst.cxx:21304 (anonymous namespace)::GtkInstanceComboBox m_pOverlay GtkOverlay * -vcl/unx/gtk3/gtkinst.cxx:21292 +vcl/unx/gtk3/gtkinst.cxx:21310 (anonymous namespace)::GtkInstanceComboBox m_pMenuTextRenderer GtkCellRenderer * xmloff/inc/XMLThemeContext.hxx:45 XMLThemeColorsContext m_aColorScheme std::vector<css::util::Color> diff --git a/compilerplugins/clang/unusedfields.readonly.results b/compilerplugins/clang/unusedfields.readonly.results index 319426434761..81342f1d7fca 100644 --- a/compilerplugins/clang/unusedfields.readonly.results +++ b/compilerplugins/clang/unusedfields.readonly.results @@ -296,6 +296,26 @@ include/basic/sbstar.hxx:50 StarBASIC aErrorHdl Link<StarBASIC *, _Bool> include/basic/sbstar.hxx:51 StarBASIC aBreakHdl Link<StarBASIC *, BasicDebugFlags> +include/basic/sbxvar.hxx:62 + SbxValues::(anonymous union at /home/noel/libo-plugin/include/basic/sbxvar.hxx:42:5) pByte sal_uInt8 * +include/basic/sbxvar.hxx:63 + SbxValues::(anonymous union at /home/noel/libo-plugin/include/basic/sbxvar.hxx:42:5) pUShort sal_uInt16 * +include/basic/sbxvar.hxx:64 + SbxValues::(anonymous union at /home/noel/libo-plugin/include/basic/sbxvar.hxx:42:5) pChar sal_Unicode * +include/basic/sbxvar.hxx:65 + SbxValues::(anonymous union at /home/noel/libo-plugin/include/basic/sbxvar.hxx:42:5) pInteger sal_Int16 * +include/basic/sbxvar.hxx:66 + SbxValues::(anonymous union at /home/noel/libo-plugin/include/basic/sbxvar.hxx:42:5) pULong sal_uInt32 * +include/basic/sbxvar.hxx:67 + SbxValues::(anonymous union at /home/noel/libo-plugin/include/basic/sbxvar.hxx:42:5) pLong sal_Int32 * +include/basic/sbxvar.hxx:68 + SbxValues::(anonymous union at /home/noel/libo-plugin/include/basic/sbxvar.hxx:42:5) puInt64 sal_uInt64 * +include/basic/sbxvar.hxx:69 + SbxValues::(anonymous union at /home/noel/libo-plugin/include/basic/sbxvar.hxx:42:5) pnInt64 sal_Int64 * +include/basic/sbxvar.hxx:71 + SbxValues::(anonymous union at /home/noel/libo-plugin/include/basic/sbxvar.hxx:42:5) pSingle float * +include/basic/sbxvar.hxx:72 + SbxValues::(anonymous union at /home/noel/libo-plugin/include/basic/sbxvar.hxx:42:5) pDouble double * include/comphelper/parallelsort.hxx:164 comphelper::(anonymous namespace)::Binner maLabels uint8_t[51200] include/connectivity/DriversConfig.hxx:77 @@ -710,7 +730,7 @@ sw/source/core/inc/swblocks.hxx:69 SwImpBlocks m_bInPutMuchBlocks _Bool sw/source/core/text/atrhndl.hxx:47 SwAttrHandler m_oFnt std::optional<SwFont> -sw/source/core/text/inftxt.cxx:564 +sw/source/core/text/inftxt.cxx:568 (anonymous namespace)::SwTransparentTextGuard m_aContentVDev ScopedVclPtrInstance<VirtualDevice> sw/source/core/text/redlnitr.hxx:75 SwRedlineItr m_pSet std::unique_ptr<SfxItemSet> @@ -732,6 +752,10 @@ sw/source/uibase/dbui/mmconfigitem.cxx:117 SwMailMergeConfigItem_Impl m_aNeutralGreetingLines std::vector<OUString> sw/source/uibase/inc/fldmgr.hxx:75 SwInsertField_Data m_aDBDataSource css::uno::Any +sw/source/uibase/inc/swrenamexnameddlg.hxx:30 + SwRenameXNamedDlg m_xSecondAccess css::uno::Reference<css::container::XNameAccess> +sw/source/uibase/inc/swrenamexnameddlg.hxx:31 + SwRenameXNamedDlg m_xThirdAccess css::uno::Reference<css::container::XNameAccess> sw/source/writerfilter/ooxml/OOXMLFactory.hxx:60 writerfilter::ooxml::AttributeInfo m_nToken Token_t sw/source/writerfilter/ooxml/OOXMLFactory.hxx:61 @@ -884,13 +908,13 @@ vcl/inc/salwtype.hxx:170 SalWheelMouseEvent mbDeltaIsPixel _Bool vcl/inc/salwtype.hxx:223 SalQueryCharPositionEvent mnCharPos sal_uLong -vcl/inc/svdata.hxx:277 +vcl/inc/svdata.hxx:279 ImplSVWinData mbIsLiveResize _Bool -vcl/inc/svdata.hxx:278 +vcl/inc/svdata.hxx:280 ImplSVWinData mbIsWaitingForNativeEvent _Bool -vcl/inc/svdata.hxx:330 +vcl/inc/svdata.hxx:332 ImplSVNWFData mbMenuBarDockingAreaCommonBG _Bool -vcl/inc/svdata.hxx:337 +vcl/inc/svdata.hxx:339 ImplSVNWFData mbNoFrameJunctionForPopups _Bool vcl/inc/toolbox.h:108 vcl::ToolBoxLayoutData m_aLineItemIds std::vector<ToolBoxItemId> diff --git a/compilerplugins/clang/unusedfields.untouched.results b/compilerplugins/clang/unusedfields.untouched.results index d79db319126c..df12223922c3 100644 --- a/compilerplugins/clang/unusedfields.untouched.results +++ b/compilerplugins/clang/unusedfields.untouched.results @@ -42,10 +42,6 @@ cui/source/inc/fileextcheckdlg.hxx:30 FileExtCheckDialog m_pOk std::unique_ptr<weld::Button> cui/source/inc/paragrph.hxx:73 SvxStdParagraphTabPage m_xAbsDist std::unique_ptr<weld::Label> -cui/source/inc/uitabpage.hxx:20 - UITabPage m_pApply std::unique_ptr<weld::Button> -cui/source/inc/uitabpage.hxx:21 - UITabPage m_pApplyAll std::unique_ptr<weld::Button> cui/source/options/optinet2.hxx:108 SvxSecurityTabPage m_xCertPathImg std::unique_ptr<weld::Widget> cui/source/options/optinet2.hxx:109 @@ -86,6 +82,8 @@ filter/source/xsltdialog/xmlfiltertabpagebasic.hxx:35 XMLFilterTabPageBasic m_xContainer std::unique_ptr<weld::Widget> filter/source/xsltdialog/xmlfiltertabpagexslt.hxx:45 XMLFilterTabPageXSLT m_xContainer std::unique_ptr<weld::Widget> +forms/source/inc/FormComponent.hxx:148 + frm::OControl m_xContext css::uno::Reference<css::uno::XComponentContext> framework/inc/dispatch/dispatchprovider.hxx:76 framework::DispatchProvider m_aProtocolHandlerCache HandlerCache helpcompiler/inc/HelpCompiler.hxx:200 @@ -100,7 +98,7 @@ include/docmodel/theme/FormatScheme.hxx:374 model::DashStop mnStopLength sal_Int32 include/drawinglayer/primitive2d/textlayoutdevice.hxx:77 drawinglayer::primitive2d::TextLayouterDevice maSolarGuard SolarMutexGuard -include/editeng/unotext.hxx:627 +include/editeng/unotext.hxx:628 SvxUnoTextRangeEnumeration mxParentText css::uno::Reference<css::text::XText> include/filter/msfilter/svdfppt.hxx:541 ProcessData aBackgroundColoredObjects ::std::vector<rtl::Reference<SdrObject> > @@ -442,7 +440,7 @@ svx/source/svdraw/svdmodel.cxx:93 SdrModelImpl mpThemeColorChanger std::shared_ptr<svx::IThemeColorChanger> svx/source/tbxctrls/layctrl.cxx:431 (anonymous namespace)::ColumnsWindow mxControl rtl::Reference<SvxColumnsToolBoxControl> -sw/qa/extras/uiwriter/uiwriter10.cxx:47 +sw/qa/extras/uiwriter/uiwriter10.cxx:48 SwUiWriterTest5 m_aSavedSettings AllSettings sw/source/core/crsr/crbm.cxx:62 (anonymous namespace)::CursorStateHelper m_aSaveState SwCursorSaveState diff --git a/compilerplugins/clang/unusedfields.writeonly.results b/compilerplugins/clang/unusedfields.writeonly.results index 38229c03cd29..28b60408f694 100644 --- a/compilerplugins/clang/unusedfields.writeonly.results +++ b/compilerplugins/clang/unusedfields.writeonly.results @@ -2,7 +2,7 @@ basctl/source/basicide/moduldlg.hxx:140 basctl::ObjectPage m_xDropTarget std::unique_ptr<SbTreeListBoxDropTarget> basctl/source/inc/basidesh.hxx:95 basctl::Shell m_aNotifier DocumentEventNotifier -basctl/source/inc/bastype2.hxx:181 +basctl/source/inc/bastype2.hxx:186 basctl::SbTreeListBox m_aNotifier DocumentEventNotifier basctl/source/inc/colorscheme.hxx:29 basctl::ColorScheme m_sSchemeName OUString @@ -82,11 +82,11 @@ canvas/source/cairo/cairo_spritedevicehelper.hxx:73 cairocanvas::SpriteDeviceHelper mbFullScreen _Bool canvas/source/cairo/cairo_spritehelper.hxx:98 cairocanvas::SpriteHelper mbTextureDirty _Bool -chart2/inc/ChartModel.hxx:160 +chart2/inc/ChartModel.hxx:161 chart::ChartModel m_aGraphicObjectVector std::vector<GraphicObject> -chart2/inc/ChartModel.hxx:523 - chart::ChartModel mnStart sal_Int32 chart2/inc/ChartModel.hxx:524 + chart::ChartModel mnStart sal_Int32 +chart2/inc/ChartModel.hxx:525 chart::ChartModel mnEnd sal_Int32 chart2/source/controller/dialogs/DialogModel.cxx:178 (anonymous namespace)::lcl_RolesWithRangeAppend m_rDestCnt tContainerType * @@ -534,9 +534,9 @@ include/editeng/outlobj.hxx:44 OutlinerParaObjData mbIsEditDoc _Bool include/editeng/splwrap.hxx:52 SvxSpellWrapper xWait std::unique_ptr<weld::WaitObject> -include/editeng/unotext.hxx:439 +include/editeng/unotext.hxx:440 SvxUnoTextBase xParentText css::uno::Reference<css::text::XText> -include/editeng/unotext.hxx:608 +include/editeng/unotext.hxx:609 SvxUnoTextContentEnumeration mxParentText css::uno::Reference<css::text::XText> include/filter/msfilter/dffpropset.hxx:35 DffPropFlags bBlip _Bool @@ -656,7 +656,7 @@ include/sfx2/minfitem.hxx:38 SfxMacroInfoItem aCommentText OUString include/sfx2/viewsh.hxx:186 SfxViewShell m_xHelper std::shared_ptr<SfxStoringHelper> -include/svl/poolitem.hxx:623 +include/svl/poolitem.hxx:624 SfxPoolItem m_bDeleted _Bool include/svl/sigstruct.hxx:125 SignatureInformation hasInconsistentSigningTime _Bool @@ -756,10 +756,10 @@ include/svx/sidebar/InspectorTextPanel.hxx:70 svx::sidebar::InspectorTextPanel mDFController sfx2::sidebar::ControllerItem include/svx/sidebar/LinePropertyPanelBase.hxx:94 svx::sidebar::LinePropertyPanelBase mxArrowHeadStyleDispatch std::unique_ptr<ToolbarUnoDispatcher> -include/svx/srchdlg.hxx:174 - SvxSearchDialog pSearchController std::unique_ptr<SvxSearchController> -include/svx/srchdlg.hxx:175 - SvxSearchDialog pOptionsController std::unique_ptr<SvxSearchController> +include/svx/srchdlg.hxx:172 + SvxSearchDialog m_pSearchController std::unique_ptr<SvxSearchController> +include/svx/srchdlg.hxx:173 + SvxSearchDialog m_pOptionsController std::unique_ptr<SvxSearchController> include/svx/svdmrkv.hxx:100 SdrMarkView mpMarkingSelectionOverlay std::unique_ptr<MarkingSelectionOverlay> include/svx/svdmrkv.hxx:101 @@ -1210,7 +1210,7 @@ sd/inc/drawdoc.hxx:184 InsertBookmarkOptions bIsFileDocument _Bool sd/inc/sdmod.hxx:139 SdModule mpErrorHdl std::unique_ptr<SfxErrorHandler> -sd/source/console/PresenterTimer.cxx:110 +sd/source/console/PresenterTimer.cxx:111 sdext::presenter::(anonymous namespace)::TimerScheduler mpLateDestroy std::shared_ptr<TimerScheduler> sd/source/ui/dlg/RemoteDialogClientBox.hxx:66 sd::ClientBox m_vEntries std::vector<TClientBoxEntry> @@ -1484,7 +1484,7 @@ sw/inc/accmap.hxx:95 SwAccessibleMap mvShapes std::vector<css::uno::Reference<css::drawing::XShape> > sw/inc/swmodule.hxx:93 SwModule m_pErrorHandler std::unique_ptr<SfxErrorHandler> -sw/inc/swmodule.hxx:106 +sw/inc/swmodule.hxx:107 SwModule m_xLinguServiceEventListener rtl::Reference<SwLinguServiceEventListener> sw/inc/swwait.hxx:45 SwWait mpLockedDispatchers o3tl::sorted_vector<SfxDispatcher *> @@ -1510,15 +1510,15 @@ sw/source/core/inc/swfont.hxx:1001 SvStatistics nChangeFont sal_uInt16 sw/source/core/layout/dbg_lay.cxx:135 SwImplProtocol m_aVars std::vector<tools::Long> -sw/source/core/layout/tabfrm.cxx:2127 +sw/source/core/layout/tabfrm.cxx:2131 (anonymous namespace)::PosSizeOscillationControl::FrameData frameArea SwRect -sw/source/core/layout/tabfrm.cxx:2128 +sw/source/core/layout/tabfrm.cxx:2132 (anonymous namespace)::PosSizeOscillationControl::FrameData framePrintArea SwRect -sw/source/core/layout/tabfrm.cxx:2129 +sw/source/core/layout/tabfrm.cxx:2133 (anonymous namespace)::PosSizeOscillationControl::FrameData frameAreaPositionValid _Bool -sw/source/core/layout/tabfrm.cxx:2130 +sw/source/core/layout/tabfrm.cxx:2134 (anonymous namespace)::PosSizeOscillationControl::FrameData frameAreaSizeValid _Bool -sw/source/core/layout/tabfrm.cxx:2131 +sw/source/core/layout/tabfrm.cxx:2135 (anonymous namespace)::PosSizeOscillationControl::FrameData framePrintAreaValid _Bool sw/source/core/table/swtable.cxx:3100 SwTableCellInfo::Impl m_HandledTableBoxes TableBoxes_t @@ -1654,7 +1654,7 @@ vcl/inc/sft.hxx:168 vcl::TTGlobalFontInfo_ linegap int vcl/inc/sft.hxx:172 vcl::TTGlobalFontInfo_ typoLineGap int -vcl/inc/svdata.hxx:451 +vcl/inc/svdata.hxx:456 ImplSVEvent mpInstanceRef VclPtr<vcl::Window> vcl/inc/toolbarvalue.hxx:46 ToolbarValue mbIsTopDockingArea _Bool @@ -1978,13 +1978,13 @@ vcl/unx/gtk3/a11y/atkwrapper.hxx:80 AtkObjectWrapperClass aParentClass GtkWidgetAccessibleClass vcl/unx/gtk3/glomenu.cxx:16 GLOMenu parent_instance const GMenuModel -vcl/unx/gtk3/gtkinst.cxx:21297 +vcl/unx/gtk3/gtkinst.cxx:21315 (anonymous namespace)::GtkInstanceComboBox m_xCustomMenuButtonHelper std::unique_ptr<CustomRenderMenuButtonHelper> vcl/unx/gtk3/hudawareness.cxx:18 (anonymous namespace)::HudAwarenessHandle connection gpointer vcl/unx/gtk3/hudawareness.cxx:21 (anonymous namespace)::HudAwarenessHandle notify GDestroyNotify -vcl/workben/vcldemo.cxx:1723 +vcl/workben/vcldemo.cxx:1711 (anonymous namespace)::DemoWin mxThread rtl::Reference<RenderThread> xmlhelp/source/cxxhelp/provider/databases.hxx:256 chelp::Databases m_aDatabases DatabasesTable commit 8aaebe35f4b7d702b9f099309555b6e339adfeca Author: Noel Grandin <noel.gran...@collabora.co.uk> AuthorDate: Tue Jun 17 13:12:09 2025 +0200 Commit: Noel Grandin <noel.gran...@collabora.co.uk> CommitDate: Wed Jun 18 22:04:00 2025 +0200 loplugin:unusedfields Change-Id: I25e45339e9cd60c16d1ff50d9aad25d64d95a8fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186669 Reviewed-by: Noel Grandin <noel.gran...@collabora.co.uk> Tested-by: Jenkins diff --git a/cui/source/inc/connect.hxx b/cui/source/inc/connect.hxx index 103e83c071e8..a6166f511e3c 100644 --- a/cui/source/inc/connect.hxx +++ b/cui/source/inc/connect.hxx @@ -31,7 +31,6 @@ class SvxConnectionPage : public SfxTabPage { private: static const WhichRangesContainer pRanges; - const SfxItemSet& rOutAttrs; SfxItemSet aAttrSet; const SdrView* pView; MapUnit eUnit; diff --git a/cui/source/tabpages/connect.cxx b/cui/source/tabpages/connect.cxx index 0fda24224e16..56bea8179636 100644 --- a/cui/source/tabpages/connect.cxx +++ b/cui/source/tabpages/connect.cxx @@ -61,7 +61,6 @@ SvxConnectionDialog::SvxConnectionDialog(weld::Window* pParent, const SfxItemSet SvxConnectionPage::SvxConnectionPage(weld::Container* pPage, weld::DialogController* pController, const SfxItemSet& rInAttrs) : SfxTabPage(pPage, pController, u"cui/ui/connectortabpage.ui"_ustr, u"ConnectorTabPage"_ustr, &rInAttrs) - , rOutAttrs(rInAttrs) , aAttrSet(*rInAttrs.GetPool()) , pView(nullptr) , m_xLbType(m_xBuilder->weld_combo_box(u"LB_TYPE"_ustr)) @@ -77,7 +76,7 @@ SvxConnectionPage::SvxConnectionPage(weld::Container* pPage, weld::DialogControl , m_xMtrFldVert2(m_xBuilder->weld_metric_spin_button(u"MTR_FLD_VERT_2"_ustr, FieldUnit::MM)) , m_xCtlPreview(new weld::CustomWeld(*m_xBuilder, u"CTL_PREVIEW"_ustr, m_aCtlPreview)) { - SfxItemPool* pPool = rOutAttrs.GetPool(); + SfxItemPool* pPool = rInAttrs.GetPool(); assert(pPool && "Where is the pool"); eUnit = pPool->GetMetric( SDRATTR_EDGENODE1HORZDIST ); diff --git a/forms/source/component/FormComponent.cxx b/forms/source/component/FormComponent.cxx index 74d46b8c0a83..a1724092f92b 100644 --- a/forms/source/component/FormComponent.cxx +++ b/forms/source/component/FormComponent.cxx @@ -117,7 +117,6 @@ private: // base class for form layer controls OControl::OControl( const Reference< XComponentContext >& _rxContext, const OUString& _rAggregateService, const bool _bSetDelegator ) :OComponentHelper(m_aMutex) - ,m_xContext( _rxContext ) { // Aggregate VCL Control // Increment the RefCount for aggregates, because the aggregate by itself increments the RefCount in the setDelegator diff --git a/forms/source/inc/FormComponent.hxx b/forms/source/inc/FormComponent.hxx index 0a0ec19be553..45d6837d1b2c 100644 --- a/forms/source/inc/FormComponent.hxx +++ b/forms/source/inc/FormComponent.hxx @@ -144,8 +144,6 @@ protected: css::uno::Reference< css::uno::XAggregation> m_xAggregate; - css::uno::Reference< css::uno::XComponentContext > - m_xContext; WindowStateGuard m_aWindowStateGuard; public: diff --git a/sw/source/ui/utlui/swrenamexnameddlg.cxx b/sw/source/ui/utlui/swrenamexnameddlg.cxx index c527626bb0b9..348040633844 100644 --- a/sw/source/ui/utlui/swrenamexnameddlg.cxx +++ b/sw/source/ui/utlui/swrenamexnameddlg.cxx @@ -70,8 +70,6 @@ IMPL_LINK(SwRenameXNamedDlg, ModifyHdl, weld::Entry&, rEdit, void) m_xOk->set_sensitive(!sTmp.isEmpty() && !m_xNameAccess->hasByName(sTmp) - && (!m_xSecondAccess.is() || !m_xSecondAccess->hasByName(sTmp)) - && (!m_xThirdAccess.is() || !m_xThirdAccess->hasByName(sTmp)) ); } diff --git a/sw/source/uibase/inc/swrenamexnameddlg.hxx b/sw/source/uibase/inc/swrenamexnameddlg.hxx index 50652538358d..c97e1900369c 100644 --- a/sw/source/uibase/inc/swrenamexnameddlg.hxx +++ b/sw/source/uibase/inc/swrenamexnameddlg.hxx @@ -27,8 +27,6 @@ class SwRenameXNamedDlg final : public weld::GenericDialogController { css::uno::Reference< css::container::XNamed > m_xNamed; css::uno::Reference< css::container::XNameAccess > m_xNameAccess; - css::uno::Reference< css::container::XNameAccess > m_xSecondAccess; - css::uno::Reference< css::container::XNameAccess > m_xThirdAccess; TextFilter m_aTextFilter;