core.git: Branch 'distro/collabora/co-25.04' - sc/qa sd/qa sw/qa

[Caolán McNamara (via logerrit)]

 sc/qa/unit/helper/sctiledrenderingtest.cxx     |    2 +-
 sd/qa/unit/sdtiledrenderingtest.cxx            |    6 +++---
 sw/qa/core/txtnode/txtnode.cxx                 |    2 +-
 sw/qa/extras/tiledrendering/tiledrendering.cxx |    2 +-
 sw/qa/unit/swtiledrenderingtest.cxx            |    2 +-
 5 files changed, 7 insertions(+), 7 deletions(-)

New commits:
commit 0547d280679d8f9b44768e7b28c98d4e4c02f44a
Author:     Caolán McNamara <caolan.mcnam...@collabora.com>
AuthorDate: Wed Jul 23 16:55:29 2025 +0100
Commit:     Miklos Vajna <vmik...@collabora.com>
CommitDate: Mon Jul 28 13:12:59 2025 +0200

    SfxLokHelper::getView(*) -> SfxLokHelper::getView(&)
    
    these ones are definitely passed a non-null ptr
    
    Change-Id: I74c11da76c2267a1ae6443240f5e978f0e57563f
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188283
    Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoff...@gmail.com>
    Reviewed-by: Miklos Vajna <vmik...@collabora.com>

diff --git a/sc/qa/unit/helper/sctiledrenderingtest.cxx 
b/sc/qa/unit/helper/sctiledrenderingtest.cxx
index 7d835209dd9b..b20122038889 100644
--- a/sc/qa/unit/helper/sctiledrenderingtest.cxx
+++ b/sc/qa/unit/helper/sctiledrenderingtest.cxx
@@ -65,7 +65,7 @@ ScModelObj* ScTiledRenderingTest::createDoc(const char* pName)
 void ScTiledRenderingTest::setupLibreOfficeKitViewCallback(SfxViewShell* 
pViewShell)
 {
     pViewShell->setLibreOfficeKitViewCallback(&m_callbackWrapper);
-    m_callbackWrapper.setLOKViewId(SfxLokHelper::getView(pViewShell));
+    m_callbackWrapper.setLOKViewId(SfxLokHelper::getView(*pViewShell));
 }
 
 void ScTiledRenderingTest::callback(int nType, const char* pPayload, void* 
pData)
diff --git a/sd/qa/unit/sdtiledrenderingtest.cxx 
b/sd/qa/unit/sdtiledrenderingtest.cxx
index 758b3c7b2628..3373d0e9f46e 100644
--- a/sd/qa/unit/sdtiledrenderingtest.cxx
+++ b/sd/qa/unit/sdtiledrenderingtest.cxx
@@ -70,10 +70,10 @@ SdTiledRenderingTest::createDoc(const char* pName,
     return pImpressDocument;
 }
 
-void SdTiledRenderingTest::setupLibreOfficeKitViewCallback(SfxViewShell& 
pViewShell)
+void SdTiledRenderingTest::setupLibreOfficeKitViewCallback(SfxViewShell& 
rViewShell)
 {
-    pViewShell.setLibreOfficeKitViewCallback(&m_callbackWrapper);
-    m_callbackWrapper.setLOKViewId(SfxLokHelper::getView(&pViewShell));
+    rViewShell.setLibreOfficeKitViewCallback(&m_callbackWrapper);
+    m_callbackWrapper.setLOKViewId(SfxLokHelper::getView(rViewShell));
 }
 
 void SdTiledRenderingTest::callback(int nType, const char* pPayload, void* 
pData)
diff --git a/sw/qa/core/txtnode/txtnode.cxx b/sw/qa/core/txtnode/txtnode.cxx
index fbf420f018ac..e537a8b94c8a 100644
--- a/sw/qa/core/txtnode/txtnode.cxx
+++ b/sw/qa/core/txtnode/txtnode.cxx
@@ -182,7 +182,7 @@ CPPUNIT_TEST_FIXTURE(SwCoreTxtnodeTest, 
testTitleFieldInvalidate)
     ViewCallback aCallback;
     TestLokCallbackWrapper aCallbackWrapper(&ViewCallback::callback, 
&aCallback);
     
pWrtShell->GetSfxViewShell()->setLibreOfficeKitViewCallback(&aCallbackWrapper);
-    
aCallbackWrapper.setLOKViewId(SfxLokHelper::getView(pWrtShell->GetSfxViewShell()));
+    
aCallbackWrapper.setLOKViewId(SfxLokHelper::getView(*pWrtShell->GetSfxViewShell()));
     Scheduler::ProcessEventsToIdle();
     aCallback.m_nInvalidations = 0;
 
diff --git a/sw/qa/extras/tiledrendering/tiledrendering.cxx 
b/sw/qa/extras/tiledrendering/tiledrendering.cxx
index 5afaa4e5515a..35a84bdb3d7f 100644
--- a/sw/qa/extras/tiledrendering/tiledrendering.cxx
+++ b/sw/qa/extras/tiledrendering/tiledrendering.cxx
@@ -2896,7 +2896,7 @@ CPPUNIT_TEST_FIXTURE(SwTiledRenderingTest, testHyperlink)
     SwXTextDocument* pXTextDocument = createDoc("hyperlink.odt");
     SwWrtShell* pWrtShell = getSwDocShell()->GetWrtShell();
     setupLibreOfficeKitViewCallback(pWrtShell->GetSfxViewShell());
-    
m_callbackWrapper.setLOKViewId(SfxLokHelper::getView(pWrtShell->GetSfxViewShell()));
+    
m_callbackWrapper.setLOKViewId(SfxLokHelper::getView(*pWrtShell->GetSfxViewShell()));
     SwShellCursor* pShellCursor = pWrtShell->getShellCursor(false);
 
     Point aStart = pShellCursor->GetSttPos();
diff --git a/sw/qa/unit/swtiledrenderingtest.cxx 
b/sw/qa/unit/swtiledrenderingtest.cxx
index 3ea1a08352b4..5efe20a6ed2c 100644
--- a/sw/qa/unit/swtiledrenderingtest.cxx
+++ b/sw/qa/unit/swtiledrenderingtest.cxx
@@ -81,7 +81,7 @@ SwXTextDocument* SwTiledRenderingTest::createDoc(const char* 
pName)
 void SwTiledRenderingTest::setupLibreOfficeKitViewCallback(SfxViewShell* 
pViewShell)
 {
     pViewShell->setLibreOfficeKitViewCallback(&m_callbackWrapper);
-    m_callbackWrapper.setLOKViewId(SfxLokHelper::getView(pViewShell));
+    m_callbackWrapper.setLOKViewId(SfxLokHelper::getView(*pViewShell));
 }
 
 void SwTiledRenderingTest::callback(int nType, const char* pPayload, void* 
pData)