sfx2/source/view/lokhelper.cxx | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
New commits:
commit 31d64347bcd7d45ebfdd153df310f572cf40e968
Author: Caolán McNamara <caolan.mcnam...@collabora.com>
AuthorDate: Wed Jul 23 17:02:15 2025 +0100
Commit: Miklos Vajna <vmik...@collabora.com>
CommitDate: Mon Jul 28 14:59:05 2025 +0200
SfxLokHelper::getView(*) -> SfxLokHelper::getView(&)
on inspection these ones are protected by a null check
or a previous dereference.
Change-Id: I9186c16ae3814be4654ad69a4fce5fadf2f928f3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188285
Reviewed-by: Miklos Vajna <vmik...@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoff...@gmail.com>
diff --git a/sfx2/source/view/lokhelper.cxx b/sfx2/source/view/lokhelper.cxx
index c690f81807f0..6e1445a28f1d 100644
--- a/sfx2/source/view/lokhelper.cxx
+++ b/sfx2/source/view/lokhelper.cxx
@@ -594,7 +594,7 @@ void SfxLokHelper::notifyOtherViews(const SfxViewShell*
pThisView, int nType, st
if (aPayload.isEmpty())
{
aPayload = lcl_generateJSON(pThisView, rKey, rPayload);
- viewId = SfxLokHelper::getView(pThisView);
+ viewId = SfxLokHelper::getView(*pThisView);
}
pViewShell->libreOfficeKitViewCallbackWithViewId(nType, aPayload,
viewId);
@@ -625,7 +625,7 @@ void SfxLokHelper::notifyOtherViews(const SfxViewShell*
pThisView, int nType,
if (aPayload.isEmpty())
{
aPayload = lcl_generateJSON(pThisView, rTree);
- viewId = SfxLokHelper::getView(pThisView);
+ viewId = SfxLokHelper::getView(*pThisView);
}
pViewShell->libreOfficeKitViewCallbackWithViewId(nType, aPayload,
viewId);
@@ -1126,7 +1126,7 @@ void
SfxLokHelper::notifyOtherViewsUpdatePerViewId(SfxViewShell const* pThisView
if (DisableCallbacks::disabled() || !pThisView)
return;
- int viewId = SfxLokHelper::getView(pThisView);
+ int viewId = SfxLokHelper::getView(*pThisView);
const ViewShellDocId nCurrentDocId = pThisView->GetDocId();
SfxViewShell* pViewShell = SfxViewShell::GetFirst();
while (pViewShell)
