cui/source/tabpages/paragrph.cxx | 1 + xmlsecurity/source/helper/pdfsignaturehelper.cxx | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-)
New commits: commit 99acc9079c4fb97832f04b7eed9c7777607d4261 Author: Caolán McNamara <caolan.mcnam...@collabora.com> AuthorDate: Mon Jul 28 20:00:11 2025 +0100 Commit: Caolán McNamara <caolan.mcnam...@collabora.com> CommitDate: Tue Jul 29 00:22:53 2025 +0200 cid#1660319 silence Dereference null return value Change-Id: Iae5ca2c14b703fd3a34cdf3709bb85372e6d02e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188509 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnam...@collabora.com> diff --git a/cui/source/tabpages/paragrph.cxx b/cui/source/tabpages/paragrph.cxx index ce13e2acfdb0..44b900941ac8 100644 --- a/cui/source/tabpages/paragrph.cxx +++ b/cui/source/tabpages/paragrph.cxx @@ -2131,6 +2131,7 @@ void SvxExtParagraphTabPage::Reset( const SfxItemSet* rSet ) aPageNumState.bTriStateEnabled = false; m_xPageNumBox->set_state(TRISTATE_TRUE); SfxUInt16Item const*const pItem(rSet->GetItem<SfxUInt16Item>(SID_ATTR_PARA_PAGENUM)); + assert(pItem && "has to exist due to GetItemState"); const sal_uInt16 nPageNum(pItem->GetValue()); m_xPagenumEdit->set_value(nPageNum); break; commit 83094e8fe6f068a62ff3be68db3509db90b3433a Author: Caolán McNamara <caolan.mcnam...@collabora.com> AuthorDate: Mon Jul 28 19:53:25 2025 +0100 Commit: Caolán McNamara <caolan.mcnam...@collabora.com> CommitDate: Tue Jul 29 00:22:43 2025 +0200 cid#1660393 Variable copied when it could be moved Change-Id: I4af2169ba914b3aa60735360c126f6a0cbd4909d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188508 Reviewed-by: Caolán McNamara <caolan.mcnam...@collabora.com> Tested-by: Jenkins diff --git a/xmlsecurity/source/helper/pdfsignaturehelper.cxx b/xmlsecurity/source/helper/pdfsignaturehelper.cxx index 8d316bcffd91..a0073ecd993a 100644 --- a/xmlsecurity/source/helper/pdfsignaturehelper.cxx +++ b/xmlsecurity/source/helper/pdfsignaturehelper.cxx @@ -287,7 +287,7 @@ void AnalyizeSignatureStream(SvMemoryStream& rStream, std::vector<PageChecksum>& break; } } - rPageChecksums.push_back(aPageChecksum); + rPageChecksums.push_back(std::move(aPageChecksum)); } }