filter/source/msfilter/svdfppt.cxx |    3 +--
 include/o3tl/safeint.hxx           |    2 +-
 2 files changed, 2 insertions(+), 3 deletions(-)

New commits:
commit 8c5daeb58ab3c29f98a52715e7daf2e987f8a7b0
Author:     Caolán McNamara <caolan.mcnam...@collabora.com>
AuthorDate: Sat Aug 2 20:00:12 2025 +0100
Commit:     Caolán McNamara <caolan.mcnam...@collabora.com>
CommitDate: Sun Aug 3 01:00:24 2025 +0200

    cid#1660365 silence Logically dead code
    
    lets see if result_independent_of_operands is redundant
    
    Change-Id: I3f8c941b5b6ac23cf691b9f60c75394d948ac982
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188857
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolan.mcnam...@collabora.com>

diff --git a/include/o3tl/safeint.hxx b/include/o3tl/safeint.hxx
index 47fdc70fd4a2..52b42e28a653 100644
--- a/include/o3tl/safeint.hxx
+++ b/include/o3tl/safeint.hxx
@@ -213,7 +213,7 @@ make_unsigned(T value)
 template<typename T1, typename T2> constexpr 
std::enable_if_t<std::is_unsigned_v<T1>, T1>
 clamp_to_unsigned(T2 value) {
     if constexpr (std::is_unsigned_v<T2>) {
-        // coverity[result_independent_of_operands] - suppress warning for 
template
+        // coverity[dead_error_line] - suppress warning for template
         return value <= std::numeric_limits<T1>::max() ? value : 
std::numeric_limits<T1>::max();
     } else {
         static_assert(std::is_signed_v<T2>);
commit 04513622c26d974e82b4e275715e9cda3c6efbed
Author:     Caolán McNamara <caolan.mcnam...@collabora.com>
AuthorDate: Sat Aug 2 19:56:52 2025 +0100
Commit:     Caolán McNamara <caolan.mcnam...@collabora.com>
CommitDate: Sun Aug 3 01:00:15 2025 +0200

    cid#1660528 Overflowed constant
    
    Change-Id: Ie06a4d77b7754d78707f6e4ea819c4fbf9a0491b
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188856
    Tested-by: Caolán McNamara <caolan.mcnam...@collabora.com>
    Reviewed-by: Caolán McNamara <caolan.mcnam...@collabora.com>

diff --git a/filter/source/msfilter/svdfppt.cxx 
b/filter/source/msfilter/svdfppt.cxx
index 187d3315b310..76395bb73b1f 100644
--- a/filter/source/msfilter/svdfppt.cxx
+++ b/filter/source/msfilter/svdfppt.cxx
@@ -1983,8 +1983,7 @@ std::unique_ptr<SvMemoryStream> 
SdrPowerPointImport::ImportExOleObjStg( sal_uInt
         ReadDffRecordHeader( rStCtrl, aHd );
         if ( aHd.nRecType == DFF_PST_ExOleObjStg )
         {
-            sal_uInt32 nLen = aHd.nRecLen - 4;
-            if ( static_cast<sal_Int32>(nLen) > 0 )
+            if (aHd.nRecLen > 4)
             {
                 rStCtrl.ReadUInt32( nOleId );
                 pRet.reset(new SvMemoryStream);

Reply via email to