basctl/source/basicide/bastype2.cxx | 4 +--- chart2/source/controller/main/ChartController_Insert.cxx | 2 +- connectivity/source/drivers/component/CDatabaseMetaData.cxx | 2 +- connectivity/source/drivers/evoab2/NDatabaseMetaData.cxx | 7 +++---- connectivity/source/drivers/mysqlc/mysqlc_databasemetadata.cxx | 2 +- connectivity/source/drivers/postgresql/pq_databasemetadata.cxx | 2 +- dbaccess/source/core/dataaccess/ModelImpl.cxx | 4 ++-- extensions/source/propctrlr/browserlistbox.cxx | 2 +- hwpfilter/source/hwpreader.cxx | 6 +++--- sc/source/filter/excel/xichart.cxx | 4 ++-- sc/source/filter/excel/xicontent.cxx | 2 +- sc/source/filter/orcus/autofilter.cxx | 2 +- sc/source/ui/drawfunc/drawsh.cxx | 3 +-- sc/source/ui/sparklines/SparklineList.cxx | 2 +- sfx2/source/notebookbar/SfxNotebookBar.cxx | 2 +- slideshow/source/engine/transitions/slidechangebase.cxx | 2 +- svx/source/customshapes/EnhancedCustomShapeFontWork.cxx | 4 ++-- svx/source/sdr/contact/viewobjectcontactofe3dscene.cxx | 4 ++-- sw/source/filter/ww8/docxattributeoutput.cxx | 3 +-- sw/source/filter/ww8/wrtww8.cxx | 2 +- sw/source/uibase/sidebar/WriterInspectorTextPanel.cxx | 8 ++++---- xmlhelp/source/cxxhelp/provider/resultsetforquery.cxx | 2 +- xmlsecurity/source/helper/xsecsign.cxx | 4 ++-- 23 files changed, 35 insertions(+), 40 deletions(-)
New commits: commit 6fc58fb3a496525f23500d10a63da8b810fb009b Author: Caolán McNamara <caolan.mcnam...@collabora.com> AuthorDate: Sat Aug 2 19:30:34 2025 +0100 Commit: Caolán McNamara <caolan.mcnam...@collabora.com> CommitDate: Sun Aug 3 12:18:26 2025 +0200 cid#1660346 Variable copied when it could be moved and cid#1660344 Variable copied when it could be moved cid#1660343 Variable copied when it could be moved cid#1660341 Variable copied when it could be moved cid#1660339 Variable copied when it could be moved cid#1660337 Variable copied when it could be moved cid#1660335 Variable copied when it could be moved cid#1660334 Variable copied when it could be moved Change-Id: I3758a4228d5e848750b4ef37296b4d38b5d3e31c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188850 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnam...@collabora.com> diff --git a/basctl/source/basicide/bastype2.cxx b/basctl/source/basicide/bastype2.cxx index f227a0dfcd43..2d869c8b7c12 100644 --- a/basctl/source/basicide/bastype2.cxx +++ b/basctl/source/basicide/bastype2.cxx @@ -506,9 +506,7 @@ void SbTreeListBox::ReloadAllEntries() while (bValidIter) { if (m_xControl->get_row_expanded(*m_xScratchIter)) { - EntryDescriptor aDesc = GetEntryDescriptor(m_xScratchIter.get()); - - aExpandedRows.insert(aDesc); + aExpandedRows.insert(GetEntryDescriptor(m_xScratchIter.get())); } bValidIter = m_xControl->iter_next(*m_xScratchIter); diff --git a/connectivity/source/drivers/component/CDatabaseMetaData.cxx b/connectivity/source/drivers/component/CDatabaseMetaData.cxx index 45a932657f67..8d40b20bc4eb 100644 --- a/connectivity/source/drivers/component/CDatabaseMetaData.cxx +++ b/connectivity/source/drivers/component/CDatabaseMetaData.cxx @@ -108,7 +108,7 @@ Reference< XResultSet > OComponentDatabaseMetaData::impl_getTypeInfo_throw( ) aRow[3] = ODatabaseMetaDataResultSet::get0Value(); aRow[9] = ODatabaseMetaDataResultSet::getBasicValue(); aRow[15] = ODatabaseMetaDataResultSet::get0Value(); - aRows.push_back(aRow); + aRows.push_back(std::move(aRow)); pResult->setRows(std::move(aRows)); return pResult; diff --git a/connectivity/source/drivers/evoab2/NDatabaseMetaData.cxx b/connectivity/source/drivers/evoab2/NDatabaseMetaData.cxx index 787495933b5e..1ebf685a4287 100644 --- a/connectivity/source/drivers/evoab2/NDatabaseMetaData.cxx +++ b/connectivity/source/drivers/evoab2/NDatabaseMetaData.cxx @@ -1123,17 +1123,16 @@ Reference< XResultSet > SAL_CALL OEvoabDatabaseMetaData::getTables( RTL_TEXTENCODING_UTF8 ); OUString aUID = OStringToOUString( e_source_get_uid( pSource ), RTL_TEXTENCODING_UTF8 ); - ODatabaseMetaDataResultSet::ORow aRow{ + aRows.push_back(ODatabaseMetaDataResultSet::ORow{ ORowSetValueDecoratorRef(), ORowSetValueDecoratorRef(), ORowSetValueDecoratorRef(), new ORowSetValueDecorator(aHumanName), //tablename new ORowSetValueDecorator(ORowSetValue(aTable)), - new ORowSetValueDecorator(aUID)}; //comment + new ORowSetValueDecorator(aUID)}); //comment //I'd prefer to swap the comment and the human name and //just use e_source_registry_ref_source(get_e_source_registry(), aUID); //in open book rather than search for the name again - aRows.push_back(aRow); } g_list_foreach (pSources, object_unref, nullptr); diff --git a/connectivity/source/drivers/mysqlc/mysqlc_databasemetadata.cxx b/connectivity/source/drivers/mysqlc/mysqlc_databasemetadata.cxx index c3c073f276b2..4da76dbe51f7 100644 --- a/connectivity/source/drivers/mysqlc/mysqlc_databasemetadata.cxx +++ b/connectivity/source/drivers/mysqlc/mysqlc_databasemetadata.cxx @@ -959,7 +959,7 @@ Reference<XResultSet> SAL_CALL ODatabaseMetaData::getImportedKeys(const Any& /*c aRow.push_back(Any(OUString{})); // TODO // deferrability aRow.push_back(Any(Deferrability::NONE)); - aRows.push_back(aRow); + aRows.push_back(std::move(aRow)); } lcl_setRows_throw(xResultSet, 1, aRows); return xResultSet; diff --git a/hwpfilter/source/hwpreader.cxx b/hwpfilter/source/hwpreader.cxx index 7bc9d4dbf581..cf3e31321f33 100644 --- a/hwpfilter/source/hwpreader.cxx +++ b/hwpfilter/source/hwpreader.cxx @@ -3650,8 +3650,8 @@ void HwpReader::makeHyperText(TxtBox * hbox) if( !hypert ) return; if (hypert->filename[0] != ' - ::std::string const tmp = hstr2ksstr(hypert->bookmark); - ::std::string const tmp2 = hstr2ksstr(kstr2hstr( + ::std::string tmp = hstr2ksstr(hypert->bookmark); + ::std::string tmp2 = hstr2ksstr(kstr2hstr( #ifdef _WIN32 reinterpret_cast<uchar const *>(urltowin(reinterpret_cast<char *>(hypert->filename)).c_str())).c_str()); #else @@ -3659,7 +3659,7 @@ void HwpReader::makeHyperText(TxtBox * hbox) #endif mxList->addAttribute(u"xlink:type"_ustr, sXML_CDATA, u"simple"_ustr); if (!tmp.empty() && strcmp(tmp.c_str(), "[HTML]")) { - ::std::string tmp3(tmp2); + ::std::string tmp3(std::move(tmp2)); tmp3.push_back('#'); tmp3.append(tmp); mxList->addAttribute(u"xlink:href"_ustr, sXML_CDATA, diff --git a/sc/source/filter/orcus/autofilter.cxx b/sc/source/filter/orcus/autofilter.cxx index 94015e87616a..17b54ea21c5f 100644 --- a/sc/source/filter/orcus/autofilter.cxx +++ b/sc/source/filter/orcus/autofilter.cxx @@ -161,7 +161,7 @@ void ScOrcusAutoFilterNode::append_item(os::col_t field, os::auto_filter_op_t op aEntry.GetQueryItem().meType = ScQueryEntry::ByValue; aEntry.GetQueryItem().mfVal = value; - maEntries.push_back(aEntry); + maEntries.push_back(std::move(aEntry)); } void ScOrcusAutoFilterNode::append_item(os::col_t field, os::auto_filter_op_t op, diff --git a/sc/source/ui/sparklines/SparklineList.cxx b/sc/source/ui/sparklines/SparklineList.cxx index 1cae3089616d..552ed17963b0 100644 --- a/sc/source/ui/sparklines/SparklineList.cxx +++ b/sc/source/ui/sparklines/SparklineList.cxx @@ -58,7 +58,7 @@ std::vector<std::shared_ptr<SparklineGroup>> SparklineList::getSparklineGroups() auto pWeakGroup = *iterator; if (auto pSparklineGroup = pWeakGroup.lock()) { - toReturn.push_back(pSparklineGroup); + toReturn.push_back(std::move(pSparklineGroup)); iterator++; } else diff --git a/xmlhelp/source/cxxhelp/provider/resultsetforquery.cxx b/xmlhelp/source/cxxhelp/provider/resultsetforquery.cxx index cbeeed2f4159..fef2e9b5923c 100644 --- a/xmlhelp/source/cxxhelp/provider/resultsetforquery.cxx +++ b/xmlhelp/source/cxxhelp/provider/resultsetforquery.cxx @@ -102,7 +102,7 @@ ResultSetForQuery::ResultSetForQuery( const uno::Reference< uno::XComponentConte tmp,0,tmp.getLength(),aSeq); currentQuery.push_back( toliterate ); - queryList.push_back( currentQuery ); + queryList.push_back(std::move(currentQuery)); int nCpy = 1 + idx; if( nCpy >= query.getLength() ) commit 8fc995213a50726afecab1778af698df617822b2 Author: Caolán McNamara <caolan.mcnam...@collabora.com> AuthorDate: Sat Aug 2 19:19:30 2025 +0100 Commit: Caolán McNamara <caolan.mcnam...@collabora.com> CommitDate: Sun Aug 3 12:18:19 2025 +0200 cid#1660374 Variable copied when it could be moved and cid#1660372 Variable copied when it could be moved cid#1660369 Variable copied when it could be moved cid#1660364 Variable copied when it could be moved cid#1660358 Variable copied when it could be moved cid#1660355 Variable copied when it could be moved cid#1660353 Variable copied when it could be moved cid#1660352 Variable copied when it could be moved cid#1660351 Variable copied when it could be moved Change-Id: I82e651e8d18a4461e81c7b0eb85c4ff6ec0e963a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188849 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnam...@collabora.com> diff --git a/chart2/source/controller/main/ChartController_Insert.cxx b/chart2/source/controller/main/ChartController_Insert.cxx index da50b06a8482..8a3c2faff667 100644 --- a/chart2/source/controller/main/ChartController_Insert.cxx +++ b/chart2/source/controller/main/ChartController_Insert.cxx @@ -374,7 +374,7 @@ void ChartController::executeDispatch_InsertMenu_DataLabels() OUString aObjectCID = ObjectIdentifier::createClassifiedIdentifierForParticles( ObjectIdentifier::getSeriesParticleFromCID(m_aSelection.getSelectedCID()), aChildParticle ); - ChartController::executeDlg_ObjectProperties_withUndoGuard( aUndoGuard, aObjectCID, true ); + ChartController::executeDlg_ObjectProperties_withUndoGuard(std::move(aUndoGuard), aObjectCID, true ); return; } try diff --git a/connectivity/source/drivers/postgresql/pq_databasemetadata.cxx b/connectivity/source/drivers/postgresql/pq_databasemetadata.cxx index 76157bc4c305..090747294c27 100644 --- a/connectivity/source/drivers/postgresql/pq_databasemetadata.cxx +++ b/connectivity/source/drivers/postgresql/pq_databasemetadata.cxx @@ -1173,7 +1173,7 @@ css::uno::Reference< XResultSet > DatabaseMetaData::getTables( row[4] <<= xRow->getString(4); // no description in postgresql AFAIK - vec.push_back( row ); + vec.push_back(std::move(row)); } Reference< XCloseable > closeable( statement, UNO_QUERY ); if( closeable.is() ) diff --git a/extensions/source/propctrlr/browserlistbox.cxx b/extensions/source/propctrlr/browserlistbox.cxx index 32b7951c1693..e4a6bd41a6f5 100644 --- a/extensions/source/propctrlr/browserlistbox.cxx +++ b/extensions/source/propctrlr/browserlistbox.cxx @@ -474,7 +474,7 @@ namespace pcr if ( _nPos >= m_aLines.size() ) { nInsertPos = m_aLines.size(); - m_aLines.push_back( aNewLine ); + m_aLines.push_back(std::move(aNewLine)); } else m_aLines.insert( m_aLines.begin() + _nPos, aNewLine ); diff --git a/sc/source/filter/excel/xichart.cxx b/sc/source/filter/excel/xichart.cxx index dfee9b223864..087e57d4bbdd 100644 --- a/sc/source/filter/excel/xichart.cxx +++ b/sc/source/filter/excel/xichart.cxx @@ -4096,8 +4096,8 @@ void XclImpChChart::ReadChAxesSet( XclImpStream& rStrm ) xAxesSet->ReadRecordGroup( rStrm ); switch( xAxesSet->GetAxesSetId() ) { - case EXC_CHAXESSET_PRIMARY: mxPrimAxesSet = xAxesSet; break; - case EXC_CHAXESSET_SECONDARY: mxSecnAxesSet = xAxesSet; break; + case EXC_CHAXESSET_PRIMARY: mxPrimAxesSet = std::move(xAxesSet); break; + case EXC_CHAXESSET_SECONDARY: mxSecnAxesSet = std::move(xAxesSet); break; } } diff --git a/slideshow/source/engine/transitions/slidechangebase.cxx b/slideshow/source/engine/transitions/slidechangebase.cxx index a04c7bb418bf..ef389f0f4d76 100644 --- a/slideshow/source/engine/transitions/slidechangebase.cxx +++ b/slideshow/source/engine/transitions/slidechangebase.cxx @@ -454,7 +454,7 @@ cppcanvas::CustomSpriteSharedPtr SlideChangeBase::createSprite( double nPrio ) const { // TODO(P2): change to bitmapsprite once that's working - const cppcanvas::CustomSpriteSharedPtr pSprite( + cppcanvas::CustomSpriteSharedPtr pSprite( pView->createSprite( rSpriteSize, nPrio )); diff --git a/svx/source/customshapes/EnhancedCustomShapeFontWork.cxx b/svx/source/customshapes/EnhancedCustomShapeFontWork.cxx index 202415a63c17..17b31a15bb6d 100644 --- a/svx/source/customshapes/EnhancedCustomShapeFontWork.cxx +++ b/svx/source/customshapes/EnhancedCustomShapeFontWork.cxx @@ -165,9 +165,9 @@ static bool InitializeFontWorkData( // retrieving some paragraph attributes const SfxItemSet& rParaSet = rTextObj.GetParaAttribs(aLineParaID[nLine]); aParagraphData.nFrameDirection = rParaSet.Get(EE_PARA_WRITINGDIR).GetValue(); - aTextArea.vParagraphs.push_back(aParagraphData); + aTextArea.vParagraphs.push_back(std::move(aParagraphData)); } - rFWData.vTextAreas.push_back(aTextArea); + rFWData.vTextAreas.push_back(std::move(aTextArea)); nLinesLeft -= nLinesInPara; nTextAreaCount--; } diff --git a/svx/source/sdr/contact/viewobjectcontactofe3dscene.cxx b/svx/source/sdr/contact/viewobjectcontactofe3dscene.cxx index 9b5adea9f15c..f46e8e3a01f5 100644 --- a/svx/source/sdr/contact/viewobjectcontactofe3dscene.cxx +++ b/svx/source/sdr/contact/viewobjectcontactofe3dscene.cxx @@ -99,14 +99,14 @@ namespace sdr::contact if(isPrimitiveGhosted(rDisplayInfo)) { const ::basegfx::BColor aRGBWhite(1.0, 1.0, 1.0); - const ::basegfx::BColorModifierSharedPtr aBColorModifier = + ::basegfx::BColorModifierSharedPtr aBColorModifier = std::make_shared<basegfx::BColorModifier_interpolate>( aRGBWhite, 0.5); const drawinglayer::primitive2d::Primitive2DReference xReference( new drawinglayer::primitive2d::ModifiedColorPrimitive2D( std::move(xRetval), - aBColorModifier)); + std::move(aBColorModifier))); xRetval = drawinglayer::primitive2d::Primitive2DContainer { xReference }; } diff --git a/sw/source/filter/ww8/docxattributeoutput.cxx b/sw/source/filter/ww8/docxattributeoutput.cxx index 156669c65607..9379e06ac660 100644 --- a/sw/source/filter/ww8/docxattributeoutput.cxx +++ b/sw/source/filter/ww8/docxattributeoutput.cxx @@ -1138,8 +1138,7 @@ void DocxAttributeOutput::EndParagraph( const ww8::WW8TableNodeInfoInner::Pointe if (!m_bWritingHeaderFooter && SwTextBoxHelper::TextBoxIsFramePr(rFrameFormat)) { - std::shared_ptr<ww8::Frame> pFramePr = std::make_shared<ww8::Frame>(aFrame); - aFramePrTextbox.push_back(pFramePr); + aFramePrTextbox.push_back(std::make_shared<ww8::Frame>(aFrame)); } else { diff --git a/sw/source/filter/ww8/wrtww8.cxx b/sw/source/filter/ww8/wrtww8.cxx index 5db784261924..b6af01c776bf 100644 --- a/sw/source/filter/ww8/wrtww8.cxx +++ b/sw/source/filter/ww8/wrtww8.cxx @@ -440,7 +440,7 @@ void WW8_WrtFactoids::Write(WW8Export& rExport) aProperty.m_nValue = std::distance(aSet.begin(), aSet.find(rPair.second)); aPropertyBag.m_aProperties.push_back(aProperty); } - aSmartTagData.m_aPropBags.push_back(aPropertyBag); + aSmartTagData.m_aPropBags.push_back(std::move(aPropertyBag)); } aSmartTagData.Write(rExport); commit c7987c472fb228a35adf51c6a42ed8c6161db94a Author: Caolán McNamara <caolan.mcnam...@collabora.com> AuthorDate: Sat Aug 2 16:51:41 2025 +0100 Commit: Caolán McNamara <caolan.mcnam...@collabora.com> CommitDate: Sun Aug 3 12:18:11 2025 +0200 cid#1660426 Variable copied when it could be moved and cid#1660421 Variable copied when it could be moved cid#1660419 Variable copied when it could be moved cid#1660416 Variable copied when it could be moved cid#1660406 Variable copied when it could be moved cid#1660405 Variable copied when it could be moved cid#1660403 Variable copied when it could be moved cid#1660388 Variable copied when it could be moved cid#1660380 Variable copied when it could be moved Change-Id: Ic017abb85bb9b3f9fdb962c0862476f40c0953f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188847 Tested-by: Caolán McNamara <caolan.mcnam...@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnam...@collabora.com> diff --git a/connectivity/source/drivers/evoab2/NDatabaseMetaData.cxx b/connectivity/source/drivers/evoab2/NDatabaseMetaData.cxx index 060c4480bd87..787495933b5e 100644 --- a/connectivity/source/drivers/evoab2/NDatabaseMetaData.cxx +++ b/connectivity/source/drivers/evoab2/NDatabaseMetaData.cxx @@ -1044,7 +1044,7 @@ Reference< XResultSet > OEvoabDatabaseMetaData::impl_getTypeInfo_throw( ) aRow[1] = new ORowSetValueDecorator(u"VARCHAR"_ustr); aRow[2] = new ORowSetValueDecorator(DataType::VARCHAR); aRow[3] = new ORowSetValueDecorator(sal_Int32(65535)); - tmp.push_back(aRow); + tmp.push_back(std::move(aRow)); return tmp; }(); pResultSet->setRows(std::move(aRows)); diff --git a/dbaccess/source/core/dataaccess/ModelImpl.cxx b/dbaccess/source/core/dataaccess/ModelImpl.cxx index 08d8c6a918d9..70bfc66115d7 100644 --- a/dbaccess/source/core/dataaccess/ModelImpl.cxx +++ b/dbaccess/source/core/dataaccess/ModelImpl.cxx @@ -1378,7 +1378,7 @@ bool ODatabaseModelImpl::hasTrustedScriptingSignature( uno::Reference<security::XDocumentDigitalSignatures> xSigner( security::DocumentDigitalSignatures::createWithVersion( comphelper::getProcessComponentContext(), aODFVersion)); - const uno::Sequence<security::DocumentSignatureInformation> aInfo + uno::Sequence<security::DocumentSignatureInformation> aInfo = xSigner->verifyScriptingContentSignatures(xStorage, uno::Reference<io::XInputStream>()); @@ -1400,7 +1400,7 @@ bool ODatabaseModelImpl::hasTrustedScriptingSignature( task::DocumentMacroConfirmationRequest aRequest; aRequest.DocumentURL = m_sDocFileLocation; aRequest.DocumentStorage = std::move(xStorage); - aRequest.DocumentSignatureInformation = aInfo; + aRequest.DocumentSignatureInformation = std::move(aInfo); aRequest.DocumentVersion = aODFVersion; aRequest.Classification = task::InteractionClassification_QUERY; bResult = SfxMedium::CallApproveHandler(_rxInteraction, uno::Any(aRequest), true); diff --git a/sc/source/filter/excel/xicontent.cxx b/sc/source/filter/excel/xicontent.cxx index f81d1f6b3455..f8e64b4ef28f 100644 --- a/sc/source/filter/excel/xicontent.cxx +++ b/sc/source/filter/excel/xicontent.cxx @@ -88,7 +88,7 @@ void XclImpSst::ReadSst( XclImpStream& rStrm ) { XclImpString aString; aString.Read( rStrm ); - maStrings.push_back( aString ); + maStrings.push_back(std::move(aString)); --nStrCount; } } diff --git a/sc/source/ui/drawfunc/drawsh.cxx b/sc/source/ui/drawfunc/drawsh.cxx index e10c8b61afe8..000a4ca1a61e 100644 --- a/sc/source/ui/drawfunc/drawsh.cxx +++ b/sc/source/ui/drawfunc/drawsh.cxx @@ -353,8 +353,7 @@ void ScDrawShell::ExecDrawAttr( SfxRequest& rReq ) SvxAbstractDialogFactory* pFact = SvxAbstractDialogFactory::Create(); VclPtr<SfxAbstractTabDialog> pDlg(pFact->CreateCaptionDialog(pWin ? pWin->GetFrameWeld() : nullptr, pView)); - const WhichRangesContainer aRange = pDlg->GetInputRanges( *aNewAttr.GetPool() ); - SfxItemSet aCombSet( *aNewAttr.GetPool(), aRange ); + SfxItemSet aCombSet(*aNewAttr.GetPool(), pDlg->GetInputRanges(*aNewAttr.GetPool())); aCombSet.Put( aNewAttr ); aCombSet.Put( aNewGeoAttr ); pDlg->SetInputSet( &aCombSet ); diff --git a/sfx2/source/notebookbar/SfxNotebookBar.cxx b/sfx2/source/notebookbar/SfxNotebookBar.cxx index 8bb40710ad26..435e01e34d1b 100644 --- a/sfx2/source/notebookbar/SfxNotebookBar.cxx +++ b/sfx2/source/notebookbar/SfxNotebookBar.cxx @@ -241,7 +241,7 @@ static utl::OConfigurationNode lcl_getCurrentImplConfigNode(const Reference<css: for ( const auto& rModeNodeName : aModeNodeNames ) { - const utl::OConfigurationNode aImplNode( aImplsNode.openNode( rModeNodeName ) ); + utl::OConfigurationNode aImplNode( aImplsNode.openNode( rModeNodeName ) ); if ( !aImplNode.isValid() ) continue; diff --git a/sw/source/uibase/sidebar/WriterInspectorTextPanel.cxx b/sw/source/uibase/sidebar/WriterInspectorTextPanel.cxx index 69fcf18dd4af..a1c46138ad46 100644 --- a/sw/source/uibase/sidebar/WriterInspectorTextPanel.cxx +++ b/sw/source/uibase/sidebar/WriterInspectorTextPanel.cxx @@ -526,7 +526,7 @@ static void InsertValues(const css::uno::Reference<css::uno::XInterface>& rSourc aCurNode.aValue <<= NestedTextContentToText(aCurNode.aValue); } - rNode.children.push_back(aCurNode); + rNode.children.push_back(std::move(aCurNode)); } } @@ -735,17 +735,17 @@ static void UpdateTree(SwDocShell& rDocSh, const SwEditShell& rEditSh, // show sections, bookmarks and fields only if they have RDF metadata if (aTextSectionsNode.children.size() > 0) { - aStore.push_back(aTextSectionsNode); + aStore.push_back(std::move(aTextSectionsNode)); rParIdx++; } if (aBookmarksNode.children.size() > 0) { - aStore.push_back(aBookmarksNode); + aStore.push_back(std::move(aBookmarksNode)); rParIdx++; } if (aFieldsNode.children.size() > 0) { - aStore.push_back(aFieldsNode); + aStore.push_back(std::move(aFieldsNode)); rParIdx++; } aStore.push_back(std::move(aParaNode)); diff --git a/xmlsecurity/source/helper/xsecsign.cxx b/xmlsecurity/source/helper/xsecsign.cxx index f211a9981536..7b9bdaf2daf4 100644 --- a/xmlsecurity/source/helper/xsecsign.cxx +++ b/xmlsecurity/source/helper/xsecsign.cxx @@ -189,7 +189,7 @@ void XSecController::signAStream( sal_Int32 securityId, const OUString& uri, boo { InternalSignatureInformation isi(securityId, nullptr); isi.addReference(type, digestID, uri, -1, OUString()); - m_vInternalSignatureInformations.push_back( isi ); + m_vInternalSignatureInformations.push_back(std::move(isi)); } else { @@ -252,7 +252,7 @@ void XSecController::setGpgCertificate( isi.signatureInfor.ouGpgCertificate = ouCert; isi.signatureInfor.ouGpgOwner = ouOwner; isi.signatureInfor.ouGpgKeyID = ouKeyDigest; - m_vInternalSignatureInformations.push_back( isi ); + m_vInternalSignatureInformations.push_back(std::move(isi)); } else {