include/o3tl/unit_conversion.hxx | 1 -
sal/osl/unx/pipe.cxx | 8 --------
2 files changed, 9 deletions(-)
New commits:
commit 9bf7ca9ac0d818cc7fc9ac094c146fd3c2fcb12d
Author: Caolán McNamara <caolan.mcnam...@collabora.com>
AuthorDate: Sat Aug 9 16:35:15 2025 +0100
Commit: Caolán McNamara <caolan.mcnam...@collabora.com>
CommitDate: Sun Aug 10 20:55:43 2025 +0200
remove these old coverity markups
that we don't seem to need anymore
Change-Id: I91d8ed320dff661e0856a8b47e0741f91a696c97
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189317
Reviewed-by: Caolán McNamara <caolan.mcnam...@collabora.com>
Tested-by: Jenkins
diff --git a/include/o3tl/unit_conversion.hxx b/include/o3tl/unit_conversion.hxx
index 4aba0c988613..de3afccbb817 100644
--- a/include/o3tl/unit_conversion.hxx
+++ b/include/o3tl/unit_conversion.hxx
@@ -104,7 +104,6 @@ constexpr sal_Int64 MulDivSaturate(I n, sal_Int64 m,
sal_Int64 d)
{
if (m > d && std::make_unsigned_t<I>(n) > sal_uInt64(SAL_MAX_INT64
/ m * d - d_2))
return SAL_MAX_INT64; // saturate
- // coverity[ tainted_data_return : FALSE ] version 2023.12.2
return saturating_add<sal_uInt64>(n, d_2) / d * m; // divide
before multiplication
}
else if constexpr (std::is_signed_v<I>) // n < 0; don't compile for
unsigned n
diff --git a/sal/osl/unx/pipe.cxx b/sal/osl/unx/pipe.cxx
index dd29aa6ca168..5b0f374db855 100644
--- a/sal/osl/unx/pipe.cxx
+++ b/sal/osl/unx/pipe.cxx
@@ -215,7 +215,6 @@ static oslPipe osl_psz_createPipe(const char *pszPipeName,
oslPipeOptions Option
}
addr.sun_family = AF_UNIX;
- // coverity[fixed_size_dest : FALSE] - safe, see check above
strcpy(addr.sun_path, name.getStr());
#if defined(FREEBSD)
len = SUN_LEN(&addr);
@@ -261,11 +260,6 @@ static oslPipe osl_psz_createPipe(const char *pszPipeName,
oslPipeOptions Option
if (listen(pPipe->m_Socket, 5) < 0)
{
SAL_WARN("sal.osl.pipe", "listen() failed: " <<
UnixErrnoString(errno));
- // cid#1255391 warns about unlink(name) after stat(name, &status)
- // above, but the intervening call to bind makes those two clearly
- // unrelated, as it would fail if name existed at that point in
- // time:
- // coverity[toctou] - this is bogus
unlink(name.getStr()); /* remove filesystem entry */
close(pPipe->m_Socket);
destroyPipeImpl(pPipe);
@@ -508,7 +502,6 @@ sal_Int32 SAL_CALL osl_writePipe(oslPipe pPipe, const void
*pBuffer, sal_Int32 n
SAL_WARN_IF(!pPipe, "sal.osl.pipe", "osl_writePipe: invalid pipe"); //
osl_sendPipe detects invalid pipe
while (BytesToSend > 0)
{
- // coverity[ tainted_data_return : FALSE ] version 2023.12.2
sal_Int32 RetVal = osl_sendPipe(pPipe, pBuffer, BytesToSend);
/* error occurred? */
if (RetVal <= 0)
@@ -531,7 +524,6 @@ sal_Int32 SAL_CALL osl_readPipe( oslPipe pPipe, void
*pBuffer , sal_Int32 n )
SAL_WARN_IF(!pPipe, "sal.osl.pipe", "osl_readPipe: invalid pipe"); //
osl_receivePipe detects invalid pipe
while (BytesToRead > 0)
{
- // coverity[ tainted_data_return : FALSE ] version 2023.12.2
sal_Int32 RetVal = osl_receivePipe(pPipe, pBuffer, BytesToRead);
/* error occurred? */
if (RetVal <= 0)
