dbaccess/source/core/dataaccess/ModelImpl.cxx | 2 ++
1 file changed, 2 insertions(+)
New commits:
commit 65fe54ec9a1da0e1fc3b77a1a1abd6a6de6e224b
Author: Stephan Bergmann <stephan.bergm...@collabora.com>
AuthorDate: Tue Aug 19 07:37:58 2025 +0200
Commit: Stephan Bergmann <stephan.bergm...@collabora.com>
CommitDate: Tue Aug 19 09:12:20 2025 +0200
Read of uninitialized ODatabaseModelImpl::m_bAskPassword
...during CppunitTest_dbaccess_dialog_save at
> /dbaccess/source/core/dataaccess/databasecontext.cxx:461:66: runtime
error: load of value 190, which is not a valid value for type 'bool'
> #0 0x7f7563a4f478 in
dbaccess::ODatabaseContext::storeTransientProperties(dbaccess::ODatabaseModelImpl&)
/dbaccess/source/core/dataaccess/databasecontext.cxx:461:66
> #1 0x7f7563eb4b06 in dbaccess::ODatabaseModelImpl::release()
/dbaccess/source/core/dataaccess/ModelImpl.cxx:1014:22
> #2 0x7f7563a60ef9 in
rtl::Reference<dbaccess::ODatabaseModelImpl>::~Reference()
/include/rtl/ref.hxx:126:22
> #3 0x7f7563a44db9 in dbaccess::ODatabaseContext::disposing()
/dbaccess/source/core/dataaccess/databasecontext.cxx:254:5
> #4 0x7f75b1c465ab in cppu::WeakComponentImplHelperBase::dispose()
/cppuhelper/source/implbase.cxx:104:13
> #5 0x7f7563a6ffc9 in
cppu::PartialWeakComponentImplHelper<com::sun::star::lang::XServiceInfo,
com::sun::star::sdb::XDatabaseContext>::dispose()
/include/cppuhelper/compbase.hxx:90:36
> #6 0x7f75b1e0a3c2 in
cppuhelper::ServiceManager::disposing(std::unique_lock<std::mutex>&)
/cppuhelper/source/servicemanager.cxx:919:21
> #7 0x7f75b1b2e214 in
cppuhelper::WeakComponentImplHelperBase2::dispose()
/cppuhelper/source/compbase.cxx:27:5
> #8 0x7f75b1bddd29 in
cppuhelper::WeakComponentImplHelper2<com::sun::star::lang::XServiceInfo,
com::sun::star::lang::XMultiServiceFactory,
com::sun::star::lang::XMultiComponentFactory, com::sun::star::container::XSet,
com::sun::star::container::XContentEnumerationAccess,
com::sun::star::beans::XPropertySet, com::sun::star::beans::XPropertySetInfo,
com::sun::star::lang::XEventListener,
com::sun::star::lang::XInitialization>::dispose()
/cppuhelper/inc/compbase2.hxx:87:39
> #9 0x7f75b1b80810 in cppu::try_dispose(std::unique_lock<std::mutex>&,
com::sun::star::uno::Reference<com::sun::star::uno::XInterface> const&)
/cppuhelper/source/component_context.cxx:66:16
> #10 0x7f75b1b69605 in cppu::(anonymous
namespace)::ComponentContext::disposing(std::unique_lock<std::mutex>&)
/cppuhelper/source/component_context.cxx:430:5
> #11 0x7f75b1b2e214 in
cppuhelper::WeakComponentImplHelperBase2::dispose()
/cppuhelper/source/compbase.cxx:27:5
> #12 0x7f75b1b9c669 in
cppuhelper::WeakComponentImplHelper2<com::sun::star::uno::XComponentContext,
com::sun::star::container::XNameContainer>::dispose()
/cppuhelper/inc/compbase2.hxx:87:39
> #13 0x7f75a719ea7c in (anonymous
namespace)::Hook::deinitHook((anonymous namespace)::Hook*, LinkParamNone*)
/test/source/setupvcl.cxx:67:46
> #14 0x7f75a719df94 in (anonymous
namespace)::Hook::LinkStubdeinitHook(void*, LinkParamNone*)
/test/source/setupvcl.cxx:37:1
> #15 0x7f7597d6104d in Link<LinkParamNone*,
void>::Call(LinkParamNone*) const /include/tools/link.hxx:105:45
> #16 0x7f759b87c56e in DeInitVCL() /vcl/source/app/svmain.cxx:532:35
> #17 0x7f75bb739454 in (anonymous namespace)::Protector::~Protector()
/test/source/vclbootstrapprotector.cxx:29:9
> #18 0x7f75bb739538 in (anonymous namespace)::Protector::~Protector()
/test/source/vclbootstrapprotector.cxx:28:35
> #19 0x7f75bb2484f3 in CppUnit::ProtectorChain::pop()
(/workdir/UnpackedTarball/cppunit/src/cppunit/.libs/libcppunit-1.15.so.1+0x2de4f3)
> #20 0x7f75bb2f16ad in CppUnit::TestResult::popProtector()
(/workdir/UnpackedTarball/cppunit/src/cppunit/.libs/libcppunit-1.15.so.1+0x3876ad)
> #21 0x50ac01 in (anonymous namespace)::ProtectedFixtureFunctor::run()
const /sal/cppunittester/cppunittester.cxx:337:20
> #22 0x506d13 in main2() /sal/cppunittester/cppunittester.cxx:482:16
> #23 0x50512f in sal_main() /sal/cppunittester/cppunittester.cxx:627:14
> #24 0x504f6e in main /sal/cppunittester/cppunittester.cxx:622:1
(<https://ci.libreoffice.org/job/lo_ubsan/3655/>), reading a member recently
introduced in 04d2a7d2f6a20bc69b7876e9c502c627e83e9f8f "tdf#167960 The
password
of an unknown user is no longer stored", the initial value of which should
presumably be false
Change-Id: Ib46f6f37776688a9853d136adab99263714f0aba
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189894
Tested-by: Jenkins
Reviewed-by: Pierre Vacher <prrv...@gmail.com>
Reviewed-by: Stephan Bergmann <stephan.bergm...@collabora.com>
diff --git a/dbaccess/source/core/dataaccess/ModelImpl.cxx
b/dbaccess/source/core/dataaccess/ModelImpl.cxx
index 70bfc66115d7..9b8a1f81cc33 100644
--- a/dbaccess/source/core/dataaccess/ModelImpl.cxx
+++ b/dbaccess/source/core/dataaccess/ModelImpl.cxx
@@ -367,6 +367,7 @@ ODatabaseModelImpl::ODatabaseModelImpl( const Reference<
XComponentContext >& _r
,m_bModified(false)
,m_bDocumentReadOnly(false)
,m_bMacroCallsSeenWhileLoading(false)
+ ,m_bAskPassword(false)
,m_nControllerLockCount(0)
{
// some kind of default
@@ -397,6 +398,7 @@ ODatabaseModelImpl::ODatabaseModelImpl(
,m_bModified(false)
,m_bDocumentReadOnly(false)
,m_bMacroCallsSeenWhileLoading(false)
+ ,m_bAskPassword(false)
,m_nControllerLockCount(0)
{
impl_construct_nothrow();
