core.git: sax/source

[Caolán McNamara (via logerrit)]

 sax/source/tools/converter.cxx |   15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)

New commits:
commit 9c73fcad3779c6ae83f7c04ecaa8cbce79b2e660
Author:     Caolán McNamara <caolan.mcnam...@collabora.com>
AuthorDate: Sun Aug 31 21:05:02 2025 +0100
Commit:     Caolán McNamara <caolan.mcnam...@collabora.com>
CommitDate: Tue Sep 2 16:22:37 2025 +0200

    cid#1660010 silence Overflowed constant
    
    Change-Id: I8b02798e933404737711bbf776917a9d406d42a6
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190519
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolan.mcnam...@collabora.com>

diff --git a/sax/source/tools/converter.cxx b/sax/source/tools/converter.cxx
index 162b9427ad30..99b5482818b6 100644
--- a/sax/source/tools/converter.cxx
+++ b/sax/source/tools/converter.cxx
@@ -1544,20 +1544,19 @@ static bool convertDurationHelper(util::Duration& 
rDuration, V string)
 
     if (bSuccess)
     {
-        bSuccess = nYears >= std::numeric_limits<sal_Int16>::min() &&
-                   nYears <= std::numeric_limits<sal_Int16>::max();
+        bSuccess = nYears >= 0 && nYears <= 
std::numeric_limits<sal_uInt16>::max();
         SAL_WARN_IF(!bSuccess, "sax", "convertDurationHelper: year overflow: " 
<< nYears);
     }
 
     if (bSuccess)
     {
         rDuration.Negative      = bIsNegativeDuration;
-        rDuration.Years         = static_cast<sal_Int16>(nYears);
-        rDuration.Months        = static_cast<sal_Int16>(nMonths);
-        rDuration.Days          = static_cast<sal_Int16>(nDays);
-        rDuration.Hours         = static_cast<sal_Int16>(nHours);
-        rDuration.Minutes       = static_cast<sal_Int16>(nMinutes);
-        rDuration.Seconds       = static_cast<sal_Int16>(nSeconds);
+        rDuration.Years         = static_cast<sal_uInt16>(nYears);
+        rDuration.Months        = static_cast<sal_uInt16>(nMonths);
+        rDuration.Days          = static_cast<sal_uInt16>(nDays);
+        rDuration.Hours         = static_cast<sal_uInt16>(nHours);
+        rDuration.Minutes       = static_cast<sal_uInt16>(nMinutes);
+        rDuration.Seconds       = static_cast<sal_uInt16>(nSeconds);
         rDuration.NanoSeconds   = nNanoSeconds;
     }