chart2/source/tools/ChartColorPalettes.cxx | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
New commits:
commit 42ee3c9a71f232d6265445f4d41d2f5a4012fde4
Author: Michael Weghorn <m.wegh...@posteo.de>
AuthorDate: Tue Sep 2 12:17:35 2025 +0200
Commit: Michael Weghorn <m.wegh...@posteo.de>
CommitDate: Wed Sep 3 22:56:47 2025 +0200
chart color palettes: No longer show palette names
commit a26c93a6305bed437ab505713950858893db519d
Date: Sun Aug 10 22:33:37 2025 +0200
chart color palettes: switch from drawingarea to IconView
had switched to using weld::IconView for the color
palettes and added setting a text, "Palette <number>"
for each of the palettes. The text was only displayed
for the VCL/non-gtk implementation, however.
Showing the text for gtk3 as well could be implemented
by adding a corresponding model column (see implementation
in earlier change set 1 of this Gerrit change, [1])
As Marco Cecchetti mentions in [2]:
> Anyway, I think more appropriate to remove the name
> in both cases since it's not descriptive and especially
> in the sidebar case it ends up just wasting space.
> Maybe you could set only for the a11y description.
Previous commit
Change-Id: I641afe5b54055e91048fec111751f0ba3dafbea0
Author: Michael Weghorn <m.wegh...@posteo.de>
Date: Fri Aug 29 13:43:40 2025 +0200
a11y: Set a11y name for chart color palettes
implemented explicitly setting the a11y name to the
string that was previously set as the display text,
so the VCL fallback to use the display text for the
a11y name is no longer needed.
Therefore, drop the displayed text as suggested.
Sample steps to see the corresponding dialog page:
* start Writer
* click the "Insert Chart" toolbar item to insert
a chart
* double-click on a bar in the chart
* switch to the "Color Palette" tab page
[1] https://gerrit.libreoffice.org/c/core/+/190367/1
[2]
https://gerrit.libreoffice.org/c/core/+/190367/comments/d4b582df_0cc820cc
Change-Id: I5242219df6049ce8b6e99148d30cc9ea95485658
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190367
Tested-by: Jenkins
Reviewed-by: Marco Cecchetti <marco.cecche...@collabora.com>
diff --git a/chart2/source/tools/ChartColorPalettes.cxx
b/chart2/source/tools/ChartColorPalettes.cxx
index c63bce1ae2bb..e33d24a67cca 100644
--- a/chart2/source/tools/ChartColorPalettes.cxx
+++ b/chart2/source/tools/ChartColorPalettes.cxx
@@ -94,7 +94,7 @@ void ChartColorPalettes::Fill()
OUString sName = "Palette " + OUString::number(i + 1);
Bitmap aBitmap(pVDev->GetBitmap(Point(0, 0),
pVDev->GetOutputSizePixel()));
- mxIconView->insert(-1, &sName, &sId, &aBitmap, nullptr);
+ mxIconView->insert(-1, nullptr, &sId, &aBitmap, nullptr);
mxIconView->set_item_accessible_name(i, sName);
}
commit cee9cf5fefecada1e692356183206095f55b06e2
Author: Michael Weghorn <m.wegh...@posteo.de>
AuthorDate: Fri Aug 29 13:43:40 2025 +0200
Commit: Michael Weghorn <m.wegh...@posteo.de>
CommitDate: Wed Sep 3 22:56:32 2025 +0200
a11y: Set a11y name for chart color palettes
commit a26c93a6305bed437ab505713950858893db519d
Date: Sun Aug 10 22:33:37 2025 +0200
chart color palettes: switch from drawingarea to IconView
had switched to using weld::IconView for the color
palettes.
Other than for the vcl IconView implementation, the gtk3
one does not use an item text for the accessible name
if no a11y name is explicitly set (even if an item text
were set, which is currently not the case for gtk3),
resulting in the Orca screen reader only announcing "icon"
when an item receives focus.
Explicitly set the accessible name for each item to the
same as the text set for the VCL variant to ensure an
a11y name is always set.
This now makes Orca e.g. announce "Palette 1, icon" when
that palette/item receives focus when using the gtk3
VCL plugin.
Sample steps to see the corresponding dialog page:
* start Writer
* click the "Insert Chart" toolbar item to insert
a chart
* double-click on a bar in the chart
* switch to the "Color Palette" tab page
Change-Id: I641afe5b54055e91048fec111751f0ba3dafbea0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190368
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.wegh...@posteo.de>
diff --git a/chart2/source/tools/ChartColorPalettes.cxx
b/chart2/source/tools/ChartColorPalettes.cxx
index 6958d0c096f3..c63bce1ae2bb 100644
--- a/chart2/source/tools/ChartColorPalettes.cxx
+++ b/chart2/source/tools/ChartColorPalettes.cxx
@@ -95,6 +95,7 @@ void ChartColorPalettes::Fill()
Bitmap aBitmap(pVDev->GetBitmap(Point(0, 0),
pVDev->GetOutputSizePixel()));
mxIconView->insert(-1, &sName, &sId, &aBitmap, nullptr);
+ mxIconView->set_item_accessible_name(i, sName);
}
mxIconView->thaw();
