include/vcl/weld.hxx | 2 -- vcl/inc/qt5/QtInstanceComboBox.hxx | 1 - vcl/inc/qt5/QtInstanceEntryTreeView.hxx | 1 - vcl/inc/salvtables.hxx | 7 ------- vcl/qt5/QtInstanceComboBox.cxx | 6 ------ vcl/qt5/QtInstanceEntryTreeView.cxx | 5 ----- vcl/source/app/salvtables.cxx | 5 ----- vcl/unx/gtk3/gtkinst.cxx | 15 --------------- 8 files changed, 42 deletions(-)
New commits: commit 8472f70312939b2d806563f4b607e20048621c69 Author: Noel Grandin <noel.gran...@collabora.co.uk> AuthorDate: Thu Sep 4 11:00:48 2025 +0200 Commit: Noel Grandin <noel.gran...@collabora.co.uk> CommitDate: Thu Sep 4 15:03:09 2025 +0200 create_render_virtual_device is unused since commit 3275aca2e8eb44d7c167541e86455f50dae204b3 Author: Noel Grandin <noel.gran...@collabora.co.uk> Date: Thu Aug 21 17:14:36 2025 +0200 tdf#167812 Calc in Dark mode: font dropdown shows white rectangles (GTK3) Change-Id: I88078d712d82e41deaa4995eeb9ba6b6c66bc25e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190577 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.gran...@collabora.co.uk> diff --git a/include/vcl/weld.hxx b/include/vcl/weld.hxx index f788b47ffe4f..12ec8384e1aa 100644 --- a/include/vcl/weld.hxx +++ b/include/vcl/weld.hxx @@ -919,8 +919,6 @@ public: void connect_custom_render(const Link<render_args, void>& rLink) { m_aRenderHdl = rLink; } // call set_custom_renderer after setting custom callbacks virtual void set_custom_renderer(bool bOn) = 0; - // create a virtual device compatible with the device passed in render_args wrt alpha - virtual VclPtr<VirtualDevice> create_render_virtual_device() const = 0; // set a sub menu for a entry, only works with custom rendering virtual void set_item_menu(const OUString& rIdent, weld::Menu* pMenu) = 0; // get the width needed to show the menu launcher in a custom row diff --git a/vcl/inc/qt5/QtInstanceComboBox.hxx b/vcl/inc/qt5/QtInstanceComboBox.hxx index 15c91eb20915..d73a08534be6 100644 --- a/vcl/inc/qt5/QtInstanceComboBox.hxx +++ b/vcl/inc/qt5/QtInstanceComboBox.hxx @@ -72,7 +72,6 @@ public: virtual bool get_popup_shown() const override; virtual void set_custom_renderer(bool bOn) override; - virtual VclPtr<VirtualDevice> create_render_virtual_device() const override; virtual void set_item_menu(const OUString& rIdent, weld::Menu* pMenu) override; virtual int get_menu_button_width() const override; diff --git a/vcl/inc/qt5/QtInstanceEntryTreeView.hxx b/vcl/inc/qt5/QtInstanceEntryTreeView.hxx index 7ce03edc2512..1b889c55ad16 100644 --- a/vcl/inc/qt5/QtInstanceEntryTreeView.hxx +++ b/vcl/inc/qt5/QtInstanceEntryTreeView.hxx @@ -35,7 +35,6 @@ public: virtual void make_sorted() override; virtual bool changed_by_direct_pick() const override; virtual void set_entry_completion(bool bEnable, bool bCaseSensitive = false) override; - virtual VclPtr<VirtualDevice> create_render_virtual_device() const override; virtual bool eventFilter(QObject* pObject, QEvent* pEvent) override; diff --git a/vcl/inc/salvtables.hxx b/vcl/inc/salvtables.hxx index 7670bbc16614..c667cc17b93a 100644 --- a/vcl/inc/salvtables.hxx +++ b/vcl/inc/salvtables.hxx @@ -885,13 +885,6 @@ public: } } - VclPtr<VirtualDevice> create_render_virtual_device() const override - { - auto xRet = VclPtr<VirtualDevice>::Create(); - xRet->SetBackground(Application::GetSettings().GetStyleSettings().GetFieldColor()); - return xRet; - } - virtual void set_item_menu(const OUString& rIdent, weld::Menu* pMenu) override { SalInstanceMenu* pInstanceMenu = dynamic_cast<SalInstanceMenu*>(pMenu); diff --git a/vcl/qt5/QtInstanceComboBox.cxx b/vcl/qt5/QtInstanceComboBox.cxx index 405f6268def1..68699ef4e205 100644 --- a/vcl/qt5/QtInstanceComboBox.cxx +++ b/vcl/qt5/QtInstanceComboBox.cxx @@ -341,12 +341,6 @@ bool QtInstanceComboBox::get_popup_shown() const void QtInstanceComboBox::set_custom_renderer(bool) { assert(false && "Not implemented yet"); } -VclPtr<VirtualDevice> QtInstanceComboBox::create_render_virtual_device() const -{ - assert(false && "Not implemented yet"); - return nullptr; -} - void QtInstanceComboBox::set_item_menu(const OUString&, weld::Menu*) { assert(false && "Not implemented yet"); diff --git a/vcl/qt5/QtInstanceEntryTreeView.cxx b/vcl/qt5/QtInstanceEntryTreeView.cxx index ece912b845ef..d11ace8f5ee3 100644 --- a/vcl/qt5/QtInstanceEntryTreeView.cxx +++ b/vcl/qt5/QtInstanceEntryTreeView.cxx @@ -66,11 +66,6 @@ void QtInstanceEntryTreeView::set_entry_completion(bool bEnable, bool bCaseSensi }); } -VclPtr<VirtualDevice> QtInstanceEntryTreeView::create_render_virtual_device() const -{ - return create_virtual_device(); -} - bool QtInstanceEntryTreeView::eventFilter(QObject* pObject, QEvent* pEvent) { if (pObject != m_pLineEdit) diff --git a/vcl/source/app/salvtables.cxx b/vcl/source/app/salvtables.cxx index d03373b7a96c..813b7ceb78e0 100644 --- a/vcl/source/app/salvtables.cxx +++ b/vcl/source/app/salvtables.cxx @@ -6861,11 +6861,6 @@ public: virtual bool changed_by_direct_pick() const override { return m_bTreeChange; } - VclPtr<VirtualDevice> create_render_virtual_device() const override - { - return VclPtr<VirtualDevice>::Create(); - } - virtual ~SalInstanceEntryTreeView() override { Edit& rEntry = m_pEntry->getEntry(); diff --git a/vcl/unx/gtk3/gtkinst.cxx b/vcl/unx/gtk3/gtkinst.cxx index dffa5e3848b2..50b254518221 100644 --- a/vcl/unx/gtk3/gtkinst.cxx +++ b/vcl/unx/gtk3/gtkinst.cxx @@ -20871,11 +20871,6 @@ public: return signal_custom_get_size(rOutput); } - VclPtr<VirtualDevice> create_render_virtual_device() const override - { - return create_virtual_device(); - } - virtual void set_item_menu(const OUString& rIdent, weld::Menu* pMenu) override { #if 0 @@ -22769,11 +22764,6 @@ public: return signal_custom_get_size(rOutput); } - VclPtr<VirtualDevice> create_render_virtual_device() const override - { - return create_virtual_device(); - } - virtual void set_item_menu(const OUString& rIdent, weld::Menu* pMenu) override { m_xCustomMenuButtonHelper.reset(); @@ -23147,11 +23137,6 @@ public: return m_bTreeChange; } - VclPtr<VirtualDevice> create_render_virtual_device() const override - { - return create_virtual_device(); - } - virtual ~GtkInstanceEntryTreeView() override { if (m_nAutoCompleteIdleId)