Hi, On Wed, Sep 10, 2025 at 8:56 AM Miklos Vajna <[email protected]> wrote: > > Hi Regina, > > On Tue, Sep 09, 2025 at 09:00:59PM +0200, Regina Henschel > <[email protected]> wrote: > > I have added a unit test in https://gerrit.libreoffice.org/c/core/+/190622 > > > > But I'm not really happy with the location. The test doesn't include > > anything about filters. Starting a new test suite? Or where to place it? The > > test uses createScDoc(), getScDoc() and getScDoShell() from ScModelTestBase.
> At least in Writer, I regularly start new suites simply matching the > changed code location. This is helpful, because in case you change > something in e.g. sw/source/core/doc/, then you can run > CppunitTest_sw_core_doc quickly, and that will provide a fast (but of > course incomplete) feedback on your code change. > > So one option is that you start a new CppunitTest_sc_core_data suite. I wouldn't create a new bucket test suite where unspecified tests can go in. I would create a new test suite that is named after the general functionality it's testing. This looks to me similar to CppunitTest_sc_copypaste - not filter specific but uses test files to setup the test case (unlike CppunitTest_sc_ucalc* tests), so I would create a new test suite names like CppunitTest_sc_sort or similar. There is also already CppunitTest_sc_ucalc_sort - maybe it's possible to add the initial values manually without having a test file? Surely there are already tests that can be reused there.. Best Regards, Tomaž
