compilerplugins/clang/unusedfields.cxx | 3 +++ drawinglayer/source/processor3d/baseprocessor3d.cxx | 3 --- include/drawinglayer/processor3d/baseprocessor3d.hxx | 5 ----- include/oox/drawingml/chart/chartconverter.hxx | 1 - 4 files changed, 3 insertions(+), 9 deletions(-)
New commits: commit 98a41e2c7b55473d1fdf75803caa1a00b00cd640 Author: Noel Grandin <[email protected]> AuthorDate: Mon Sep 29 11:40:33 2025 +0200 Commit: Noel Grandin <[email protected]> CommitDate: Mon Sep 29 14:14:41 2025 +0200 loplugin:unnecessaryvirtual Change-Id: Ifdd8b4c156d9d4a14e76b51c22cf915ef0b0237e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191609 Tested-by: Jenkins Reviewed-by: Noel Grandin <[email protected]> diff --git a/drawinglayer/source/processor3d/baseprocessor3d.cxx b/drawinglayer/source/processor3d/baseprocessor3d.cxx index 7fd2a80a9988..27bcd7ca12aa 100644 --- a/drawinglayer/source/processor3d/baseprocessor3d.cxx +++ b/drawinglayer/source/processor3d/baseprocessor3d.cxx @@ -65,9 +65,6 @@ namespace drawinglayer::processor3d { // set if changed maViewInformation3D = rNew; - - // allow reaction on change - onViewInformation3DChanged(); } } } // end of namespace diff --git a/include/drawinglayer/processor3d/baseprocessor3d.hxx b/include/drawinglayer/processor3d/baseprocessor3d.hxx index 8aba861176cd..98802e5c744d 100644 --- a/include/drawinglayer/processor3d/baseprocessor3d.hxx +++ b/include/drawinglayer/processor3d/baseprocessor3d.hxx @@ -41,11 +41,6 @@ namespace drawinglayer::processor3d geometry::ViewInformation3D maViewInformation3D; protected: - /* callback method to allow the implementations to react on changes - to the current ViewInformation2D if needed - */ - virtual void onViewInformation3DChanged() {} - /* as tooling, the process() implementation takes over API handling and calls this virtual render method when the primitive implementation is BasePrimitive3D-based. Default implementation does nothing diff --git a/include/oox/drawingml/chart/chartconverter.hxx b/include/oox/drawingml/chart/chartconverter.hxx index 1f41f386988b..0e97752d5f22 100644 --- a/include/oox/drawingml/chart/chartconverter.hxx +++ b/include/oox/drawingml/chart/chartconverter.hxx @@ -102,7 +102,6 @@ class OOX_DLLPUBLIC ChartStyleConverter { public: explicit ChartStyleConverter() = default; - virtual ~ChartStyleConverter() = default; /** Converts the passed ChartStyleModel to the passed chart2 XChartStyle. commit 48531fbeb21b693dae5f14e585f615e3ca8bcac5 Author: Noel Grandin <[email protected]> AuthorDate: Mon Sep 29 10:27:50 2025 +0200 Commit: Noel Grandin <[email protected]> CommitDate: Mon Sep 29 14:14:32 2025 +0200 loplugin:unusedfields fix crash on assert ignore AST that will trigger an assert inside clang Change-Id: I6b5b1e91ac34fb54e152e007af0390e5e3affca7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191594 Tested-by: Jenkins Reviewed-by: Noel Grandin <[email protected]> diff --git a/compilerplugins/clang/unusedfields.cxx b/compilerplugins/clang/unusedfields.cxx index 76e41a8db5c9..0a0cf161a9be 100644 --- a/compilerplugins/clang/unusedfields.cxx +++ b/compilerplugins/clang/unusedfields.cxx @@ -317,6 +317,9 @@ bool UnusedFields::isSomeKindOfZero(const Expr* arg) if (isa<UnaryExprOrTypeTraitExpr>(arg)) { return false; } + // this will trigger an assert inside clang + if (arg->isValueDependent()) + return false; if (auto cxxConstructExpr = dyn_cast<CXXConstructExpr>(arg)) { return cxxConstructExpr->getConstructor()->isDefaultConstructor(); }
