cui/source/dialogs/AdditionsDialog.cxx | 2 +- cui/source/inc/AdditionsDialog.hxx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
New commits: commit a6711c16f66fe509ea20d6a1da24d6e8ecc4f5a6 Author: Michael Weghorn <[email protected]> AuthorDate: Mon Oct 6 15:16:02 2025 +0200 Commit: Michael Weghorn <[email protected]> CommitDate: Mon Oct 6 19:07:14 2025 +0200 additions dialog: Use unique_ptr instead of shared_ptr The items are uniquely owned by AdditionsDialog, so there's no need to use shared_ptr. Change-Id: I13c523bcbdd2600cb84de279837121c00043664b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191965 Tested-by: Jenkins Reviewed-by: Michael Weghorn <[email protected]> diff --git a/cui/source/dialogs/AdditionsDialog.cxx b/cui/source/dialogs/AdditionsDialog.cxx index f89f545da555..d5d6d5c338b7 100644 --- a/cui/source/dialogs/AdditionsDialog.cxx +++ b/cui/source/dialogs/AdditionsDialog.cxx @@ -298,7 +298,7 @@ void SearchAndParseThread::Append(AdditionInfo& additionInfo) SolarMutexGuard aGuard; - m_pAdditionsDialog->m_aAdditionsItems.push_back(std::make_shared<AdditionsItem>( + m_pAdditionsDialog->m_aAdditionsItems.push_back(std::make_unique<AdditionsItem>( m_pAdditionsDialog->m_xContentGrid.get(), m_pAdditionsDialog, additionInfo)); AdditionsItem& rCurrentItem = *m_pAdditionsDialog->m_aAdditionsItems.back(); diff --git a/cui/source/inc/AdditionsDialog.hxx b/cui/source/inc/AdditionsDialog.hxx index 604e16e7465b..e323669ee7b5 100644 --- a/cui/source/inc/AdditionsDialog.hxx +++ b/cui/source/inc/AdditionsDialog.hxx @@ -67,7 +67,7 @@ public: css::uno::Reference<css::deployment::XExtensionManager> m_xExtensionManager; std::unique_ptr<weld::Entry> m_xEntrySearch; std::unique_ptr<weld::Button> m_xButtonClose; - std::vector<std::shared_ptr<AdditionsItem>> m_aAdditionsItems; // UI components + std::vector<std::unique_ptr<AdditionsItem>> m_aAdditionsItems; // UI components std::vector<AdditionInfo> m_aAllExtensionsVector; // Stores the all extensions' info std::unique_ptr<weld::ScrolledWindow> m_xContentWindow;
