sc/source/filter/excel/xiescher.cxx | 2 +- sw/source/ui/misc/bookmark.cxx | 4 ---- 2 files changed, 1 insertion(+), 5 deletions(-)
New commits: commit 5fe4bbad7aaaa65faab7c96f6bce820790e70dec Author: Noel Grandin <[email protected]> AuthorDate: Wed Nov 19 16:16:30 2025 +0200 Commit: Noel Grandin <[email protected]> CommitDate: Wed Nov 19 21:10:00 2025 +0100 unused local variable ever since commit 56b124c36cff09257d8373aaa6661a88cfb1926d Author: Heiko Tietze <[email protected]> Date: Thu Nov 7 16:19:36 2019 +0100 Resolves tdf#128521 - illegal char in a bookmark name Change-Id: I83526dca1e38fe9d5e2eb7e2ecb3e5ad189913b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194208 Reviewed-by: Noel Grandin <[email protected]> Tested-by: Jenkins diff --git a/sw/source/ui/misc/bookmark.cxx b/sw/source/ui/misc/bookmark.cxx index 69a7c57af1d5..0bcc1b060fa5 100644 --- a/sw/source/ui/misc/bookmark.cxx +++ b/sw/source/ui/misc/bookmark.cxx @@ -53,14 +53,10 @@ IMPL_LINK_NOARG(SwInsertBookmarkDlg, ModifyHdl, weld::Entry&, void) // there may be illegal characters in the box // sanitization OUString sTmp = m_xEditBox->get_text(); - OUString sMsg; const sal_Int32 nLen = sTmp.getLength(); for (sal_Int32 i = 0; i < BookmarkTable::aForbiddenChars.getLength(); i++) { - const sal_Int32 nTmpLen = sTmp.getLength(); sTmp = sTmp.replaceAll(OUStringChar(BookmarkTable::aForbiddenChars.getStr()[i]), ""); - if (sTmp.getLength() != nTmpLen) - sMsg += OUStringChar(BookmarkTable::aForbiddenChars.getStr()[i]); } const bool bHasForbiddenChars = sTmp.getLength() != nLen; m_xForbiddenChars->set_visible(bHasForbiddenChars); commit cb066c36e526e36e19385d5f24f56f98688e2776 Author: Noel Grandin <[email protected]> AuthorDate: Wed Nov 19 15:15:57 2025 +0200 Commit: Noel Grandin <[email protected]> CommitDate: Wed Nov 19 21:09:51 2025 +0100 += operator makes no sense here because we have just verified that the variable is empty Change-Id: Ia04a3572e9932308061c2793ca2ee88e7536937e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194205 Reviewed-by: Noel Grandin <[email protected]> Tested-by: Jenkins diff --git a/sc/source/filter/excel/xiescher.cxx b/sc/source/filter/excel/xiescher.cxx index 2b55fbce4ca3..edcaf3d82bc4 100644 --- a/sc/source/filter/excel/xiescher.cxx +++ b/sc/source/filter/excel/xiescher.cxx @@ -4118,7 +4118,7 @@ void XclImpDrawing::ApplyGroupBoxes() sGroupName = rGroupBox.second->GetObjName(); if (sGroupName.isEmpty()) - sGroupName += "autoGroup_" + OUString::number(rGroupBox.second->GetObjId()); + sGroupName = "autoGroup_" + OUString::number(rGroupBox.second->GetObjId()); // I ASSUME the smallest box wins in MS Word. (otherwise first? last?) break; }
