chart2/qa/extras/chart2export2.cxx | 62 ------------------------------------- chart2/qa/extras/chart2export3.cxx | 12 ------- 2 files changed, 74 deletions(-)
New commits: commit b4fa0cef2700ae8ca4d94f173a47269ce9e9035c Author: Xisco Fauli <[email protected]> AuthorDate: Mon Nov 24 17:47:28 2025 +0100 Commit: Xisco Fauli <[email protected]> CommitDate: Tue Nov 25 09:56:39 2025 +0100 chart2_export3: drop some skipValidation Change-Id: I6881bc355b026ad01afd2126ac80fb52d8161d70 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194475 Tested-by: Jenkins Code-Style: Xisco Fauli <[email protected]> Reviewed-by: Xisco Fauli <[email protected]> diff --git a/chart2/qa/extras/chart2export3.cxx b/chart2/qa/extras/chart2export3.cxx index 2022bffe7f1c..8bf0d154d9a5 100644 --- a/chart2/qa/extras/chart2export3.cxx +++ b/chart2/qa/extras/chart2export3.cxx @@ -28,9 +28,6 @@ CPPUNIT_TEST_FIXTURE(Chart2ExportTest3, testTdf108107) { loadFromFile(u"xlsx/tdf108107.xlsx"); - // FIXME: validation error in OOXML export: Errors: 1 - skipValidation(); - save(TestFilter::XLSX); xmlDocUniquePtr pXmlDoc = parseExport(u"xl/charts/chart1.xml"_ustr); CPPUNIT_ASSERT(pXmlDoc); @@ -174,9 +171,6 @@ CPPUNIT_TEST_FIXTURE(Chart2ExportTest3, testFdo83058dlblPos) { loadFromFile(u"docx/fdo83058_dlblPos.docx"); - // FIXME: validation error in OOXML export: Errors: 1 - skipValidation(); - save(TestFilter::DOCX); xmlDocUniquePtr pXmlDoc = parseExport(u"word/charts/chart1.xml"_ustr); CPPUNIT_ASSERT(pXmlDoc); @@ -238,9 +232,6 @@ CPPUNIT_TEST_FIXTURE(Chart2ExportTest3, testAxisNumberFormatXLSX) CPPUNIT_TEST_FIXTURE(Chart2ExportTest3, testDataPointLabelNumberFormatXLSX) { - // FIXME: validation error in OOXML export: Errors: 1 - skipValidation(); - loadFromFile(u"ods/tdf123774.ods"); { save(TestFilter::XLSX); @@ -602,9 +593,6 @@ CPPUNIT_TEST_FIXTURE(Chart2ExportTest3, testTableOnPage3) { loadFromFile(u"docx/TableOnPage3.docx"); - // FIXME: validation error in OOXML export: Errors: 2 - skipValidation(); - saveAndReload(TestFilter::DOCX); Reference<chart2::XChartDocument> xChartDoc(getChartDocFromWriter(0), uno::UNO_QUERY); commit 0e03600841d21b3b7af8a917cf03a9e6a024a007 Author: Xisco Fauli <[email protected]> AuthorDate: Mon Nov 24 17:41:52 2025 +0100 Commit: Xisco Fauli <[email protected]> CommitDate: Tue Nov 25 09:56:25 2025 +0100 chart2_export2: drop some skipValidation Change-Id: I6fad620e23ba8773e3385c67dba3a12915137c32 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194474 Tested-by: Jenkins Reviewed-by: Xisco Fauli <[email protected]> Code-Style: Xisco Fauli <[email protected]> diff --git a/chart2/qa/extras/chart2export2.cxx b/chart2/qa/extras/chart2export2.cxx index 8295da0c19b2..5bcaaf5e09ae 100644 --- a/chart2/qa/extras/chart2export2.cxx +++ b/chart2/qa/extras/chart2export2.cxx @@ -109,9 +109,6 @@ CPPUNIT_TEST_FIXTURE(Chart2ExportTest2, testCombinedChartSecondaryAxisODS) CPPUNIT_TEST_FIXTURE(Chart2ExportTest2, testCrossBetweenXLSX) { - // FIXME: validation error in OOXML export: Errors: 1 - skipValidation(); - // Original files were created with MS Office { loadFromFile(u"xlsx/tdf127777.xlsx"); @@ -230,9 +227,6 @@ CPPUNIT_TEST_FIXTURE(Chart2ExportTest2, testAxisCrossBetweenDOCX) { loadFromFile(u"odt/axis-position.odt"); - // FIXME: validation error in OOXML export: Errors: 3 - skipValidation(); - save(TestFilter::DOCX); xmlDocUniquePtr pXmlDoc = parseExport(u"word/charts/chart1.xml"_ustr); assertXPath(pXmlDoc, "(//c:crossBetween)[1]", "val", u"midCat"); @@ -405,9 +399,6 @@ CPPUNIT_TEST_FIXTURE(Chart2ExportTest2, testDataSeriesName) CPPUNIT_TEST_FIXTURE(Chart2ExportTest2, testCustomPositionofDataLabel) { - // FIXME: validation error in OOXML export: Errors: 1 - skipValidation(); - loadFromFile(u"xlsx/testCustomPosDataLabels.xlsx"); { save(TestFilter::XLSX); @@ -480,9 +471,6 @@ CPPUNIT_TEST_FIXTURE(Chart2ExportTest2, testCustomPositionofDataLabel) CPPUNIT_TEST_FIXTURE(Chart2ExportTest2, testTdf161571PiechartCustomPosDataLabels) { - // FIXME: validation error in OOXML export - skipValidation(); - loadFromFile(u"xlsx/tdf161607PieChartLeaderLinesColorWidth.xlsx"); save(TestFilter::XLSX); xmlDocUniquePtr pXmlDoc = parseExport(u"xl/charts/chart1.xml"_ustr); @@ -571,9 +559,6 @@ CPPUNIT_TEST_FIXTURE(Chart2ExportTest2, testCustomDataLabelMultipleSeries) CPPUNIT_TEST_FIXTURE(Chart2ExportTest2, testLeaderLines) { - // FIXME: validation error in OOXML export: Errors: 2 - skipValidation(); - loadFromFile(u"xlsx/testTdf90749.xlsx"); { save(TestFilter::XLSX); @@ -603,9 +588,6 @@ CPPUNIT_TEST_FIXTURE(Chart2ExportTest2, testLeaderLines) CPPUNIT_TEST_FIXTURE(Chart2ExportTest2, testTdf161607PieChartLeaderLinesColorWidth) { - // FIXME: validation error in OOXML export - skipValidation(); - loadFromFile(u"xlsx/tdf161607PieChartLeaderLinesColorWidth.xlsx"); save(TestFilter::XLSX); xmlDocUniquePtr pXmlDoc = parseExport(u"xl/charts/chart1.xml"_ustr); @@ -878,9 +860,6 @@ CPPUNIT_TEST_FIXTURE(Chart2ExportTest2, testTdf122031) //Checks pie chart data label format. loadFromFile(u"xlsx/tdf122031.xlsx"); - // FIXME: validation error in OOXML export: Errors: 1 - skipValidation(); - save(TestFilter::XLSX); xmlDocUniquePtr pXmlDoc = parseExport(u"xl/charts/chart1.xml"_ustr); CPPUNIT_ASSERT(pXmlDoc); @@ -912,9 +891,6 @@ CPPUNIT_TEST_FIXTURE(Chart2ExportTest2, testTdf134118) { loadFromFile(u"xlsx/tdf134118.xlsx"); - // FIXME: validation error in OOXML export: Errors: 1 - skipValidation(); - save(TestFilter::XLSX); xmlDocUniquePtr pXmlDoc = parseExport(u"xl/charts/chart1.xml"_ustr); CPPUNIT_ASSERT(pXmlDoc); @@ -929,9 +905,6 @@ CPPUNIT_TEST_FIXTURE(Chart2ExportTest2, testTdf123206_customLabelText) Reference<chart2::XChartDocument> xChartDoc(getChartDocFromWriter(0), uno::UNO_QUERY); CPPUNIT_ASSERT(xChartDoc.is()); - // FIXME: validation error in OOXML export: Errors: 2 - skipValidation(); - save(TestFilter::DOCX); xmlDocUniquePtr pXmlDoc = parseExport(u"word/charts/chart1.xml"_ustr); CPPUNIT_ASSERT(pXmlDoc); @@ -960,9 +933,6 @@ CPPUNIT_TEST_FIXTURE(Chart2ExportTest2, testCustomLabelText) Reference<chart2::XChartDocument> xChartDoc(getChartDocFromWriter(0), uno::UNO_QUERY); CPPUNIT_ASSERT(xChartDoc.is()); - // FIXME: validation error in OOXML export: Errors: 3 - skipValidation(); - save(TestFilter::DOCX); xmlDocUniquePtr pXmlDoc = parseExport(u"word/charts/chart1.xml"_ustr); CPPUNIT_ASSERT(pXmlDoc); @@ -1168,9 +1138,6 @@ CPPUNIT_TEST_FIXTURE(Chart2ExportTest2, testTdf131979) CPPUNIT_TEST_FIXTURE(Chart2ExportTest2, testTdf132076) { - // FIXME: validation error in OOXML export: Errors: 1 - skipValidation(); - { loadFromFile(u"ods/tdf132076.ods"); save(TestFilter::XLSX); @@ -1215,9 +1182,6 @@ CPPUNIT_TEST_FIXTURE(Chart2ExportTest2, testTdf133190) { loadFromFile(u"xlsx/tdf133190_tdf133191.xlsx"); - // FIXME: validation error in OOXML export: Errors: 1 - skipValidation(); - save(TestFilter::XLSX); xmlDocUniquePtr pXmlDoc = parseExport(u"xl/charts/chart1.xml"_ustr); CPPUNIT_ASSERT(pXmlDoc); @@ -1237,9 +1201,6 @@ CPPUNIT_TEST_FIXTURE(Chart2ExportTest2, testTdf133191) { loadFromFile(u"xlsx/tdf133190_tdf133191.xlsx"); - // FIXME: validation error in OOXML export: Errors: 1 - skipValidation(); - save(TestFilter::XLSX); xmlDocUniquePtr pXmlDoc = parseExport(u"xl/charts/chart1.xml"_ustr); CPPUNIT_ASSERT(pXmlDoc); @@ -1275,9 +1236,6 @@ CPPUNIT_TEST_FIXTURE(Chart2ExportTest2, testTdf134255) CPPUNIT_ASSERT((xPropSet->getPropertyValue(u"TextWordWrap"_ustr) >>= bWrap)); CPPUNIT_ASSERT(bWrap); - // FIXME: validation error in OOXML export: Errors: 11 - skipValidation(); - // export test save(TestFilter::DOCX); xmlDocUniquePtr pXmlDoc = parseExport(u"word/charts/chart1.xml"_ustr); @@ -1305,9 +1263,6 @@ CPPUNIT_TEST_FIXTURE(Chart2ExportTest2, testTdf134977) aFields[0]->getPropertyValue(u"CharHeight"_ustr) >>= nFontSize; CPPUNIT_ASSERT_EQUAL(static_cast<float>(9), nFontSize); - // FIXME: validation error in OOXML export: Errors: 2 - skipValidation(); - //export test save(TestFilter::XLSX); xmlDocUniquePtr pXmlDoc = parseExport(u"xl/charts/chart1.xml"_ustr); @@ -1332,9 +1287,6 @@ CPPUNIT_TEST_FIXTURE(Chart2ExportTest2, testTdf136267) { loadFromFile(u"xlsx/tdf136267.xlsx"); - // FIXME: validation error in OOXML export: Errors: 2 - skipValidation(); - save(TestFilter::XLSX); xmlDocUniquePtr pXmlDoc = parseExport(u"xl/charts/chart1.xml"_ustr); CPPUNIT_ASSERT(pXmlDoc); @@ -1364,9 +1316,6 @@ CPPUNIT_TEST_FIXTURE(Chart2ExportTest2, testTdf137917) { loadFromFile(u"xlsx/tdf137917.xlsx"); - // FIXME: validation error in OOXML export: Errors: 1 - skipValidation(); - save(TestFilter::XLSX); xmlDocUniquePtr pXmlDoc = parseExport(u"xl/charts/chart1.xml"_ustr); CPPUNIT_ASSERT(pXmlDoc); @@ -1435,9 +1384,6 @@ CPPUNIT_TEST_FIXTURE(Chart2ExportTest2, testTdf138204) CPPUNIT_ASSERT_EQUAL(aTestEntry.aString, aFields[0]->getString()); } - // FIXME: validation error in OOXML export: Errors: 2 - skipValidation(); - save(TestFilter::XLSX); xmlDocUniquePtr pXmlDoc = parseExport(u"xl/charts/chart1.xml"_ustr); CPPUNIT_ASSERT(pXmlDoc); @@ -1627,9 +1573,6 @@ CPPUNIT_TEST_FIXTURE(Chart2ExportTest2, testTdf143942) CPPUNIT_ASSERT_EQUAL(aLabels[i], aFields[0]->getString()); } - // FIXME: validation error in OOXML export: Errors: 4 - skipValidation(); - save(TestFilter::XLSX); xmlDocUniquePtr pXmlDoc = parseExport(u"xl/charts/chart1.xml"_ustr); CPPUNIT_ASSERT(pXmlDoc); @@ -1667,9 +1610,6 @@ CPPUNIT_TEST_FIXTURE(Chart2ExportTest2, testDateCategoriesPPTX) { loadFromFile(u"pptx/bnc889755.pptx"); - // FIXME: validation error in OOXML export: Errors: 1 - skipValidation(); - save(TestFilter::PPTX); xmlDocUniquePtr pXmlDoc = parseExport(u"ppt/charts/chart1.xml"_ustr); CPPUNIT_ASSERT(pXmlDoc); @@ -1758,8 +1698,6 @@ CPPUNIT_TEST_FIXTURE(Chart2ExportTest2, testDataTableImportExport) CPPUNIT_TEST_FIXTURE(Chart2ExportTest2, testTdf166249) { loadFromFile(u"xlsx/tdf166249.xlsx"); - // FIXME: validation error in OOXML export - skipValidation(); save(TestFilter::XLSX); xmlDocUniquePtr pXmlDoc = parseExport(u"xl/charts/chart1.xml"_ustr); CPPUNIT_ASSERT(pXmlDoc);
